)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11610,"name":"Timothy R. Chavez","email":"timrchavez@us.ibm.com","username":"timrchavez"},"change_message_id":"aa57b9a6ad41a334542bb12797972746c9a96ca0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"It is considered an error if more than one router with the same"},{"line_number":14,"context_line":"name exists and you attempt to delete by name."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Also... MOAR TESTS!!! ZOMG"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ie6ea4eb5f2322bdda07e6db87e2cdbabea492ee9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa963961_bd3786af","line":16,"updated":"2015-03-27 21:11:41.000000000","message":"For rebuild the tests were moved to an individual test file, e.g. shade/tests/unit/test_rebuild.py (though that probably should be test_rebuild_server.py).  Should this do the same?","commit_id":"a333b20c0a159e60a91d4312d6fc28337fc3147b"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"63eddf31befc108031e04825fce88ce51c5de72e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"It is considered an error if more than one router with the same"},{"line_number":14,"context_line":"name exists and you attempt to delete by name."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Also... MOAR TESTS!!! ZOMG"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ie6ea4eb5f2322bdda07e6db87e2cdbabea492ee9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa963961_3dfa56be","line":16,"in_reply_to":"fa963961_bd3786af","updated":"2015-03-27 21:14:50.000000000","message":"The code is all due to be refactored in the near future anyway, so I don\u0027t see the need.","commit_id":"a333b20c0a159e60a91d4312d6fc28337fc3147b"}],"shade/__init__.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6391f4e5a8e1388835fda770dcf4b22e9a79b706","unresolved":false,"context_lines":[{"line_number":731,"context_line":"                \"Error creating router %s: %s\" % (name, e))"},{"line_number":732,"context_line":"        # Turns out neutron returns an actual dict, so no need for the"},{"line_number":733,"context_line":"        # use of meta.obj_to_dict() here (which would not work against"},{"line_number":734,"context_line":"        # a dict)."},{"line_number":735,"context_line":"        return new_router[\u0027router\u0027]"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"    def update_router(self, router_id, name\u003dNone, admin_state_up\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da9b358b_0474b4fa","line":734,"updated":"2015-03-31 18:29:05.000000000","message":"Possible improvement we should make to meta.obj_to_dict? in any case not necessary to make that change here.","commit_id":"ff25b8eb3bff5b162fc112a694f3838928f524ec"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6391f4e5a8e1388835fda770dcf4b22e9a79b706","unresolved":false,"context_lines":[{"line_number":734,"context_line":"        # a dict)."},{"line_number":735,"context_line":"        return new_router[\u0027router\u0027]"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"    def update_router(self, router_id, name\u003dNone, admin_state_up\u003dNone):"},{"line_number":738,"context_line":"        \"\"\"Update an existing logical router."},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"        :param router_id: The router UUID."}],"source_content_type":"text/x-python","patch_set":7,"id":"da9b358b_e461d03a","line":737,"updated":"2015-03-31 18:29:05.000000000","message":"This method should also accept an external gateway network_id (looking at docs http://developer.openstack.org/api-ref-networking-v2-ext.html this is how you get a router hooked up to an external facing network).","commit_id":"ff25b8eb3bff5b162fc112a694f3838928f524ec"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"a2572164cb9c107525551f18429e054f2307cbdb","unresolved":false,"context_lines":[{"line_number":734,"context_line":"        # a dict)."},{"line_number":735,"context_line":"        return new_router[\u0027router\u0027]"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"    def update_router(self, router_id, name\u003dNone, admin_state_up\u003dNone):"},{"line_number":738,"context_line":"        \"\"\"Update an existing logical router."},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"        :param router_id: The router UUID."}],"source_content_type":"text/x-python","patch_set":7,"id":"da9b358b_0f1a8d6e","line":737,"in_reply_to":"da9b358b_e461d03a","updated":"2015-03-31 18:35:47.000000000","message":"Thanks. Addressed in the followup review.","commit_id":"ff25b8eb3bff5b162fc112a694f3838928f524ec"}]}
