)]}'
{"shade/__init__.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"f71514faa4818f625bc5b1345b0da9f72e42506b","unresolved":false,"context_lines":[{"line_number":802,"context_line":"            if image_id \u003d\u003d name_or_id:"},{"line_number":803,"context_line":"                return image"},{"line_number":804,"context_line":"            if (image is not None and"},{"line_number":805,"context_line":"                    name_or_id \u003d\u003d image.name and ("},{"line_number":806,"context_line":"                    not exclude or exclude not in image.name)):"},{"line_number":807,"context_line":"                return image"},{"line_number":808,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":4,"id":"da9b358b_6dedce8a","line":805,"updated":"2015-03-30 21:19:40.000000000","message":"This looks like a significant unrelated change with no mention in the commit message.  Is it intentional (and is it correct)?","commit_id":"f87bdb1311b933b6279b0f6df6b930fa97575693"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"b4820d67d922b816167dc02bc325b6d2c38615bc","unresolved":false,"context_lines":[{"line_number":802,"context_line":"            if image_id \u003d\u003d name_or_id:"},{"line_number":803,"context_line":"                return image"},{"line_number":804,"context_line":"            if (image is not None and"},{"line_number":805,"context_line":"                    name_or_id \u003d\u003d image.name and ("},{"line_number":806,"context_line":"                    not exclude or exclude not in image.name)):"},{"line_number":807,"context_line":"                return image"},{"line_number":808,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa041b7_2c0a51d3","line":805,"in_reply_to":"da9b358b_6dedce8a","updated":"2015-04-01 22:53:50.000000000","message":"Yes. This has been separated into a separate change, If33bfe5c1e32b36c27c32cfcba4c07dcf01a4e74, which has been merged.","commit_id":"f87bdb1311b933b6279b0f6df6b930fa97575693"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"f71514faa4818f625bc5b1345b0da9f72e42506b","unresolved":false,"context_lines":[{"line_number":820,"context_line":""},{"line_number":821,"context_line":"    def create_image_snapshot(self, name, **metadata):"},{"line_number":822,"context_line":"        image \u003d self.manager.submitTask(_tasks.ImageSnapshotCreate("},{"line_number":823,"context_line":"            name, **metadata))"},{"line_number":824,"context_line":"        if image:"},{"line_number":825,"context_line":"            return meta.obj_to_dict(image)"},{"line_number":826,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":4,"id":"da9b358b_4d032a43","line":823,"updated":"2015-03-30 21:19:40.000000000","message":"Should name be a keyword arg to the task?  I think it needs to be in the current API; you _could_ extend the ImageSnapshotCreate task to accept positional and keyword args, but I think the more consistent thing to do would be to change the task args here to \"name\u003dname, metadata\u003dmetadata\".","commit_id":"f87bdb1311b933b6279b0f6df6b930fa97575693"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"b4820d67d922b816167dc02bc325b6d2c38615bc","unresolved":false,"context_lines":[{"line_number":820,"context_line":""},{"line_number":821,"context_line":"    def create_image_snapshot(self, name, **metadata):"},{"line_number":822,"context_line":"        image \u003d self.manager.submitTask(_tasks.ImageSnapshotCreate("},{"line_number":823,"context_line":"            name, **metadata))"},{"line_number":824,"context_line":"        if image:"},{"line_number":825,"context_line":"            return meta.obj_to_dict(image)"},{"line_number":826,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa041b7_4c2c754a","line":823,"in_reply_to":"da9b358b_4d032a43","updated":"2015-04-01 22:53:50.000000000","message":"yup. fixed in ps5","commit_id":"f87bdb1311b933b6279b0f6df6b930fa97575693"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"f71514faa4818f625bc5b1345b0da9f72e42506b","unresolved":false,"context_lines":[{"line_number":878,"context_line":"        # using glance properties to not delete then upload but instead make a"},{"line_number":879,"context_line":"        # new \"good\" image and then mark the old one as \"bad\""},{"line_number":880,"context_line":"        # self.glance_client.images.delete(current_image)"},{"line_number":881,"context_line":"        task \u003d self.manager.submitTask(_tasks.ImageTaskCreate("},{"line_number":882,"context_line":"            type\u003d\u0027import\u0027, input\u003ddict("},{"line_number":883,"context_line":"                import_from\u003d\u0027{container}/{name}\u0027.format("},{"line_number":884,"context_line":"                    container\u003dcontainer, name\u003dname),"}],"source_content_type":"text/x-python","patch_set":4,"id":"da9b358b_2d00e633","line":881,"updated":"2015-03-30 21:19:40.000000000","message":"0: Potentially confusing because the word task is overloaded and you are saying glance_task \u003d shade.submitTask(shadeTask()).  Maybe worth switching \u0027task\u0027 to \u0027glance_task\u0027 here.  If not, it\u0027s okay -- the pattern isn\u0027t used anywhere else and people should be able to cope.","commit_id":"f87bdb1311b933b6279b0f6df6b930fa97575693"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"b4820d67d922b816167dc02bc325b6d2c38615bc","unresolved":false,"context_lines":[{"line_number":878,"context_line":"        # using glance properties to not delete then upload but instead make a"},{"line_number":879,"context_line":"        # new \"good\" image and then mark the old one as \"bad\""},{"line_number":880,"context_line":"        # self.glance_client.images.delete(current_image)"},{"line_number":881,"context_line":"        task \u003d self.manager.submitTask(_tasks.ImageTaskCreate("},{"line_number":882,"context_line":"            type\u003d\u0027import\u0027, input\u003ddict("},{"line_number":883,"context_line":"                import_from\u003d\u0027{container}/{name}\u0027.format("},{"line_number":884,"context_line":"                    container\u003dcontainer, name\u003dname),"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa041b7_2c3131a3","line":881,"in_reply_to":"da9b358b_2d00e633","updated":"2015-04-01 22:53:50.000000000","message":"Done","commit_id":"f87bdb1311b933b6279b0f6df6b930fa97575693"}],"shade/_tasks.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"f71514faa4818f625bc5b1345b0da9f72e42506b","unresolved":false,"context_lines":[{"line_number":105,"context_line":"# TODO: Do can we use client.glance_client.images.update?"},{"line_number":106,"context_line":"class ImageFileUpload(task_manager.Task):"},{"line_number":107,"context_line":"    def main(self, client):"},{"line_number":108,"context_line":"        image \u003d self.args.pop(\u0027image\u0027)"},{"line_number":109,"context_line":"        image.update(data\u003dopen(self.args[\u0027filename\u0027], \u0027rb\u0027))"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da9b358b_0dfd223a","line":108,"updated":"2015-03-30 21:19:40.000000000","message":"Why pop here?  You aren\u0027t using self.args after this, and while we don\u0027t currently express a preference for whether Task.args should be immutable, this creates one without a real need.","commit_id":"f87bdb1311b933b6279b0f6df6b930fa97575693"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"b4820d67d922b816167dc02bc325b6d2c38615bc","unresolved":false,"context_lines":[{"line_number":105,"context_line":"# TODO: Do can we use client.glance_client.images.update?"},{"line_number":106,"context_line":"class ImageFileUpload(task_manager.Task):"},{"line_number":107,"context_line":"    def main(self, client):"},{"line_number":108,"context_line":"        image \u003d self.args.pop(\u0027image\u0027)"},{"line_number":109,"context_line":"        image.update(data\u003dopen(self.args[\u0027filename\u0027], \u0027rb\u0027))"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baa041b7_2c6371b3","line":108,"in_reply_to":"da9b358b_0dfd223a","updated":"2015-04-01 22:53:50.000000000","message":"Yes. I have removed this and replaced this entire construct with client.glance_client.images.update(**self.args)","commit_id":"f87bdb1311b933b6279b0f6df6b930fa97575693"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"f71514faa4818f625bc5b1345b0da9f72e42506b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"# TODO can we replace this with ImageUpdate ?"},{"line_number":128,"context_line":"class ImageUpdateProperties(task_manager.Task):"},{"line_number":129,"context_line":"    def main(self, client):"},{"line_number":130,"context_line":"        image \u003d self.args.pop(\u0027image\u0027)"},{"line_number":131,"context_line":"        image.update(**self.args)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da9b358b_edf9de4e","line":130,"updated":"2015-03-30 21:19:40.000000000","message":"Oh.  This makes more sense.  This example is worth deciding whether self.args should be immutable.","commit_id":"f87bdb1311b933b6279b0f6df6b930fa97575693"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"b4820d67d922b816167dc02bc325b6d2c38615bc","unresolved":false,"context_lines":[{"line_number":127,"context_line":"# TODO can we replace this with ImageUpdate ?"},{"line_number":128,"context_line":"class ImageUpdateProperties(task_manager.Task):"},{"line_number":129,"context_line":"    def main(self, client):"},{"line_number":130,"context_line":"        image \u003d self.args.pop(\u0027image\u0027)"},{"line_number":131,"context_line":"        image.update(**self.args)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baa041b7_ec5c69ef","line":130,"in_reply_to":"da9b358b_edf9de4e","updated":"2015-04-01 22:53:50.000000000","message":"Same reply as above.","commit_id":"f87bdb1311b933b6279b0f6df6b930fa97575693"}]}
