)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"78e84918a518ec49a8899576f481e6af8b2369c8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"set_machine_power_reboot."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Tests to utilize the on, off, and reboot methods have been"},{"line_number":15,"context_line":"which all invok the _set_machine_power_state method."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I4e1ce863d5a93d81ec90ae1c244cbfef68912916"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5ad0253b_0912f9b4","line":15,"updated":"2015-04-28 17:36:50.000000000","message":"nit: s/invok/invoke","commit_id":"53b8a776237bef5109e75ef05d9c854a50be6abc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1f32e4bd8586293a542bf6725547d57c4a38e075","unresolved":false,"context_lines":[{"line_number":12,"context_line":"set_machine_power_reboot."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Tests to utilize the on, off, and reboot methods have been"},{"line_number":15,"context_line":"which all invok the _set_machine_power_state method."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I4e1ce863d5a93d81ec90ae1c244cbfef68912916"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5ad0253b_013c0d92","line":15,"in_reply_to":"5ad0253b_0912f9b4","updated":"2015-04-28 19:11:09.000000000","message":"Done","commit_id":"53b8a776237bef5109e75ef05d9c854a50be6abc"}],"shade/__init__.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"34bd8f80c5b3e2d7905dcb859cbef2c89ad5b4d3","unresolved":false,"context_lines":[{"line_number":1930,"context_line":"    def remove_machine_from_maintenance(self, id_or_name):"},{"line_number":1931,"context_line":"        self.set_machine_maintenance_state(id_or_name, False)"},{"line_number":1932,"context_line":""},{"line_number":1933,"context_line":"    def set_machine_power_state(self, id_or_name, state):"},{"line_number":1934,"context_line":"        try:"},{"line_number":1935,"context_line":"            if state is \u0027on\u0027:"},{"line_number":1936,"context_line":"                return self.manager.submitTask("}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_2743e2b3","line":1933,"updated":"2015-04-10 13:48:03.000000000","message":"Also, use \u0027name_or_id\u0027 to be consistent with other methods.","commit_id":"bcc096aac8fb0917a3bc40608d4cb803c686ea2e"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"191260f5afaa8afc3ba32d6d1e5c1a836f385672","unresolved":false,"context_lines":[{"line_number":1930,"context_line":"    def remove_machine_from_maintenance(self, id_or_name):"},{"line_number":1931,"context_line":"        self.set_machine_maintenance_state(id_or_name, False)"},{"line_number":1932,"context_line":""},{"line_number":1933,"context_line":"    def set_machine_power_state(self, id_or_name, state):"},{"line_number":1934,"context_line":"        try:"},{"line_number":1935,"context_line":"            if state is \u0027on\u0027:"},{"line_number":1936,"context_line":"                return self.manager.submitTask("}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_67256a5a","line":1933,"updated":"2015-04-10 13:40:47.000000000","message":"If you have set_machine_power_on() and set_machine_power_off() as the exposed APIs that just call this method, then let\u0027s rename this one to _set_machine_power_on() to indicate that clients should not invoke it directly.","commit_id":"bcc096aac8fb0917a3bc40608d4cb803c686ea2e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a1146c87f946aee3bf8e3102a8f5855d4ca938c9","unresolved":false,"context_lines":[{"line_number":1930,"context_line":"    def remove_machine_from_maintenance(self, id_or_name):"},{"line_number":1931,"context_line":"        self.set_machine_maintenance_state(id_or_name, False)"},{"line_number":1932,"context_line":""},{"line_number":1933,"context_line":"    def set_machine_power_state(self, id_or_name, state):"},{"line_number":1934,"context_line":"        try:"},{"line_number":1935,"context_line":"            if state is \u0027on\u0027:"},{"line_number":1936,"context_line":"                return self.manager.submitTask("}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_072cce00","line":1933,"in_reply_to":"9aa53dc9_2743e2b3","updated":"2015-04-14 11:35:27.000000000","message":"Done","commit_id":"bcc096aac8fb0917a3bc40608d4cb803c686ea2e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a1146c87f946aee3bf8e3102a8f5855d4ca938c9","unresolved":false,"context_lines":[{"line_number":1930,"context_line":"    def remove_machine_from_maintenance(self, id_or_name):"},{"line_number":1931,"context_line":"        self.set_machine_maintenance_state(id_or_name, False)"},{"line_number":1932,"context_line":""},{"line_number":1933,"context_line":"    def set_machine_power_state(self, id_or_name, state):"},{"line_number":1934,"context_line":"        try:"},{"line_number":1935,"context_line":"            if state is \u0027on\u0027:"},{"line_number":1936,"context_line":"                return self.manager.submitTask("}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_673b9239","line":1933,"in_reply_to":"9aa53dc9_67256a5a","updated":"2015-04-14 11:35:27.000000000","message":"Done","commit_id":"bcc096aac8fb0917a3bc40608d4cb803c686ea2e"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"191260f5afaa8afc3ba32d6d1e5c1a836f385672","unresolved":false,"context_lines":[{"line_number":1945,"context_line":"                \"failed setting failed\", exc_info\u003dTrue)"},{"line_number":1946,"context_line":"            raise OpenStackCloudException("},{"line_number":1947,"context_line":"                \"ironic error setting power state \""},{"line_number":1948,"context_line":"                \"state: %s\" % e.message)"},{"line_number":1949,"context_line":"        raise OpenStackCloudException("},{"line_number":1950,"context_line":"            \"Unsupported power state requested. \""},{"line_number":1951,"context_line":"            \"state: %s\" % state)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_e754daca","line":1948,"updated":"2015-04-10 13:40:47.000000000","message":"e.message is not valid. Just use e.\n\nRemove \u0027ironic\u0027 from the message.","commit_id":"bcc096aac8fb0917a3bc40608d4cb803c686ea2e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a1146c87f946aee3bf8e3102a8f5855d4ca938c9","unresolved":false,"context_lines":[{"line_number":1945,"context_line":"                \"failed setting failed\", exc_info\u003dTrue)"},{"line_number":1946,"context_line":"            raise OpenStackCloudException("},{"line_number":1947,"context_line":"                \"ironic error setting power state \""},{"line_number":1948,"context_line":"                \"state: %s\" % e.message)"},{"line_number":1949,"context_line":"        raise OpenStackCloudException("},{"line_number":1950,"context_line":"            \"Unsupported power state requested. \""},{"line_number":1951,"context_line":"            \"state: %s\" % state)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_8af90583","line":1948,"in_reply_to":"9aa53dc9_e754daca","updated":"2015-04-14 11:35:27.000000000","message":"Done","commit_id":"bcc096aac8fb0917a3bc40608d4cb803c686ea2e"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"34bd8f80c5b3e2d7905dcb859cbef2c89ad5b4d3","unresolved":false,"context_lines":[{"line_number":1950,"context_line":"            \"Unsupported power state requested. \""},{"line_number":1951,"context_line":"            \"state: %s\" % state)"},{"line_number":1952,"context_line":""},{"line_number":1953,"context_line":"    def set_machine_power_on(self, id_or_name):"},{"line_number":1954,"context_line":"        return self.set_machine_power_state(id_or_name, \u0027on\u0027)"},{"line_number":1955,"context_line":""},{"line_number":1956,"context_line":"    def set_machine_power_off(self, id_or_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_c74316ae","line":1953,"updated":"2015-04-10 13:48:03.000000000","message":"name_or_id","commit_id":"bcc096aac8fb0917a3bc40608d4cb803c686ea2e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a1146c87f946aee3bf8e3102a8f5855d4ca938c9","unresolved":false,"context_lines":[{"line_number":1950,"context_line":"            \"Unsupported power state requested. \""},{"line_number":1951,"context_line":"            \"state: %s\" % state)"},{"line_number":1952,"context_line":""},{"line_number":1953,"context_line":"    def set_machine_power_on(self, id_or_name):"},{"line_number":1954,"context_line":"        return self.set_machine_power_state(id_or_name, \u0027on\u0027)"},{"line_number":1955,"context_line":""},{"line_number":1956,"context_line":"    def set_machine_power_off(self, id_or_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_07896e26","line":1953,"in_reply_to":"9aa53dc9_c74316ae","updated":"2015-04-14 11:35:27.000000000","message":"Done","commit_id":"bcc096aac8fb0917a3bc40608d4cb803c686ea2e"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"34bd8f80c5b3e2d7905dcb859cbef2c89ad5b4d3","unresolved":false,"context_lines":[{"line_number":1953,"context_line":"    def set_machine_power_on(self, id_or_name):"},{"line_number":1954,"context_line":"        return self.set_machine_power_state(id_or_name, \u0027on\u0027)"},{"line_number":1955,"context_line":""},{"line_number":1956,"context_line":"    def set_machine_power_off(self, id_or_name):"},{"line_number":1957,"context_line":"        return self.set_machine_power_state(id_or_name, \u0027off\u0027)"},{"line_number":1958,"context_line":""},{"line_number":1959,"context_line":"    def activate_node(self, uuid, configdrive\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_a715b29c","line":1956,"updated":"2015-04-10 13:48:03.000000000","message":"name_or_id","commit_id":"bcc096aac8fb0917a3bc40608d4cb803c686ea2e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a1146c87f946aee3bf8e3102a8f5855d4ca938c9","unresolved":false,"context_lines":[{"line_number":1953,"context_line":"    def set_machine_power_on(self, id_or_name):"},{"line_number":1954,"context_line":"        return self.set_machine_power_state(id_or_name, \u0027on\u0027)"},{"line_number":1955,"context_line":""},{"line_number":1956,"context_line":"    def set_machine_power_off(self, id_or_name):"},{"line_number":1957,"context_line":"        return self.set_machine_power_state(id_or_name, \u0027off\u0027)"},{"line_number":1958,"context_line":""},{"line_number":1959,"context_line":"    def activate_node(self, uuid, configdrive\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_47a0969f","line":1956,"in_reply_to":"9aa53dc9_a715b29c","updated":"2015-04-14 11:35:27.000000000","message":"Done","commit_id":"bcc096aac8fb0917a3bc40608d4cb803c686ea2e"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"ee17267e4350d9e448b5bd0149123cb57508d415","unresolved":false,"context_lines":[{"line_number":1998,"context_line":"                              \"off\". A value other than \"on\" or \"off\" will"},{"line_number":1999,"context_line":"                              raise OpenStackCloudException."},{"line_number":2000,"context_line":""},{"line_number":2001,"context_line":"        :returns: Ironic Node Oobject upon completion of the request."},{"line_number":2002,"context_line":"        \"\"\""},{"line_number":2003,"context_line":"        try:"},{"line_number":2004,"context_line":"            if state is \u0027on\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aaa499b_a9b5ddee","line":2001,"updated":"2015-04-14 18:29:40.000000000","message":"s/Oobject/Object/\n\nIt should not return a Node object. It should be returning a dict representation of whatever object is returned. You will need to use the meta.obj_to_dict() method to transform it.","commit_id":"46d6cbc9e04e4729508b17ce4fe652590a0af84a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ea2ad530d139475ef46ae84fa379df0d7f592223","unresolved":false,"context_lines":[{"line_number":1998,"context_line":"                              \"off\". A value other than \"on\" or \"off\" will"},{"line_number":1999,"context_line":"                              raise OpenStackCloudException."},{"line_number":2000,"context_line":""},{"line_number":2001,"context_line":"        :returns: Ironic Node Oobject upon completion of the request."},{"line_number":2002,"context_line":"        \"\"\""},{"line_number":2003,"context_line":"        try:"},{"line_number":2004,"context_line":"            if state is \u0027on\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aaa499b_10dd0d0e","line":2001,"in_reply_to":"7aaa499b_a9b5ddee","updated":"2015-04-14 23:05:40.000000000","message":"Done","commit_id":"46d6cbc9e04e4729508b17ce4fe652590a0af84a"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"ee17267e4350d9e448b5bd0149123cb57508d415","unresolved":false,"context_lines":[{"line_number":2008,"context_line":"            elif state is \u0027off\u0027:"},{"line_number":2009,"context_line":"                return self.manager.submitTask("},{"line_number":2010,"context_line":"                    _tasks.MachineSetPower(node_id\u003dname_or_id,"},{"line_number":2011,"context_line":"                                           state\u003d\u0027off\u0027))"},{"line_number":2012,"context_line":"        except Exception as e:"},{"line_number":2013,"context_line":"            self.log.debug("},{"line_number":2014,"context_line":"                \"Error setting machine power state on node %s. User \""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aaa499b_09c5f159","line":2011,"updated":"2015-04-14 18:29:40.000000000","message":"Why use if-elif here? Just use state\u003dstate in the call. If you are concerned about an invalid state value, you should check that before calling MachineSetPower.","commit_id":"46d6cbc9e04e4729508b17ce4fe652590a0af84a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ea2ad530d139475ef46ae84fa379df0d7f592223","unresolved":false,"context_lines":[{"line_number":2008,"context_line":"            elif state is \u0027off\u0027:"},{"line_number":2009,"context_line":"                return self.manager.submitTask("},{"line_number":2010,"context_line":"                    _tasks.MachineSetPower(node_id\u003dname_or_id,"},{"line_number":2011,"context_line":"                                           state\u003d\u0027off\u0027))"},{"line_number":2012,"context_line":"        except Exception as e:"},{"line_number":2013,"context_line":"            self.log.debug("},{"line_number":2014,"context_line":"                \"Error setting machine power state on node %s. User \""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aaa499b_d0d44521","line":2011,"in_reply_to":"7aaa499b_09c5f159","updated":"2015-04-14 23:05:40.000000000","message":"Great point, removing excess code.","commit_id":"46d6cbc9e04e4729508b17ce4fe652590a0af84a"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"193177425e1f0cdf315952fbafd702d4c0cdc889","unresolved":false,"context_lines":[{"line_number":2301,"context_line":"                                   node to have power turned to an \"off\""},{"line_number":2302,"context_line":"                                   state."},{"line_number":2303,"context_line":""},{"line_number":2304,"context_line":"        :returns: Ironic Node Oobject upon completion of the request."},{"line_number":2305,"context_line":"        \"\"\""},{"line_number":2306,"context_line":"        return self._set_machine_power_state(name_or_id, \u0027off\u0027)"},{"line_number":2307,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5aa745d1_8e76f93c","line":2304,"updated":"2015-04-16 07:34:53.000000000","message":"You mean returns dict ? :)","commit_id":"da76faf3accbf818b8e0527a37cd04a7aac91b36"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5ddb58c89324d4f12121444460f357f7b837ccf6","unresolved":false,"context_lines":[{"line_number":2301,"context_line":"                                   node to have power turned to an \"off\""},{"line_number":2302,"context_line":"                                   state."},{"line_number":2303,"context_line":""},{"line_number":2304,"context_line":"        :returns: Ironic Node Oobject upon completion of the request."},{"line_number":2305,"context_line":"        \"\"\""},{"line_number":2306,"context_line":"        return self._set_machine_power_state(name_or_id, \u0027off\u0027)"},{"line_number":2307,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5aa745d1_6d74ca9b","line":2304,"in_reply_to":"5aa745d1_8e76f93c","updated":"2015-04-16 11:57:19.000000000","message":"Yes, Looks likeI completely forgot to update the docstring for on/off.  Thank you for spotting that.","commit_id":"da76faf3accbf818b8e0527a37cd04a7aac91b36"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"9fc8095392134f69e2240e3c27104fbe2afa6f8e","unresolved":false,"context_lines":[{"line_number":2487,"context_line":"                              a string value in the event that the state"},{"line_number":2488,"context_line":"                              assertion support expands beyond \"on\" or"},{"line_number":2489,"context_line":"                              \"off\". A value other than \"on\" or \"off\" will"},{"line_number":2490,"context_line":"                              raise OpenStackCloudException."},{"line_number":2491,"context_line":""},{"line_number":2492,"context_line":"        :returns: Per the API, an empty string should be expected when"},{"line_number":2493,"context_line":"                  successful."}],"source_content_type":"text/x-python","patch_set":10,"id":"bab921fb_0b5dd178","line":2490,"updated":"2015-04-24 22:14:39.000000000","message":"you only talk about on/off states there, but no reboot. And there is a reboot method, how does it fit there?","commit_id":"d0e7c9c44e447a832f415c1a5f98e5626b6dfd24"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"16e31d843948f978f2e97e7ac123e9c7b9366b98","unresolved":false,"context_lines":[{"line_number":2487,"context_line":"                              a string value in the event that the state"},{"line_number":2488,"context_line":"                              assertion support expands beyond \"on\" or"},{"line_number":2489,"context_line":"                              \"off\". A value other than \"on\" or \"off\" will"},{"line_number":2490,"context_line":"                              raise OpenStackCloudException."},{"line_number":2491,"context_line":""},{"line_number":2492,"context_line":"        :returns: Per the API, an empty string should be expected when"},{"line_number":2493,"context_line":"                  successful."}],"source_content_type":"text/x-python","patch_set":10,"id":"9abe1de1_941df511","line":2490,"in_reply_to":"bab921fb_0b5dd178","updated":"2015-04-27 13:07:26.000000000","message":"I thought I updated the docstring for reboot when I added it, but guess I did not.  Will fix.  Thanks!","commit_id":"d0e7c9c44e447a832f415c1a5f98e5626b6dfd24"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"78e84918a518ec49a8899576f481e6af8b2369c8","unresolved":false,"context_lines":[{"line_number":2495,"context_line":""},{"line_number":2496,"context_line":"        :raises: OpenStackCloudException on operation error."},{"line_number":2497,"context_line":""},{"line_number":2498,"context_line":"        :returns: Per the API, an None should be expected when"},{"line_number":2499,"context_line":"                  successful."},{"line_number":2500,"context_line":"        \"\"\""},{"line_number":2501,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":12,"id":"5ad0253b_4490d895","line":2498,"updated":"2015-04-28 17:36:50.000000000","message":"AFAICT this is going to always return a dict, not None?","commit_id":"53b8a776237bef5109e75ef05d9c854a50be6abc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"968ef203495676ac2085606f49912fe253cb1db9","unresolved":false,"context_lines":[{"line_number":2495,"context_line":""},{"line_number":2496,"context_line":"        :raises: OpenStackCloudException on operation error."},{"line_number":2497,"context_line":""},{"line_number":2498,"context_line":"        :returns: Per the API, an None should be expected when"},{"line_number":2499,"context_line":"                  successful."},{"line_number":2500,"context_line":"        \"\"\""},{"line_number":2501,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":12,"id":"5ad0253b_afec2590","line":2498,"in_reply_to":"5ad0253b_4490d895","updated":"2015-04-28 18:15:24.000000000","message":"AFAICT, it returns the message body which on success is always \u0027\u0027, which gets translated to None when you actually use ironicclient.","commit_id":"53b8a776237bef5109e75ef05d9c854a50be6abc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8b10bb86b85a8915768b80564bfd3e830fa8cfe1","unresolved":false,"context_lines":[{"line_number":2495,"context_line":""},{"line_number":2496,"context_line":"        :raises: OpenStackCloudException on operation error."},{"line_number":2497,"context_line":""},{"line_number":2498,"context_line":"        :returns: Per the API, an None should be expected when"},{"line_number":2499,"context_line":"                  successful."},{"line_number":2500,"context_line":"        \"\"\""},{"line_number":2501,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":12,"id":"5ad0253b_01040d13","line":2498,"in_reply_to":"5ad0253b_afec2590","updated":"2015-04-28 19:05:07.000000000","message":"Confusion identified, Fixing.","commit_id":"53b8a776237bef5109e75ef05d9c854a50be6abc"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"78e84918a518ec49a8899576f481e6af8b2369c8","unresolved":false,"context_lines":[{"line_number":2523,"context_line":"    def set_machine_power_on(self, name_or_id):"},{"line_number":2524,"context_line":"        \"\"\"Activate baremetal machine power"},{"line_number":2525,"context_line":""},{"line_number":2526,"context_line":"        This is a wrapper for _set_machine_power_state that sets the node"},{"line_number":2527,"context_line":"        power state to \"on\"."},{"line_number":2528,"context_line":""},{"line_number":2529,"context_line":"        :params string name_or_id: A string representing the baremetal"}],"source_content_type":"text/x-python","patch_set":12,"id":"5ad0253b_c9b5217f","line":2526,"updated":"2015-04-28 17:36:50.000000000","message":"Nit: referring to private methods in the docs for a public method is not very useful in generated docs (since they often dont contain the private method docs).","commit_id":"53b8a776237bef5109e75ef05d9c854a50be6abc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1f32e4bd8586293a542bf6725547d57c4a38e075","unresolved":false,"context_lines":[{"line_number":2523,"context_line":"    def set_machine_power_on(self, name_or_id):"},{"line_number":2524,"context_line":"        \"\"\"Activate baremetal machine power"},{"line_number":2525,"context_line":""},{"line_number":2526,"context_line":"        This is a wrapper for _set_machine_power_state that sets the node"},{"line_number":2527,"context_line":"        power state to \"on\"."},{"line_number":2528,"context_line":""},{"line_number":2529,"context_line":"        :params string name_or_id: A string representing the baremetal"}],"source_content_type":"text/x-python","patch_set":12,"id":"5ad0253b_e1a47109","line":2526,"in_reply_to":"5ad0253b_c9b5217f","updated":"2015-04-28 19:11:09.000000000","message":"Done","commit_id":"53b8a776237bef5109e75ef05d9c854a50be6abc"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"15e1f923fd5a7463673ac784cad5ed965154585a","unresolved":false,"context_lines":[{"line_number":2528,"context_line":"        This is a method that sets the node power state to \"on\"."},{"line_number":2529,"context_line":""},{"line_number":2530,"context_line":""},{"line_number":2531,"context_line":""},{"line_number":2532,"context_line":"        :params string name_or_id: A string representing the baremetal"},{"line_number":2533,"context_line":"                                   node to have power turned to an \"on\""},{"line_number":2534,"context_line":"                                   state."}],"source_content_type":"text/x-python","patch_set":14,"id":"3acd31a7_45a7ad4f","line":2531,"updated":"2015-04-29 19:32:10.000000000","message":"nit: too much whitespace. one line is sufficient.","commit_id":"f2bf8d902e0d2751cfaac1ccebaa7fb9ee19decd"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"15e1f923fd5a7463673ac784cad5ed965154585a","unresolved":false,"context_lines":[{"line_number":2556,"context_line":"        :returns: Per the API, upon successful requests an empty message"},{"line_number":2557,"context_line":"                  body is returned.  This is converted to a dictonary for"},{"line_number":2558,"context_line":"                  ease of use should the behavior or necessary behavior"},{"line_number":2559,"context_line":"                  change."},{"line_number":2560,"context_line":"        \"\"\""},{"line_number":2561,"context_line":"        return self._set_machine_power_state(name_or_id, \u0027off\u0027)"},{"line_number":2562,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3acd31a7_20d37f3a","line":2559,"updated":"2015-04-29 19:32:10.000000000","message":"If the point of shade is to abstract away the underlying API (in this case, ironic) it seems odd that our public facing documentation would state that our return value is dependent on the Ironic return value.\n\nI\u0027d rather we just state what shade\u0027s return value is (thus cementing our API) regardless of what ironic API does. For example, why don\u0027t we just return True or False here for success or failure? Or, possibly better, return nothing and it either raises an exception on error, or doesn\u0027t on success. An empty dict is of no use to anyone.","commit_id":"f2bf8d902e0d2751cfaac1ccebaa7fb9ee19decd"}],"shade/tests/unit/test_shade.py":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"193177425e1f0cdf315952fbafd702d4c0cdc889","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    @mock.patch.object(shade.OperatorCloud, \u0027ironic_client\u0027)"},{"line_number":223,"context_line":"    def test_set_machine_power_on(self, mock_client):"},{"line_number":224,"context_line":"        node_id \u003d \u0027node01\u0027"},{"line_number":225,"context_line":"        self.cloud.set_machine_power_on(node_id)"},{"line_number":226,"context_line":"        mock_client.node.set_power_state.assert_called_with("},{"line_number":227,"context_line":"            node_id\u003d\u0027node01\u0027,"},{"line_number":228,"context_line":"            state\u003d\u0027on\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5aa745d1_ae79b531","line":225,"updated":"2015-04-16 07:34:53.000000000","message":"Can haz test return code? kthxbai!","commit_id":"da76faf3accbf818b8e0527a37cd04a7aac91b36"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5ddb58c89324d4f12121444460f357f7b837ccf6","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    @mock.patch.object(shade.OperatorCloud, \u0027ironic_client\u0027)"},{"line_number":223,"context_line":"    def test_set_machine_power_on(self, mock_client):"},{"line_number":224,"context_line":"        node_id \u003d \u0027node01\u0027"},{"line_number":225,"context_line":"        self.cloud.set_machine_power_on(node_id)"},{"line_number":226,"context_line":"        mock_client.node.set_power_state.assert_called_with("},{"line_number":227,"context_line":"            node_id\u003d\u0027node01\u0027,"},{"line_number":228,"context_line":"            state\u003d\u0027on\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5aa745d1_8db6f63b","line":225,"in_reply_to":"5aa745d1_ae79b531","updated":"2015-04-16 11:57:19.000000000","message":"Sure!","commit_id":"da76faf3accbf818b8e0527a37cd04a7aac91b36"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"29eb904a77a32209f112492600a7e8fbf6784c5b","unresolved":false,"context_lines":[{"line_number":522,"context_line":"        mock_client.node.set_power_state.return_value \u003d None"},{"line_number":523,"context_line":"        node_id \u003d \u0027node01\u0027"},{"line_number":524,"context_line":"        return_value \u003d self.cloud.set_machine_power_on(node_id)"},{"line_number":525,"context_line":"        self.assertEqual({}, return_value)"},{"line_number":526,"context_line":"        mock_client.node.set_power_state.assert_called_with("},{"line_number":527,"context_line":"            node_id\u003d\u0027node01\u0027,"},{"line_number":528,"context_line":"            state\u003d\u0027on\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"3acd31a7_1b823c53","line":525,"updated":"2015-04-29 16:18:36.000000000","message":"One has to wonder why the return for such an update isn\u0027t just boolean True/False based on whether or not power state was changed?","commit_id":"f2bf8d902e0d2751cfaac1ccebaa7fb9ee19decd"}]}