)]}'
{"shade/tests/unit/test_caching.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"6bb161312300c73f9f30336db8efe4d035a34819","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        imagefile.close()"},{"line_number":251,"context_line":"        self.cloud.create_image(\u002742 name\u0027, imagefile.name)"},{"line_number":252,"context_line":"        glance_mock.images.create.assert_called_once()"},{"line_number":253,"context_line":"        glance_mock.images.update.assert_called_once()"},{"line_number":254,"context_line":"        self.assertEqual({\u002742\u0027: fake_image}, self.cloud.list_images())"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_ccf6f4f8","line":253,"updated":"2015-04-21 17:45:43.000000000","message":"This is an unfortunately common mock error. This is no method called assert_called_once(), and mock will happily ignore that fact.","commit_id":"450ba59d05f7129abe37e2ef3ecb839cef252184"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"efc47f85ad9ac09e178d119d14e99e8ea44d5e39","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    def test_create_image_v1(self, glance_mock):"},{"line_number":247,"context_line":"        self.cloud.api_versions[\u0027image\u0027] \u003d \u00271\u0027"},{"line_number":248,"context_line":"        glance_mock.images.list.return_value \u003d []"},{"line_number":249,"context_line":"        self.assertEqual({}, self.cloud.list_images())"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        class Image(object):"},{"line_number":252,"context_line":"            id \u003d \u002742\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab921fb_cebabc6e","line":249,"updated":"2015-04-22 23:22:24.000000000","message":"These two lines seem to scream bug to me. glance returns a list but shade returns a dict? I know shade is trying to make things sane but wouldn\u0027t you expect list_images() to well return a list of images?","commit_id":"e351f5090251ae63b771f7949a0455c026448ac7"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"379e7998d3b0d66dd39a46e6620b100a44ab23fa","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    def test_create_image_v1(self, glance_mock):"},{"line_number":247,"context_line":"        self.cloud.api_versions[\u0027image\u0027] \u003d \u00271\u0027"},{"line_number":248,"context_line":"        glance_mock.images.list.return_value \u003d []"},{"line_number":249,"context_line":"        self.assertEqual({}, self.cloud.list_images())"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        class Image(object):"},{"line_number":252,"context_line":"            id \u003d \u002742\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab921fb_6903aab9","line":249,"in_reply_to":"bab921fb_8e2284b8","updated":"2015-04-22 23:42:35.000000000","message":"Agree. list_images() should return a list.","commit_id":"e351f5090251ae63b771f7949a0455c026448ac7"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"e5184cbff62e79ad59da85bac465cd2dff0e07f1","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    def test_create_image_v1(self, glance_mock):"},{"line_number":247,"context_line":"        self.cloud.api_versions[\u0027image\u0027] \u003d \u00271\u0027"},{"line_number":248,"context_line":"        glance_mock.images.list.return_value \u003d []"},{"line_number":249,"context_line":"        self.assertEqual({}, self.cloud.list_images())"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        class Image(object):"},{"line_number":252,"context_line":"            id \u003d \u002742\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab921fb_8e2284b8","line":249,"in_reply_to":"bab921fb_cebabc6e","updated":"2015-04-22 23:27:17.000000000","message":"Im inclined to agree that this isnt the best interface...","commit_id":"e351f5090251ae63b771f7949a0455c026448ac7"}]}