)]}'
{"requirements.txt":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"a62b0f99df0edcd35068b22bc1c1b74c67f8467a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"python-swiftclient"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"dogpile.cache\u003e\u003d0.5.3"},{"line_number":16,"context_line":"flamel"}],"source_content_type":"text/plain","patch_set":2,"id":"dac4157f_ae4cd842","line":16,"updated":"2015-04-21 17:03:27.000000000","message":"Technically you want flamel\u003e\u003d0.1 but I\u0027m pretty sure that\u0027s not super important. Also, we may want to move flamel onto the openstack infrastructure and start gating and stuff. Just sayin. :)","commit_id":"332cbc0249b11b4e7191d24cd7a641e94883eab7"}],"shade/__init__.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6e91fa1edf38ce2c7da5f2ef24b65d0bdd061c67","unresolved":false,"context_lines":[{"line_number":1522,"context_line":"            return server"},{"line_number":1523,"context_line":"        return self.get_openstack_vars(server)"},{"line_number":1524,"context_line":""},{"line_number":1525,"context_line":"    def get_server_meta(self, server):"},{"line_number":1526,"context_line":"        \"\"\" Get a tuple of server variables and groups."},{"line_number":1527,"context_line":""},{"line_number":1528,"context_line":"        DEPRECATED - DO NOT USE"}],"source_content_type":"text/x-python","patch_set":24,"id":"3acd31a7_4a962740","line":1525,"updated":"2015-05-04 21:06:57.000000000","message":"Is the assumption that new ansible will use shade.inventory? If so it may be worthwhile to indicate that that is what replaces this method.","commit_id":"fa870f702421825c902d2b4f56d6e48ce1bb8d62"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"79a354752da709c7ba3f30d60d84bebef5c935f0","unresolved":false,"context_lines":[{"line_number":1522,"context_line":"            return server"},{"line_number":1523,"context_line":"        return self.get_openstack_vars(server)"},{"line_number":1524,"context_line":""},{"line_number":1525,"context_line":"    def get_server_meta(self, server):"},{"line_number":1526,"context_line":"        \"\"\" Get a tuple of server variables and groups."},{"line_number":1527,"context_line":""},{"line_number":1528,"context_line":"        DEPRECATED - DO NOT USE"}],"source_content_type":"text/x-python","patch_set":24,"id":"3acd31a7_6a97a3ec","line":1525,"in_reply_to":"3acd31a7_4a962740","updated":"2015-05-04 23:38:40.000000000","message":"Yes, that is correct.","commit_id":"fa870f702421825c902d2b4f56d6e48ce1bb8d62"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"d4301ab7d83e357c3e47490b2d2dc34acab1e76a","unresolved":false,"context_lines":[{"line_number":1531,"context_line":"        so we need to keep it around until it\u0027s reasonable to expect people"},{"line_number":1532,"context_line":"        to have upgraded to 1.10."},{"line_number":1533,"context_line":""},{"line_number":1534,"context_line":"        Instead, please use the the functions in shade.inventory."},{"line_number":1535,"context_line":"        \"\"\""},{"line_number":1536,"context_line":"        server_vars \u003d meta.get_hostvars_from_server(self, server)"},{"line_number":1537,"context_line":"        groups \u003d meta.get_groups_from_server(self, server, server_vars)"}],"source_content_type":"text/x-python","patch_set":29,"id":"1aca2d91_6704e37d","line":1534,"updated":"2015-05-06 14:38:47.000000000","message":"Maybe we should log a warning or print something about this depreciation?","commit_id":"cee7ab8be1741d4cbeb337a2cc3bc5ee15ca92de"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"a8dfaca438d414eb75cc57f8ace7054007c89c75","unresolved":false,"context_lines":[{"line_number":1531,"context_line":"        so we need to keep it around until it\u0027s reasonable to expect people"},{"line_number":1532,"context_line":"        to have upgraded to 1.10."},{"line_number":1533,"context_line":""},{"line_number":1534,"context_line":"        Instead, please use the the functions in shade.inventory."},{"line_number":1535,"context_line":"        \"\"\""},{"line_number":1536,"context_line":"        server_vars \u003d meta.get_hostvars_from_server(self, server)"},{"line_number":1537,"context_line":"        groups \u003d meta.get_groups_from_server(self, server, server_vars)"}],"source_content_type":"text/x-python","patch_set":29,"id":"1aca2d91_92b044f6","line":1534,"in_reply_to":"1aca2d91_6704e37d","updated":"2015-05-07 01:04:16.000000000","message":"I\u0027d rather come back in another pass and figure out a signaling method for deprecation, and also how we want to allow it to be squelched.","commit_id":"cee7ab8be1741d4cbeb337a2cc3bc5ee15ca92de"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"ec86097ad29cb1d438089bc4cbb9ba62f1b3bf2a","unresolved":false,"context_lines":[{"line_number":919,"context_line":""},{"line_number":920,"context_line":"    def get_flavor(self, name_or_id, filters\u003dNone):"},{"line_number":921,"context_line":"        return self._get_entity(self.search_flavors, name_or_id, filters)"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"    def get_security_group(self, name_or_id, filters\u003dNone):"},{"line_number":924,"context_line":"        return self._get_entity(self.search_security_groups,"},{"line_number":925,"context_line":"                                name_or_id, filters)"}],"source_content_type":"text/x-python","patch_set":32,"id":"7a016987_0bcc61b9","line":922,"updated":"2015-05-22 20:08:09.000000000","message":"You are redefining this.","commit_id":"cb08350fe9aad4d477cf09ebcb08d5dfa516ddaf"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"ec86097ad29cb1d438089bc4cbb9ba62f1b3bf2a","unresolved":false,"context_lines":[{"line_number":1579,"context_line":"        groups \u003d meta.get_groups_from_server(self, server, server_vars)"},{"line_number":1580,"context_line":"        return dict(server_vars\u003dserver_vars, groups\u003dgroups)"},{"line_number":1581,"context_line":""},{"line_number":1582,"context_line":"    def get_security_group(self, name_or_id):"},{"line_number":1583,"context_line":"        for secgroup in self.manager.submitTask(_tasks.SecurityGroupList()):"},{"line_number":1584,"context_line":"            if name_or_id in (secgroup.name, secgroup.id):"},{"line_number":1585,"context_line":"                return secgroup"}],"source_content_type":"text/x-python","patch_set":32,"id":"7a016987_2bc95dac","line":1582,"updated":"2015-05-22 20:08:09.000000000","message":"This already exists on line 923","commit_id":"cb08350fe9aad4d477cf09ebcb08d5dfa516ddaf"}],"shade/cmd/inventory.py":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"a62b0f99df0edcd35068b22bc1c1b74c67f8467a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"try:"},{"line_number":22,"context_line":"    import json"},{"line_number":23,"context_line":"except:"},{"line_number":24,"context_line":"    import simplejson as json"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"import flamel"},{"line_number":27,"context_line":"import os_client_config"}],"source_content_type":"text/x-python","patch_set":2,"id":"dac4157f_ce44ac1c","line":24,"updated":"2015-04-21 17:03:27.000000000","message":"When does this matter? Just curious.","commit_id":"332cbc0249b11b4e7191d24cd7a641e94883eab7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6e91fa1edf38ce2c7da5f2ef24b65d0bdd061c67","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def output_format_dict(data, yaml):"},{"line_number":27,"context_line":"    if yaml:"},{"line_number":28,"context_line":"        return flamel.yaml_dump(data, default_flow_style\u003dFalse)"},{"line_number":29,"context_line":"    else:"},{"line_number":30,"context_line":"        return json.dumps(data, sort_keys\u003dTrue, indent\u003d2)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"3acd31a7_4ace272f","line":28,"updated":"2015-05-04 21:06:57.000000000","message":"Just noting that this is a lossy serialization for ordered dicts as they will be written out in yaml as normal dicts and loading them back can result in a different order.\n\nSo if order is important (I am told it shouldn\u0027t be here) then this may be a problem.","commit_id":"fa870f702421825c902d2b4f56d6e48ce1bb8d62"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"79a354752da709c7ba3f30d60d84bebef5c935f0","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def output_format_dict(data, yaml):"},{"line_number":27,"context_line":"    if yaml:"},{"line_number":28,"context_line":"        return flamel.yaml_dump(data, default_flow_style\u003dFalse)"},{"line_number":29,"context_line":"    else:"},{"line_number":30,"context_line":"        return json.dumps(data, sort_keys\u003dTrue, indent\u003d2)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"3acd31a7_ea8bb3c1","line":28,"in_reply_to":"3acd31a7_4ace272f","updated":"2015-05-04 23:38:40.000000000","message":"Nod. Dont\u0027 think it\u0027s a problem here.","commit_id":"fa870f702421825c902d2b4f56d6e48ce1bb8d62"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"0ba550908107818a4241f5e58bec5a98320c51c5","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def main():"},{"line_number":49,"context_line":"    args \u003d parse_args()"},{"line_number":50,"context_line":"    try:"},{"line_number":51,"context_line":"        inventory \u003d shade.inventory.OpenStackInventory("},{"line_number":52,"context_line":"            refresh\u003dargs.refresh, debug\u003dargs.debug)"}],"source_content_type":"text/x-python","patch_set":38,"id":"3afb71cf_bc1d55bf","line":49,"updated":"2015-06-05 15:33:54.000000000","message":"This would be a good place to set up logging.  Perhaps something like:\nlevel\u003dargs.debug and logging.DEBUG or logging.WARNING\nlogging.basicConfig(level\u003dlevel)","commit_id":"43ef999f4349e4f536ef4218a1f4c96b6a5e7510"}],"shade/inventory.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6e91fa1edf38ce2c7da5f2ef24b65d0bdd061c67","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"                if \u0027interface_ip\u0027 not in meta:"},{"line_number":54,"context_line":"                    # skip this host if it doesn\u0027t have a network address"},{"line_number":55,"context_line":"                    continue"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"                hostvars[server.name] \u003d meta"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"3acd31a7_4a0ce7ec","line":55,"updated":"2015-05-04 21:06:57.000000000","message":"This is an interesting behavior and I assume why we are using defaultdict(dict) above for the hostvars variable.","commit_id":"fa870f702421825c902d2b4f56d6e48ce1bb8d62"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6e91fa1edf38ce2c7da5f2ef24b65d0bdd061c67","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def get_host(self, hostname):"},{"line_number":62,"context_line":"        hosts \u003d self.get_hosts()"},{"line_number":63,"context_line":"        return hosts.get(hostname, None)"}],"source_content_type":"text/x-python","patch_set":24,"id":"3acd31a7_ca7b5727","line":63,"updated":"2015-05-04 21:06:57.000000000","message":"I don\u0027t think you will ever return None due to the defaultdict(dict) above.","commit_id":"fa870f702421825c902d2b4f56d6e48ce1bb8d62"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"79a354752da709c7ba3f30d60d84bebef5c935f0","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def get_host(self, hostname):"},{"line_number":62,"context_line":"        hosts \u003d self.get_hosts()"},{"line_number":63,"context_line":"        return hosts.get(hostname, None)"}],"source_content_type":"text/x-python","patch_set":24,"id":"3acd31a7_6abe8366","line":63,"in_reply_to":"3acd31a7_ca7b5727","updated":"2015-05-04 23:38:40.000000000","message":"Good point.","commit_id":"fa870f702421825c902d2b4f56d6e48ce1bb8d62"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"ddcf1f31addac03339bca8dde64ca20420469421","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"                if \u0027interface_ip\u0027 not in meta and not connected:"},{"line_number":53,"context_line":"                    # skip this host if it doesn\u0027t have a network address"},{"line_number":54,"context_line":"                    # and we don\u0027t only care about hosts with network"},{"line_number":55,"context_line":"                    continue"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"                hostvars[server.name] \u003d meta"}],"source_content_type":"text/x-python","patch_set":28,"id":"3acd31a7_4c986a78","line":54,"updated":"2015-05-05 14:51:56.000000000","message":"This seems backwards, but I admit I find the logic in the comment difficult to follow.  I would expect that connected\u003dTrue returns only connected hosts, and connected\u003dFalse returns all kinds.  I also don\u0027t quite understand why connected warrants a parameter here (why not hosts with volumes attached/not attached, etc?). Understanding the use might suggest why connected is more imporant here than not connected (or is it the other way around?) or even why it\u0027s boolean and not tri-state (which would give connected, not connected, all equal opportunity to be served by this method.\n\nThis could probably use a docstring and a test.","commit_id":"12b8c0eacdd0a8c2c2f9fa4ab279bf6e3d06748a"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"d4301ab7d83e357c3e47490b2d2dc34acab1e76a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                    # and we only care about hosts with network"},{"line_number":69,"context_line":"                    continue"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"                hostvars[server.name] \u003d meta"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        return hostvars"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"1aca2d91_47c1e7e3","line":71,"updated":"2015-05-06 14:38:47.000000000","message":"what if multiple clouds have servers with the same names.\n\nMaybe we should store these in a hostvars[cloud][server] arrangement?","commit_id":"cee7ab8be1741d4cbeb337a2cc3bc5ee15ca92de"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"a8dfaca438d414eb75cc57f8ace7054007c89c75","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                    # and we only care about hosts with network"},{"line_number":69,"context_line":"                    continue"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"                hostvars[server.name] \u003d meta"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        return hostvars"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"1aca2d91_92b964ec","line":71,"in_reply_to":"1aca2d91_47c1e7e3","updated":"2015-05-07 01:04:16.000000000","message":"Yes. Great catch. rework coming.","commit_id":"cee7ab8be1741d4cbeb337a2cc3bc5ee15ca92de"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"d4301ab7d83e357c3e47490b2d2dc34acab1e76a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        return hostvars"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def get_host(self, hostname):"},{"line_number":76,"context_line":"        hosts \u003d self.get_hosts()"},{"line_number":77,"context_line":"        return hosts.get(hostname, None)"}],"source_content_type":"text/x-python","patch_set":29,"id":"1aca2d91_a7aafb17","line":76,"updated":"2015-05-06 14:38:47.000000000","message":"Getting all the hosts here seems expensive. Any way we can cut this down?","commit_id":"cee7ab8be1741d4cbeb337a2cc3bc5ee15ca92de"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"a8dfaca438d414eb75cc57f8ace7054007c89c75","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        return hostvars"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def get_host(self, hostname):"},{"line_number":76,"context_line":"        hosts \u003d self.get_hosts()"},{"line_number":77,"context_line":"        return hosts.get(hostname, None)"}],"source_content_type":"text/x-python","patch_set":29,"id":"1aca2d91_b2b460f2","line":76,"in_reply_to":"1aca2d91_a7aafb17","updated":"2015-05-07 01:04:16.000000000","message":"Not really - because we don\u0027t know what cloud the host would be on.","commit_id":"cee7ab8be1741d4cbeb337a2cc3bc5ee15ca92de"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"d4301ab7d83e357c3e47490b2d2dc34acab1e76a","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def get_host(self, hostname):"},{"line_number":76,"context_line":"        hosts \u003d self.get_hosts()"},{"line_number":77,"context_line":"        return hosts.get(hostname, None)"}],"source_content_type":"text/x-python","patch_set":29,"id":"1aca2d91_0772cfe5","line":77,"updated":"2015-05-06 14:38:47.000000000","message":"again it\u0027s possible we might have multiple hosts with the same name so a way to handle that would be good","commit_id":"cee7ab8be1741d4cbeb337a2cc3bc5ee15ca92de"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"1e5ec2166ac0667edfa5ab990cdf7a5ff7911c80","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        return hostvars"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_host(self, hostname):"},{"line_number":78,"context_line":"        for host in self.get_hosts():"},{"line_number":79,"context_line":"            if host[\u0027name\u0027] \u003d\u003d hostname:"},{"line_number":80,"context_line":"                return hsot"}],"source_content_type":"text/x-python","patch_set":30,"id":"1aca2d91_8388f8e8","line":77,"updated":"2015-05-07 04:08:23.000000000","message":"This will return only the first match.. If multiple hosts match across multiple clouds should we return all instances?\n\nAlternatively should we require the cloud to get hostname from?","commit_id":"0b02440c196fd43e2d32c8a37d1eee52e476289c"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"1e5ec2166ac0667edfa5ab990cdf7a5ff7911c80","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    def get_host(self, hostname):"},{"line_number":78,"context_line":"        for host in self.get_hosts():"},{"line_number":79,"context_line":"            if host[\u0027name\u0027] \u003d\u003d hostname:"},{"line_number":80,"context_line":"                return hsot"},{"line_number":81,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":30,"id":"1aca2d91_831118af","line":80,"updated":"2015-05-07 04:08:23.000000000","message":"Typo here","commit_id":"0b02440c196fd43e2d32c8a37d1eee52e476289c"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"b1f60e21bc40d3b93ae24f2e901c6adb975c758e","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"                hostvars[server.id] \u003d meta"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        return hostvars"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def search_hosts(self, name_or_id\u003dNone, filters\u003dNone):"},{"line_number":59,"context_line":"        hosts \u003d self.list_hosts()"}],"source_content_type":"text/x-python","patch_set":36,"id":"5afe65bd_18d43e1e","line":56,"updated":"2015-06-03 13:06:38.000000000","message":"This isn\u0027t going to work with our get/list/search pattern. A list should be returned, not a dictionary. This is also why the functional test is failing.","commit_id":"144cf827facdcef0fe0d2baf2a852981e4f3a391"}],"shade/meta.py":[{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"0caa5c8e526cc6a114dc21599e614fc196df6c2f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                meta \u003d cloud.get_server_hostvars(server)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"                if \u0027interface_ip\u0027 not in meta:"},{"line_number":58,"context_line":"                    # skip this host if it doesn\u0027t have a network address"},{"line_number":59,"context_line":"                    continue"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"                hostvars[server.name] \u003d meta"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab921fb_5507141c","line":58,"updated":"2015-04-24 06:08:21.000000000","message":"should be worth to log that situation?","commit_id":"b45c8c2497ba6ea57ef95b2586af58697af50b34"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6e91fa1edf38ce2c7da5f2ef24b65d0bdd061c67","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    return get_server_ip(server, ext_tag\u003d\u0027floating\u0027, key_name\u003d\u0027public\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def get_groups_from_server(cloud, server, server_vars):"},{"line_number":55,"context_line":"    \"\"\" Get a list of groups associated with a server dict"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    DEPRECATED - DO NOT USE"}],"source_content_type":"text/x-python","patch_set":24,"id":"3acd31a7_aaab7b74","line":54,"updated":"2015-05-04 21:06:57.000000000","message":"Is the assumption that new ansible will use shade.inventory? If so it may be worthwhile to indicate that that is what replaces this method.","commit_id":"fa870f702421825c902d2b4f56d6e48ce1bb8d62"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"79a354752da709c7ba3f30d60d84bebef5c935f0","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    return get_server_ip(server, ext_tag\u003d\u0027floating\u0027, key_name\u003d\u0027public\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def get_groups_from_server(cloud, server, server_vars):"},{"line_number":55,"context_line":"    \"\"\" Get a list of groups associated with a server dict"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    DEPRECATED - DO NOT USE"}],"source_content_type":"text/x-python","patch_set":24,"id":"3acd31a7_caafd728","line":54,"in_reply_to":"3acd31a7_aaab7b74","updated":"2015-05-04 23:38:40.000000000","message":"Yes.","commit_id":"fa870f702421825c902d2b4f56d6e48ce1bb8d62"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"d4301ab7d83e357c3e47490b2d2dc34acab1e76a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    so we need to keep it around until it\u0027s reasonable to expect people"},{"line_number":61,"context_line":"    to have upgraded to 1.10."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    Instead, please use the the functions in shade.inventory."},{"line_number":64,"context_line":"    \"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    groups \u003d []"}],"source_content_type":"text/x-python","patch_set":29,"id":"1aca2d91_a7067b1e","line":63,"updated":"2015-05-06 14:38:47.000000000","message":"again we should probably raise a message of sorts","commit_id":"cee7ab8be1741d4cbeb337a2cc3bc5ee15ca92de"}],"shade/tests/functional/test_inventory.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6e91fa1edf38ce2c7da5f2ef24b65d0bdd061c67","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.assertEquals(host[\u0027name\u0027], self.server_name)"},{"line_number":67,"context_line":"        self._test_host_content(host)"},{"line_number":68,"context_line":"        host \u003d self.inventory.get_hosts().get(self.server_name, None)"},{"line_number":69,"context_line":"        self.assertIsNotNone(host)"},{"line_number":70,"context_line":"        self._test_host_content(host)"}],"source_content_type":"text/x-python","patch_set":24,"id":"3acd31a7_2a33eb63","line":69,"updated":"2015-05-04 21:06:57.000000000","message":"This assert will always be true, see comments in inventory file.","commit_id":"fa870f702421825c902d2b4f56d6e48ce1bb8d62"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"79a354752da709c7ba3f30d60d84bebef5c935f0","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.assertEquals(host[\u0027name\u0027], self.server_name)"},{"line_number":67,"context_line":"        self._test_host_content(host)"},{"line_number":68,"context_line":"        host \u003d self.inventory.get_hosts().get(self.server_name, None)"},{"line_number":69,"context_line":"        self.assertIsNotNone(host)"},{"line_number":70,"context_line":"        self._test_host_content(host)"}],"source_content_type":"text/x-python","patch_set":24,"id":"3acd31a7_aaa81b21","line":69,"in_reply_to":"3acd31a7_2a33eb63","updated":"2015-05-04 23:38:40.000000000","message":"Nod.","commit_id":"fa870f702421825c902d2b4f56d6e48ce1bb8d62"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"7a88e16b726b91c471ea958cb471e13e7b7d4dbf","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        # Shell should have OS-* envvars from openrc, typically loaded by job"},{"line_number":33,"context_line":"        self.cloud \u003d openstack_cloud()"},{"line_number":34,"context_line":"        self.inventory \u003d inventory.OpenStackInventory()"},{"line_number":35,"context_line":"        self.server_name \u003d \u0027test_inventory_server\u0027"},{"line_number":36,"context_line":"        self.nova \u003d self.cloud.nova_client"},{"line_number":37,"context_line":"        self.flavor \u003d pick_flavor(self.nova.flavors.list())"},{"line_number":38,"context_line":"        if self.flavor is None:"}],"source_content_type":"text/x-python","patch_set":41,"id":"3afb71cf_c3adc989","line":35,"updated":"2015-06-05 18:53:52.000000000","message":"Using static names for resources in functional tests can get messy and makes idempotency hard. I\u0027d suggest a random component be added to any resource created by a test run so that each iteration has its own resources and doesn\u0027t interfere with anything else going on inside the cloud we\u0027re pointed at.","commit_id":"92b4cc30d7388917a27931b35f53a2655688b3ef"}]}
