)]}'
{"shade/__init__.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"f3021bf73fddbae041f2bf301299be473c45fbda","unresolved":false,"context_lines":[{"line_number":2846,"context_line":"                exc_info\u003dTrue)"},{"line_number":2847,"context_line":"            raise OpenStackCloudException(str(e))"},{"line_number":2848,"context_line":""},{"line_number":2849,"context_line":"    def create_endpoint(self, service_name_or_id, public_url,"},{"line_number":2850,"context_line":"                        internal_url\u003dNone, admin_url\u003dNone, region\u003dNone):"},{"line_number":2851,"context_line":"        \"\"\"Create a Keystone endpoint."},{"line_number":2852,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a016987_b14e45bf","line":2849,"updated":"2015-05-28 15:19:52.000000000","message":"Monty and I chatted briefly in IRC and feel like, instead of service_name_or_id, which is a bit awkward, we instead require passing in a service dict so that the caller must do the get_service() call themselves before creating the endpoint.","commit_id":"d8a98a298a3e19b4127370e8f757d7446486864c"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"454f77d0472cea63ef8150595faacf7b2dbae365","unresolved":false,"context_lines":[{"line_number":2846,"context_line":"                exc_info\u003dTrue)"},{"line_number":2847,"context_line":"            raise OpenStackCloudException(str(e))"},{"line_number":2848,"context_line":""},{"line_number":2849,"context_line":"    def create_endpoint(self, service_name_or_id, public_url,"},{"line_number":2850,"context_line":"                        internal_url\u003dNone, admin_url\u003dNone, region\u003dNone):"},{"line_number":2851,"context_line":"        \"\"\"Create a Keystone endpoint."},{"line_number":2852,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a016987_6931ddec","line":2849,"in_reply_to":"7a016987_39091b85","updated":"2015-05-29 12:42:03.000000000","message":"\"All\" is misleading. There is only a single example from the neutron methods, and that is create_subnet().","commit_id":"d8a98a298a3e19b4127370e8f757d7446486864c"},{"author":{"_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},"change_message_id":"4b00110f0e1db6a5672e7e0ec39db1809a6f35b6","unresolved":false,"context_lines":[{"line_number":2846,"context_line":"                exc_info\u003dTrue)"},{"line_number":2847,"context_line":"            raise OpenStackCloudException(str(e))"},{"line_number":2848,"context_line":""},{"line_number":2849,"context_line":"    def create_endpoint(self, service_name_or_id, public_url,"},{"line_number":2850,"context_line":"                        internal_url\u003dNone, admin_url\u003dNone, region\u003dNone):"},{"line_number":2851,"context_line":"        \"\"\"Create a Keystone endpoint."},{"line_number":2852,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a016987_4914e1e7","line":2849,"in_reply_to":"7a016987_6931ddec","updated":"2015-05-29 12:47:27.000000000","message":"That\u0027s correct. As you pointed out on IRC, update methods aren\u0027t a god example.\nLet\u0027s disregard the second part of my comment. :)\n\nAbout the first part, many methods take and *_id for dependent objects.","commit_id":"d8a98a298a3e19b4127370e8f757d7446486864c"},{"author":{"_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},"change_message_id":"c0f82dab9be68e57ddc46457d2e1d2516b339cee","unresolved":false,"context_lines":[{"line_number":2846,"context_line":"                exc_info\u003dTrue)"},{"line_number":2847,"context_line":"            raise OpenStackCloudException(str(e))"},{"line_number":2848,"context_line":""},{"line_number":2849,"context_line":"    def create_endpoint(self, service_name_or_id, public_url,"},{"line_number":2850,"context_line":"                        internal_url\u003dNone, admin_url\u003dNone, region\u003dNone):"},{"line_number":2851,"context_line":"        \"\"\"Create a Keystone endpoint."},{"line_number":2852,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a016987_39091b85","line":2849,"in_reply_to":"7a016987_b14e45bf","updated":"2015-05-28 16:24:17.000000000","message":"I agree not to use name_or_id and so to avoid a call to keystone API.\nNevertheless, I\u0027d rather not pass the whole dict here as just the service_id is needed.\n\nActually it turned out that all neutron methods in shade that accept dependent objects (e.g. update_subnet, create_subnet, update_router, ...) take a *_name_or_id ...","commit_id":"d8a98a298a3e19b4127370e8f757d7446486864c"}]}