)]}'
{"shade/__init__.py":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"ebad93f531629cd3f299734c1d8d064cb7d56f7f","unresolved":false,"context_lines":[{"line_number":1665,"context_line":"        return server"},{"line_number":1666,"context_line":""},{"line_number":1667,"context_line":"    def create_server(self, auto_ip\u003dTrue, ips\u003dNone, ip_pool\u003dNone,"},{"line_number":1668,"context_line":"                      root_volume\u003dNone, terminate_volume\u003dFalse,"},{"line_number":1669,"context_line":"                      wait\u003dFalse, timeout\u003d180, **bootkwargs):"},{"line_number":1670,"context_line":""},{"line_number":1671,"context_line":"        if root_volume:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a0c5dc1_b3547654","line":1668,"updated":"2015-05-12 13:08:06.000000000","message":"If ever there was a time to add a docstring, this would be it. Just like tests help us not backslide, I think that will help users not go insane when we change the return types. :)","commit_id":"d8b8068034b1b59bf286388e96bedb050535e1f8"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"23b9e58655723c5b3d153a525007885292313659","unresolved":false,"context_lines":[{"line_number":1665,"context_line":"        return server"},{"line_number":1666,"context_line":""},{"line_number":1667,"context_line":"    def create_server(self, auto_ip\u003dTrue, ips\u003dNone, ip_pool\u003dNone,"},{"line_number":1668,"context_line":"                      root_volume\u003dNone, terminate_volume\u003dFalse,"},{"line_number":1669,"context_line":"                      wait\u003dFalse, timeout\u003d180, **bootkwargs):"},{"line_number":1670,"context_line":""},{"line_number":1671,"context_line":"        if root_volume:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a0c5dc1_ce5bc12d","line":1668,"in_reply_to":"9a0c5dc1_b3547654","updated":"2015-05-12 13:15:08.000000000","message":"Sure. What would you suggest for documenting the return type? The idea behind using bunch was to make it as transparent as possible for the user, but I don\u0027t think we want to say we return a Bunch object now where we used to return a Nova object. We could say \"special dict that also supports attribute access\"...","commit_id":"d8b8068034b1b59bf286388e96bedb050535e1f8"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"dbca2c767589067f4e1e7d86b8b47e2bae7c5c80","unresolved":false,"context_lines":[{"line_number":1722,"context_line":"                    raise OpenStackCloudException("},{"line_number":1723,"context_line":"                        \"Error in creating the server\","},{"line_number":1724,"context_line":"                        extra_data\u003ddict(server\u003dserver))"},{"line_number":1725,"context_line":"        return meta.obj_to_dict(server)"},{"line_number":1726,"context_line":""},{"line_number":1727,"context_line":"    def rebuild_server(self, server_id, image_id, wait\u003dFalse, timeout\u003d180):"},{"line_number":1728,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a0c5dc1_11d2e7d2","line":1725,"updated":"2015-05-13 14:05:10.000000000","message":"This may be calling obj_to_dict on a bunch if wait is true.","commit_id":"e71bee318c95b05fdf4d5e0102f7da60bde3adb5"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"dbca2c767589067f4e1e7d86b8b47e2bae7c5c80","unresolved":false,"context_lines":[{"line_number":1752,"context_line":"                    raise OpenStackCloudException("},{"line_number":1753,"context_line":"                        \"Error in rebuilding the server\","},{"line_number":1754,"context_line":"                        extra_data\u003ddict(server\u003dserver))"},{"line_number":1755,"context_line":"        return meta.obj_to_dict(server)"},{"line_number":1756,"context_line":""},{"line_number":1757,"context_line":"    def delete_server(self, name, wait\u003dFalse, timeout\u003d180):"},{"line_number":1758,"context_line":"        server \u003d self.get_server(name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a0c5dc1_71e1239a","line":1755,"updated":"2015-05-13 14:05:10.000000000","message":"same here","commit_id":"e71bee318c95b05fdf4d5e0102f7da60bde3adb5"}],"shade/tests/functional/test_compute.py":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"ebad93f531629cd3f299734c1d8d064cb7d56f7f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def test_create_server(self):"},{"line_number":46,"context_line":"        self.addCleanup(self._cleanup_servers)"},{"line_number":47,"context_line":"        server \u003d self.cloud.create_server(name\u003d\u0027test_create_server\u0027,"},{"line_number":48,"context_line":"                                          image\u003dself.image, flavor\u003dself.flavor)"},{"line_number":49,"context_line":"        self.assertEquals(server.name, \u0027test_create_server\u0027)"},{"line_number":50,"context_line":"        self.assertEquals(server.image[\u0027id\u0027], self.image.id)"},{"line_number":51,"context_line":"        self.assertEquals(server.flavor[\u0027id\u0027], self.flavor.id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a0c5dc1_93d852f1","line":48,"updated":"2015-05-12 13:08:06.000000000","message":"Should we replace this with tests for dict behaviors?","commit_id":"d8b8068034b1b59bf286388e96bedb050535e1f8"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"23b9e58655723c5b3d153a525007885292313659","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def test_create_server(self):"},{"line_number":46,"context_line":"        self.addCleanup(self._cleanup_servers)"},{"line_number":47,"context_line":"        server \u003d self.cloud.create_server(name\u003d\u0027test_create_server\u0027,"},{"line_number":48,"context_line":"                                          image\u003dself.image, flavor\u003dself.flavor)"},{"line_number":49,"context_line":"        self.assertEquals(server.name, \u0027test_create_server\u0027)"},{"line_number":50,"context_line":"        self.assertEquals(server.image[\u0027id\u0027], self.image.id)"},{"line_number":51,"context_line":"        self.assertEquals(server.flavor[\u0027id\u0027], self.flavor.id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a0c5dc1_ae964d92","line":48,"in_reply_to":"9a0c5dc1_93d852f1","updated":"2015-05-12 13:15:08.000000000","message":"If our plan is to continue support of both dict and object attribute behaviors, I don\u0027t see the need.","commit_id":"d8b8068034b1b59bf286388e96bedb050535e1f8"}]}