)]}'
{"shade/__init__.py":[{"author":{"_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},"change_message_id":"97280116c1618435f9622f0c6fa864018f1b9c20","unresolved":false,"context_lines":[{"line_number":2170,"context_line":"        return new_subnet[\u0027subnet\u0027]"},{"line_number":2171,"context_line":""},{"line_number":2172,"context_line":"    def list_domains(self):"},{"line_number":2173,"context_line":"        return self.manager.submitTask(_tasks.DomainList())"},{"line_number":2174,"context_line":""},{"line_number":2175,"context_line":"    def get_domain(self, domain_id):"},{"line_number":2176,"context_line":"        return self.manager.submitTask(_tasks.DomainGet(domain_id\u003ddomain_id))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_55c6fa9a","line":2173,"updated":"2015-05-16 23:43:56.000000000","message":"this needs exception handling (catch Exception, log and raise OpenStackCloudException)","commit_id":"809ecf39623b5d60e2a6b9b9bd1b4cee91056bd4"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"1c5ac7faf010d4dc277819167616d2133ef9924f","unresolved":false,"context_lines":[{"line_number":2170,"context_line":"        return new_subnet[\u0027subnet\u0027]"},{"line_number":2171,"context_line":""},{"line_number":2172,"context_line":"    def list_domains(self):"},{"line_number":2173,"context_line":"        return self.manager.submitTask(_tasks.DomainList())"},{"line_number":2174,"context_line":""},{"line_number":2175,"context_line":"    def get_domain(self, domain_id):"},{"line_number":2176,"context_line":"        return self.manager.submitTask(_tasks.DomainGet(domain_id\u003ddomain_id))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_ec8aa2be","line":2173,"in_reply_to":"7a016987_55c6fa9a","updated":"2015-05-20 17:57:17.000000000","message":"Done","commit_id":"809ecf39623b5d60e2a6b9b9bd1b4cee91056bd4"},{"author":{"_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},"change_message_id":"97280116c1618435f9622f0c6fa864018f1b9c20","unresolved":false,"context_lines":[{"line_number":2173,"context_line":"        return self.manager.submitTask(_tasks.DomainList())"},{"line_number":2174,"context_line":""},{"line_number":2175,"context_line":"    def get_domain(self, domain_id):"},{"line_number":2176,"context_line":"        return self.manager.submitTask(_tasks.DomainGet(domain_id\u003ddomain_id))"},{"line_number":2177,"context_line":""},{"line_number":2178,"context_line":"    def list_records(self, domain_id):"},{"line_number":2179,"context_line":"        return self.manager.submitTask(_tasks.RecordList(domain\u003ddomain_id))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_f5ba8609","line":2176,"updated":"2015-05-16 23:43:56.000000000","message":"idem","commit_id":"809ecf39623b5d60e2a6b9b9bd1b4cee91056bd4"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"1c5ac7faf010d4dc277819167616d2133ef9924f","unresolved":false,"context_lines":[{"line_number":2173,"context_line":"        return self.manager.submitTask(_tasks.DomainList())"},{"line_number":2174,"context_line":""},{"line_number":2175,"context_line":"    def get_domain(self, domain_id):"},{"line_number":2176,"context_line":"        return self.manager.submitTask(_tasks.DomainGet(domain_id\u003ddomain_id))"},{"line_number":2177,"context_line":""},{"line_number":2178,"context_line":"    def list_records(self, domain_id):"},{"line_number":2179,"context_line":"        return self.manager.submitTask(_tasks.RecordList(domain\u003ddomain_id))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_cc85a6ad","line":2176,"in_reply_to":"7a016987_f5ba8609","updated":"2015-05-20 17:57:17.000000000","message":"Done","commit_id":"809ecf39623b5d60e2a6b9b9bd1b4cee91056bd4"},{"author":{"_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},"change_message_id":"97280116c1618435f9622f0c6fa864018f1b9c20","unresolved":false,"context_lines":[{"line_number":2176,"context_line":"        return self.manager.submitTask(_tasks.DomainGet(domain_id\u003ddomain_id))"},{"line_number":2177,"context_line":""},{"line_number":2178,"context_line":"    def list_records(self, domain_id):"},{"line_number":2179,"context_line":"        return self.manager.submitTask(_tasks.RecordList(domain\u003ddomain_id))"},{"line_number":2180,"context_line":""},{"line_number":2181,"context_line":"    def get_record(self, domain_id, record_id):"},{"line_number":2182,"context_line":"        return self.manager.submitTask(_tasks.RecordGet(domain\u003ddomain_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_b53bee9b","line":2179,"updated":"2015-05-16 23:43:56.000000000","message":"ditto","commit_id":"809ecf39623b5d60e2a6b9b9bd1b4cee91056bd4"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"1c5ac7faf010d4dc277819167616d2133ef9924f","unresolved":false,"context_lines":[{"line_number":2176,"context_line":"        return self.manager.submitTask(_tasks.DomainGet(domain_id\u003ddomain_id))"},{"line_number":2177,"context_line":""},{"line_number":2178,"context_line":"    def list_records(self, domain_id):"},{"line_number":2179,"context_line":"        return self.manager.submitTask(_tasks.RecordList(domain\u003ddomain_id))"},{"line_number":2180,"context_line":""},{"line_number":2181,"context_line":"    def get_record(self, domain_id, record_id):"},{"line_number":2182,"context_line":"        return self.manager.submitTask(_tasks.RecordGet(domain\u003ddomain_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_8c8faecb","line":2179,"in_reply_to":"7a016987_b53bee9b","updated":"2015-05-20 17:57:17.000000000","message":"Done","commit_id":"809ecf39623b5d60e2a6b9b9bd1b4cee91056bd4"},{"author":{"_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},"change_message_id":"97280116c1618435f9622f0c6fa864018f1b9c20","unresolved":false,"context_lines":[{"line_number":2179,"context_line":"        return self.manager.submitTask(_tasks.RecordList(domain\u003ddomain_id))"},{"line_number":2180,"context_line":""},{"line_number":2181,"context_line":"    def get_record(self, domain_id, record_id):"},{"line_number":2182,"context_line":"        return self.manager.submitTask(_tasks.RecordGet(domain\u003ddomain_id,"},{"line_number":2183,"context_line":"                                                        record_id\u003drecord_id))"},{"line_number":2184,"context_line":""},{"line_number":2185,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_75457615","line":2182,"updated":"2015-05-16 23:43:56.000000000","message":"same","commit_id":"809ecf39623b5d60e2a6b9b9bd1b4cee91056bd4"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"1c5ac7faf010d4dc277819167616d2133ef9924f","unresolved":false,"context_lines":[{"line_number":2179,"context_line":"        return self.manager.submitTask(_tasks.RecordList(domain\u003ddomain_id))"},{"line_number":2180,"context_line":""},{"line_number":2181,"context_line":"    def get_record(self, domain_id, record_id):"},{"line_number":2182,"context_line":"        return self.manager.submitTask(_tasks.RecordGet(domain\u003ddomain_id,"},{"line_number":2183,"context_line":"                                                        record_id\u003drecord_id))"},{"line_number":2184,"context_line":""},{"line_number":2185,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_6cbd9267","line":2182,"in_reply_to":"7a016987_75457615","updated":"2015-05-20 17:57:17.000000000","message":"Done","commit_id":"809ecf39623b5d60e2a6b9b9bd1b4cee91056bd4"},{"author":{"_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},"change_message_id":"d1791587b3ce6d6cbda7ec0c2e7ad2dd5f28d850","unresolved":false,"context_lines":[{"line_number":615,"context_line":"    def designate_client(self):"},{"line_number":616,"context_line":"        if self._designate_client is None:"},{"line_number":617,"context_line":"            # trigger exception on lack of designate"},{"line_number":618,"context_line":"            self.get_session_endpoint(\u0027hpext:dns\u0027)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"            token \u003d self.auth_token"},{"line_number":621,"context_line":"            auth_url \u003d self.get_session_endpoint(\u0027identity\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_069a24b9","line":618,"updated":"2015-05-22 11:51:45.000000000","message":"See below (hpext:dns)","commit_id":"bb75e9e61a6fa23f10829ba2d7ad992b89c9ac92"},{"author":{"_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},"change_message_id":"d1791587b3ce6d6cbda7ec0c2e7ad2dd5f28d850","unresolved":false,"context_lines":[{"line_number":618,"context_line":"            self.get_session_endpoint(\u0027hpext:dns\u0027)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"            token \u003d self.auth_token"},{"line_number":621,"context_line":"            auth_url \u003d self.get_session_endpoint(\u0027identity\u0027)"},{"line_number":622,"context_line":"            tenant_id \u003d self.keystone_session.get_project_id()"},{"line_number":623,"context_line":"            region_name \u003d self.region_name"},{"line_number":624,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_f5c8d456","line":621,"updated":"2015-05-22 11:51:45.000000000","message":"I see why you are passing auth_url and not the keystone session.\nI think this is a designate bug, so I filed a ticket and proposed a patch: https://review.openstack.org/#/c/184988/\nIf we are willing to wait for that to be reviewed (it could be the wrong approach), we can fix also this code! :)","commit_id":"bb75e9e61a6fa23f10829ba2d7ad992b89c9ac92"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"0553748d7a9c364a13519284ab37e9692a21d7a5","unresolved":false,"context_lines":[{"line_number":618,"context_line":"            self.get_session_endpoint(\u0027hpext:dns\u0027)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"            token \u003d self.auth_token"},{"line_number":621,"context_line":"            auth_url \u003d self.get_session_endpoint(\u0027identity\u0027)"},{"line_number":622,"context_line":"            tenant_id \u003d self.keystone_session.get_project_id()"},{"line_number":623,"context_line":"            region_name \u003d self.region_name"},{"line_number":624,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_9beabfab","line":621,"in_reply_to":"7a016987_f5c8d456","updated":"2015-05-25 21:13:02.000000000","message":"yep, will follow up with kiall and ghayes, thx for pushing fix on designate!","commit_id":"bb75e9e61a6fa23f10829ba2d7ad992b89c9ac92"},{"author":{"_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},"change_message_id":"d1791587b3ce6d6cbda7ec0c2e7ad2dd5f28d850","unresolved":false,"context_lines":[{"line_number":627,"context_line":"                token\u003dtoken,"},{"line_number":628,"context_line":"                tenant_id\u003dtenant_id,"},{"line_number":629,"context_line":"                region_name\u003dregion_name,"},{"line_number":630,"context_line":"                service_type\u003dself.get_service_type(\u0027hpext:dns\u0027)"},{"line_number":631,"context_line":"            )"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"            if self._designate_client is None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_809efcb6","line":630,"updated":"2015-05-22 11:51:45.000000000","message":"I see HP uses a non-standard service type for designate, but designate client uses \"dns\" by default and that means that dns will be used by many cloud providers.\n\nSo, it would be better to make this configurable thru the cloud-specific configuration and use the OS_DNS_SERVICE_TYPE environment variable.\n\nSorry, I haven\u0027t notice this in my earlier review!","commit_id":"bb75e9e61a6fa23f10829ba2d7ad992b89c9ac92"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"0553748d7a9c364a13519284ab37e9692a21d7a5","unresolved":false,"context_lines":[{"line_number":627,"context_line":"                token\u003dtoken,"},{"line_number":628,"context_line":"                tenant_id\u003dtenant_id,"},{"line_number":629,"context_line":"                region_name\u003dregion_name,"},{"line_number":630,"context_line":"                service_type\u003dself.get_service_type(\u0027hpext:dns\u0027)"},{"line_number":631,"context_line":"            )"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"            if self._designate_client is None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_1ba92f7c","line":630,"in_reply_to":"7a016987_809efcb6","updated":"2015-05-25 21:13:02.000000000","message":"Done","commit_id":"bb75e9e61a6fa23f10829ba2d7ad992b89c9ac92"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"bf1ddbf80d754db6d878ca70ed5a1ea4458fd688","unresolved":false,"context_lines":[{"line_number":2182,"context_line":""},{"line_number":2183,"context_line":"    def list_records(self, domain_id):"},{"line_number":2184,"context_line":"        try:"},{"line_number":2185,"context_line":"            return self.manager.submitTask(_tasks.RecordList(domain\u003ddomain_id))"},{"line_number":2186,"context_line":"        except Exception as e:"},{"line_number":2187,"context_line":"            self.log.debug(\"record list failed: %s\" % e, exc_info\u003dTrue)"},{"line_number":2188,"context_line":"            raise OpenStackCloudException("}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_1d7b8ec2","line":2185,"updated":"2015-05-22 17:42:30.000000000","message":"Just verifying, but does the client return a list of objects (like many of the other clients) or a list of dictionaries? If they are objects, you\u0027ll need to convert them to dictionaries (obj_list_to_dict()).","commit_id":"bb75e9e61a6fa23f10829ba2d7ad992b89c9ac92"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"0553748d7a9c364a13519284ab37e9692a21d7a5","unresolved":false,"context_lines":[{"line_number":2182,"context_line":""},{"line_number":2183,"context_line":"    def list_records(self, domain_id):"},{"line_number":2184,"context_line":"        try:"},{"line_number":2185,"context_line":"            return self.manager.submitTask(_tasks.RecordList(domain\u003ddomain_id))"},{"line_number":2186,"context_line":"        except Exception as e:"},{"line_number":2187,"context_line":"            self.log.debug(\"record list failed: %s\" % e, exc_info\u003dTrue)"},{"line_number":2188,"context_line":"            raise OpenStackCloudException("}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_fbdbf31f","line":2185,"in_reply_to":"7a016987_1d7b8ec2","updated":"2015-05-25 21:13:02.000000000","message":"both record and domain objects base from dict, thus they behave like it and it\u0027s not needed to convert them","commit_id":"bb75e9e61a6fa23f10829ba2d7ad992b89c9ac92"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"bf1ddbf80d754db6d878ca70ed5a1ea4458fd688","unresolved":false,"context_lines":[{"line_number":2200,"context_line":"    def search_records(self, domain_id, name_or_id\u003dNone, filters\u003dNone):"},{"line_number":2201,"context_line":"        records \u003d self.list_records(domain_id\u003ddomain_id)"},{"line_number":2202,"context_line":"        return self._filter_list(records, name_or_id, filters)"},{"line_number":2203,"context_line":""},{"line_number":2204,"context_line":""},{"line_number":2205,"context_line":"class OperatorCloud(OpenStackCloud):"},{"line_number":2206,"context_line":"    \"\"\"Represent a privileged/operator connection to an OpenStack Cloud."}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_5d346648","line":2203,"updated":"2015-05-22 17:42:30.000000000","message":"I\u0027d like to see these new get/list/search methods grouped together with the existing get/list/search methods instead of tagged on to the end of the class.","commit_id":"bb75e9e61a6fa23f10829ba2d7ad992b89c9ac92"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"0553748d7a9c364a13519284ab37e9692a21d7a5","unresolved":false,"context_lines":[{"line_number":2200,"context_line":"    def search_records(self, domain_id, name_or_id\u003dNone, filters\u003dNone):"},{"line_number":2201,"context_line":"        records \u003d self.list_records(domain_id\u003ddomain_id)"},{"line_number":2202,"context_line":"        return self._filter_list(records, name_or_id, filters)"},{"line_number":2203,"context_line":""},{"line_number":2204,"context_line":""},{"line_number":2205,"context_line":"class OperatorCloud(OpenStackCloud):"},{"line_number":2206,"context_line":"    \"\"\"Represent a privileged/operator connection to an OpenStack Cloud."}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_9bb3dfe9","line":2203,"in_reply_to":"7a016987_5d346648","updated":"2015-05-25 21:13:02.000000000","message":"Done","commit_id":"bb75e9e61a6fa23f10829ba2d7ad992b89c9ac92"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"18d54f7fdfd6d79359f76d67caa62b8f04674fbb","unresolved":false,"context_lines":[{"line_number":695,"context_line":"    def designate_client(self):"},{"line_number":696,"context_line":"        if self._designate_client is None:"},{"line_number":697,"context_line":"            # get dns service type if defined in cloud config"},{"line_number":698,"context_line":"            dns_service_type \u003d self.service_types.get(\u0027dns\u0027, \u0027dns\u0027)"},{"line_number":699,"context_line":"            # trigger exception on lack of designate"},{"line_number":700,"context_line":"            self.get_session_endpoint(dns_service_type)"},{"line_number":701,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_875fd60d","line":698,"updated":"2015-06-29 13:37:53.000000000","message":"Since last you were here, we added self.get_service_type(\u0027dns\u0027) for this.","commit_id":"003c10ef7dc9291ecf2b538fc8b80782ab633fbe"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"18d54f7fdfd6d79359f76d67caa62b8f04674fbb","unresolved":false,"context_lines":[{"line_number":702,"context_line":"            self._designate_client \u003d designate_client("},{"line_number":703,"context_line":"                session\u003dself.keystone_session,"},{"line_number":704,"context_line":"                region_name\u003dself.region_name,"},{"line_number":705,"context_line":"                service_type\u003dself.get_service_type(dns_service_type)"},{"line_number":706,"context_line":"            )"},{"line_number":707,"context_line":""},{"line_number":708,"context_line":"            if self._designate_client is None:"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_a7af7ae2","line":705,"updated":"2015-06-29 13:37:53.000000000","message":"Ah - bu then you use it here ... maybe just use the dns_service_type var from above.\nAlso - do you know if designateclient supports api_timeout?","commit_id":"003c10ef7dc9291ecf2b538fc8b80782ab633fbe"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"18d54f7fdfd6d79359f76d67caa62b8f04674fbb","unresolved":false,"context_lines":[{"line_number":712,"context_line":""},{"line_number":713,"context_line":"        return self._designate_client"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"    def _get_trove_api_version(self, endpoint):"},{"line_number":716,"context_line":"        if \u0027database\u0027 in self.api_versions:"},{"line_number":717,"context_line":"            return self.api_versions[\u0027database\u0027]"},{"line_number":718,"context_line":"        # Yay. We get to guess ..."}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_87e4b63b","line":715,"updated":"2015-06-29 13:37:53.000000000","message":"This method looks like copy-pasta.","commit_id":"003c10ef7dc9291ecf2b538fc8b80782ab633fbe"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"c9583735bf3df06010de56ed81b4e0f1c481dfcb","unresolved":false,"context_lines":[{"line_number":895,"context_line":"        domains \u003d self.list_domains()"},{"line_number":896,"context_line":"        return _utils._filter_list(domains, name_or_id, filters)"},{"line_number":897,"context_line":""},{"line_number":898,"context_line":"    def search_records(self, domain_id, name_or_id\u003dNone, filters\u003dNone):"},{"line_number":899,"context_line":"        records \u003d self.list_records(domain_id\u003ddomain_id)"},{"line_number":900,"context_line":"        return _utils._filter_list(records, name_or_id, filters)"},{"line_number":901,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_92762f3d","line":898,"updated":"2015-06-29 14:57:46.000000000","message":"It is consistent with the rest of the code to accept either a domain ID or name (you could rename the parameter \u0027domain\u0027 to support both, and add a docstring to explain).\n\nNon-unique names should raise an exception.","commit_id":"52192376e4a816cd508c868e6db271f4fd235e2c"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"fa044f25ef79de4a52a483f0b9f4600a670ba777","unresolved":false,"context_lines":[{"line_number":895,"context_line":"        domains \u003d self.list_domains()"},{"line_number":896,"context_line":"        return _utils._filter_list(domains, name_or_id, filters)"},{"line_number":897,"context_line":""},{"line_number":898,"context_line":"    def search_records(self, domain_id, name_or_id\u003dNone, filters\u003dNone):"},{"line_number":899,"context_line":"        records \u003d self.list_records(domain_id\u003ddomain_id)"},{"line_number":900,"context_line":"        return _utils._filter_list(records, name_or_id, filters)"},{"line_number":901,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_c3f14ccf","line":898,"in_reply_to":"3a50d1a3_554ad984","updated":"2015-07-20 12:31:40.000000000","message":"I must have been thinking I was looking at \u0027search_domains\u0027 when I made my initial comment because I now have no idea what I was talking about then. This method, as you have it, looks fine.","commit_id":"52192376e4a816cd508c868e6db271f4fd235e2c"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"a2a069704a6a61ecb0ac67d427b09adff7079a04","unresolved":false,"context_lines":[{"line_number":895,"context_line":"        domains \u003d self.list_domains()"},{"line_number":896,"context_line":"        return _utils._filter_list(domains, name_or_id, filters)"},{"line_number":897,"context_line":""},{"line_number":898,"context_line":"    def search_records(self, domain_id, name_or_id\u003dNone, filters\u003dNone):"},{"line_number":899,"context_line":"        records \u003d self.list_records(domain_id\u003ddomain_id)"},{"line_number":900,"context_line":"        return _utils._filter_list(records, name_or_id, filters)"},{"line_number":901,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_554ad984","line":898,"in_reply_to":"ba3cc151_92762f3d","updated":"2015-07-20 09:18:30.000000000","message":"But that doesn\u0027t follow what I read from the code.\n\nI see a bunch of search_* methods that accept name_or_id parameter, so that\u0027s why I put that my search_domains/search_records.\n\nAre you saying that those other methods will be refactored and name_or_id will be removed for \u003cresource\u003e?\n\ne.g: ded search_servers(self, server, filters\u003dNone)","commit_id":"52192376e4a816cd508c868e6db271f4fd235e2c"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"dff9867611f787c41ccce9d1038dd70a36920bdf","unresolved":false,"context_lines":[{"line_number":1093,"context_line":""},{"line_number":1094,"context_line":"    def list_domains(self):"},{"line_number":1095,"context_line":"        try:"},{"line_number":1096,"context_line":"            return self.manager.submitTask(_tasks.DomainList())"},{"line_number":1097,"context_line":"        except Exception as e:"},{"line_number":1098,"context_line":"            self.log.debug(\"domain list failed: %s\" % e, exc_info\u003dTrue)"},{"line_number":1099,"context_line":"            raise OpenStackCloudException("}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_92814f92","line":1096,"updated":"2015-06-29 15:05:23.000000000","message":"Are objects returned here, or are they dicts? We don\u0027t like to leak objects from the underlying clients, so you may need to call meta.obj_to_dict() on what is being returned here.\n\nLooking at the unit tests, it looks like dicts are expected, but just confirming.","commit_id":"52192376e4a816cd508c868e6db271f4fd235e2c"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"fa044f25ef79de4a52a483f0b9f4600a670ba777","unresolved":false,"context_lines":[{"line_number":1093,"context_line":""},{"line_number":1094,"context_line":"    def list_domains(self):"},{"line_number":1095,"context_line":"        try:"},{"line_number":1096,"context_line":"            return self.manager.submitTask(_tasks.DomainList())"},{"line_number":1097,"context_line":"        except Exception as e:"},{"line_number":1098,"context_line":"            self.log.debug(\"domain list failed: %s\" % e, exc_info\u003dTrue)"},{"line_number":1099,"context_line":"            raise OpenStackCloudException("}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_037df41b","line":1096,"in_reply_to":"3a50d1a3_55189984","updated":"2015-07-20 12:31:40.000000000","message":"Ok. We have a comment in our documentation that everything our API returns should be considered a dict:\n\nhttps://github.com/openstack-infra/shade/blob/master/doc/source/usage.rst\n\nAs long as it acts as a dict, and users don\u0027t depend on the object interface, that should be fine.","commit_id":"52192376e4a816cd508c868e6db271f4fd235e2c"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"a2a069704a6a61ecb0ac67d427b09adff7079a04","unresolved":false,"context_lines":[{"line_number":1093,"context_line":""},{"line_number":1094,"context_line":"    def list_domains(self):"},{"line_number":1095,"context_line":"        try:"},{"line_number":1096,"context_line":"            return self.manager.submitTask(_tasks.DomainList())"},{"line_number":1097,"context_line":"        except Exception as e:"},{"line_number":1098,"context_line":"            self.log.debug(\"domain list failed: %s\" % e, exc_info\u003dTrue)"},{"line_number":1099,"context_line":"            raise OpenStackCloudException("}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_55189984","line":1096,"in_reply_to":"ba3cc151_92814f92","updated":"2015-07-20 09:18:30.000000000","message":"Designate object implement the dict interface, they are like dicts.","commit_id":"52192376e4a816cd508c868e6db271f4fd235e2c"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"c9583735bf3df06010de56ed81b4e0f1c481dfcb","unresolved":false,"context_lines":[{"line_number":1099,"context_line":"            raise OpenStackCloudException("},{"line_number":1100,"context_line":"                \"Error fetching domain list: %s\" % e)"},{"line_number":1101,"context_line":""},{"line_number":1102,"context_line":"    def list_records(self, domain_id):"},{"line_number":1103,"context_line":"        try:"},{"line_number":1104,"context_line":"            return self.manager.submitTask(_tasks.RecordList(domain\u003ddomain_id))"},{"line_number":1105,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_52dd0713","line":1102,"updated":"2015-06-29 14:57:46.000000000","message":"Same comment as from search_records(). You could actually encapsulate all of that logic here.","commit_id":"52192376e4a816cd508c868e6db271f4fd235e2c"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"fa044f25ef79de4a52a483f0b9f4600a670ba777","unresolved":false,"context_lines":[{"line_number":1099,"context_line":"            raise OpenStackCloudException("},{"line_number":1100,"context_line":"                \"Error fetching domain list: %s\" % e)"},{"line_number":1101,"context_line":""},{"line_number":1102,"context_line":"    def list_records(self, domain_id):"},{"line_number":1103,"context_line":"        try:"},{"line_number":1104,"context_line":"            return self.manager.submitTask(_tasks.RecordList(domain\u003ddomain_id))"},{"line_number":1105,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_c3762c3e","line":1102,"in_reply_to":"3a50d1a3_b52c7dac","updated":"2015-07-20 12:31:40.000000000","message":"Ignore my comment. This method is fine.","commit_id":"52192376e4a816cd508c868e6db271f4fd235e2c"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"a2a069704a6a61ecb0ac67d427b09adff7079a04","unresolved":false,"context_lines":[{"line_number":1099,"context_line":"            raise OpenStackCloudException("},{"line_number":1100,"context_line":"                \"Error fetching domain list: %s\" % e)"},{"line_number":1101,"context_line":""},{"line_number":1102,"context_line":"    def list_records(self, domain_id):"},{"line_number":1103,"context_line":"        try:"},{"line_number":1104,"context_line":"            return self.manager.submitTask(_tasks.RecordList(domain\u003ddomain_id))"},{"line_number":1105,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_b52c7dac","line":1102,"in_reply_to":"ba3cc151_52dd0713","updated":"2015-07-20 09:18:30.000000000","message":"I added this \u0027duplication\u0027 of search/list as most other objects have this distinction.\n\nAre you suggesting I should get rid of search and put all logic on list methods?","commit_id":"52192376e4a816cd508c868e6db271f4fd235e2c"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"dff9867611f787c41ccce9d1038dd70a36920bdf","unresolved":false,"context_lines":[{"line_number":1101,"context_line":""},{"line_number":1102,"context_line":"    def list_records(self, domain_id):"},{"line_number":1103,"context_line":"        try:"},{"line_number":1104,"context_line":"            return self.manager.submitTask(_tasks.RecordList(domain\u003ddomain_id))"},{"line_number":1105,"context_line":"        except Exception as e:"},{"line_number":1106,"context_line":"            self.log.debug(\"record list failed: %s\" % e, exc_info\u003dTrue)"},{"line_number":1107,"context_line":"            raise OpenStackCloudException("}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_d25ef744","line":1104,"updated":"2015-06-29 15:05:23.000000000","message":"Ditto about the objects vs. dicts thing.","commit_id":"52192376e4a816cd508c868e6db271f4fd235e2c"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"c9583735bf3df06010de56ed81b4e0f1c481dfcb","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"    def get_domain(self, name_or_id, filters\u003dNone):"},{"line_number":1145,"context_line":"        return _utils._get_entity(self.search_domains, name_or_id, filters)"},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"    def get_record(self, domain_id, name_or_id, filters\u003dNone):"},{"line_number":1148,"context_line":"        f \u003d lambda name_or_id, filters: self.search_records("},{"line_number":1149,"context_line":"            domain_id, name_or_id, filters)"},{"line_number":1150,"context_line":"        return _utils._get_entity(f, name_or_id, filters)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_92db8f1b","line":1147,"updated":"2015-06-29 14:57:46.000000000","message":"Ditto.","commit_id":"52192376e4a816cd508c868e6db271f4fd235e2c"}]}
