)]}'
{"shade/__init__.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"f182f19d95e2a9ab1a65faee6c4f861537d1c110","unresolved":false,"context_lines":[{"line_number":1704,"context_line":""},{"line_number":1705,"context_line":"        Return the first available floating IP or allocate a new one."},{"line_number":1706,"context_line":""},{"line_number":1707,"context_line":"        :param network_or_pool: network name or id or pool name."},{"line_number":1708,"context_line":""},{"line_number":1709,"context_line":"        :returns: a (normalized) structure with a floating IP address"},{"line_number":1710,"context_line":"                  description."}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_8c054b12","line":1707,"updated":"2015-06-23 14:14:10.000000000","message":"Same comment here on the parameter name as below.","commit_id":"6996f7669d30113f39779f858674d2394ec178f2"},{"author":{"_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},"change_message_id":"ef1b19913b3716bc2437e46701ef7050909d5133","unresolved":false,"context_lines":[{"line_number":1704,"context_line":""},{"line_number":1705,"context_line":"        Return the first available floating IP or allocate a new one."},{"line_number":1706,"context_line":""},{"line_number":1707,"context_line":"        :param network_or_pool: network name or id or pool name."},{"line_number":1708,"context_line":""},{"line_number":1709,"context_line":"        :returns: a (normalized) structure with a floating IP address"},{"line_number":1710,"context_line":"                  description."}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_3aebeadd","line":1707,"in_reply_to":"fa32b979_8c054b12","updated":"2015-06-24 13:10:36.000000000","message":"Done","commit_id":"6996f7669d30113f39779f858674d2394ec178f2"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"f182f19d95e2a9ab1a65faee6c4f861537d1c110","unresolved":false,"context_lines":[{"line_number":1813,"context_line":"    def create_floating_ip(self, network_or_pool\u003dNone):"},{"line_number":1814,"context_line":"        \"\"\"Allocate a new floating IP from a network or a pool."},{"line_number":1815,"context_line":""},{"line_number":1816,"context_line":"        :param network_or_pool: network name or id or pool name."},{"line_number":1817,"context_line":""},{"line_number":1818,"context_line":"        :returns: a floating IP address"},{"line_number":1819,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_e18ae0be","line":1816,"updated":"2015-06-23 14:14:10.000000000","message":"We had decided in https://review.openstack.org/#/c/183496/22/shade/_utils.py that we would not do the _or_ construct in the data that we returned and just go with \u0027network\u0027, but we need to document that this can be a \u0027pool\u0027 when Nova is in play. So I think we should change this parameter name here, too, for consistency, and expand on the docstrings here.","commit_id":"6996f7669d30113f39779f858674d2394ec178f2"},{"author":{"_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},"change_message_id":"ef1b19913b3716bc2437e46701ef7050909d5133","unresolved":false,"context_lines":[{"line_number":1813,"context_line":"    def create_floating_ip(self, network_or_pool\u003dNone):"},{"line_number":1814,"context_line":"        \"\"\"Allocate a new floating IP from a network or a pool."},{"line_number":1815,"context_line":""},{"line_number":1816,"context_line":"        :param network_or_pool: network name or id or pool name."},{"line_number":1817,"context_line":""},{"line_number":1818,"context_line":"        :returns: a floating IP address"},{"line_number":1819,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_9ab0f6fe","line":1816,"in_reply_to":"fa32b979_e18ae0be","updated":"2015-06-24 13:10:36.000000000","message":"Done","commit_id":"6996f7669d30113f39779f858674d2394ec178f2"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"f182f19d95e2a9ab1a65faee6c4f861537d1c110","unresolved":false,"context_lines":[{"line_number":1846,"context_line":"                filters\u003d{\u0027router:external\u0027: True})"},{"line_number":1847,"context_line":"            if not networks:"},{"line_number":1848,"context_line":"                raise OpenStackCloudResourceNotFound("},{"line_number":1849,"context_line":"                    \"unable to find an external network\")"},{"line_number":1850,"context_line":"            kwargs \u003d {"},{"line_number":1851,"context_line":"                \u0027floating_network_id\u0027: networks[0][\u0027id\u0027],"},{"line_number":1852,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_21b3e89b","line":1849,"updated":"2015-06-23 14:14:10.000000000","message":"We should identify the network we were searching for in this exception string.","commit_id":"6996f7669d30113f39779f858674d2394ec178f2"},{"author":{"_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},"change_message_id":"ef1b19913b3716bc2437e46701ef7050909d5133","unresolved":false,"context_lines":[{"line_number":1846,"context_line":"                filters\u003d{\u0027router:external\u0027: True})"},{"line_number":1847,"context_line":"            if not networks:"},{"line_number":1848,"context_line":"                raise OpenStackCloudResourceNotFound("},{"line_number":1849,"context_line":"                    \"unable to find an external network\")"},{"line_number":1850,"context_line":"            kwargs \u003d {"},{"line_number":1851,"context_line":"                \u0027floating_network_id\u0027: networks[0][\u0027id\u0027],"},{"line_number":1852,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_7acf3256","line":1849,"in_reply_to":"fa32b979_21b3e89b","updated":"2015-06-24 13:10:36.000000000","message":"Done","commit_id":"6996f7669d30113f39779f858674d2394ec178f2"}]}