)]}'
{"shade/__init__.py":[{"author":{"_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},"change_message_id":"aeef4ba3f4cf9e3a04b4ea40a92e91a2116f1614","unresolved":false,"context_lines":[{"line_number":36,"context_line":"import swiftclient.client as swift_client"},{"line_number":37,"context_line":"import swiftclient.service as swift_service"},{"line_number":38,"context_line":"import swiftclient.exceptions as swift_exceptions"},{"line_number":39,"context_line":"import swiftclient.multithreading as swift_multithreading"},{"line_number":40,"context_line":"import troveclient.client as trove_client"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# Disable the Rackspace warnings about deprecated certificates. We are aware"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_c10c7c96","line":39,"updated":"2015-06-03 09:17:08.000000000","message":"It seems you are not using swift_multithreading","commit_id":"4f0043f6e1ad3fa1507f7c112fb9b09ab9e80114"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"3e1af50ee86ac58f0c42d05cb96c205d1540d05a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"import swiftclient.client as swift_client"},{"line_number":37,"context_line":"import swiftclient.service as swift_service"},{"line_number":38,"context_line":"import swiftclient.exceptions as swift_exceptions"},{"line_number":39,"context_line":"import swiftclient.multithreading as swift_multithreading"},{"line_number":40,"context_line":"import troveclient.client as trove_client"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# Disable the Rackspace warnings about deprecated certificates. We are aware"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_53360253","line":39,"in_reply_to":"5afe65bd_c10c7c96","updated":"2015-06-03 22:29:16.000000000","message":"Done","commit_id":"4f0043f6e1ad3fa1507f7c112fb9b09ab9e80114"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"dd3922daa5fa230e36a87e2e122ad6d4d1779928","unresolved":false,"context_lines":[{"line_number":36,"context_line":"import swiftclient.client as swift_client"},{"line_number":37,"context_line":"import swiftclient.service as swift_service"},{"line_number":38,"context_line":"import swiftclient.exceptions as swift_exceptions"},{"line_number":39,"context_line":"import swiftclient.multithreading as swift_multithreading"},{"line_number":40,"context_line":"import troveclient.client as trove_client"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# Disable the Rackspace warnings about deprecated certificates. We are aware"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_da30d0ea","line":39,"in_reply_to":"5afe65bd_c10c7c96","updated":"2015-06-03 16:46:33.000000000","message":"Why isnt pep8 failing here?","commit_id":"4f0043f6e1ad3fa1507f7c112fb9b09ab9e80114"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"b0d75a789073e728680d568df20e69fa70ea5b4c","unresolved":false,"context_lines":[{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    @property"},{"line_number":603,"context_line":"    def swift_service(self):"},{"line_number":604,"context_line":"        if self._swift_service is None:"},{"line_number":605,"context_line":"            endpoint \u003d self.get_session_endpoint(service_key\u003d\u0027object-store\u0027)"},{"line_number":606,"context_line":"            options \u003d dict(os_auth_token\u003dself.auth_token,"},{"line_number":607,"context_line":"                           os_storage_url\u003dendpoint,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_7eb0118c","line":604,"updated":"2015-06-04 22:13:34.000000000","message":"Done","commit_id":"049c6508bf3e609fe9484e1b5517e2cabe7e0bce"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"a517ed43390a26b762f11f92d45f6bebf2d39736","unresolved":false,"context_lines":[{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    @property"},{"line_number":603,"context_line":"    def swift_service(self):"},{"line_number":604,"context_line":"        if self._swift_service is None:"},{"line_number":605,"context_line":"            endpoint \u003d self.get_session_endpoint(service_key\u003d\u0027object-store\u0027)"},{"line_number":606,"context_line":"            options \u003d dict(os_auth_token\u003dself.auth_token,"},{"line_number":607,"context_line":"                           os_storage_url\u003dendpoint,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5afe65bd_0fe04928","line":604,"updated":"2015-06-04 10:03:49.000000000","message":"can this be enclosed into some try...catch block, as other services? what will happen if the service cannot be created?","commit_id":"049c6508bf3e609fe9484e1b5517e2cabe7e0bce"}],"shade/tests/unit/test_object.py":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"dd3922daa5fa230e36a87e2e122ad6d4d1779928","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        auth_mock.return_value \u003d \u0027zulu\u0027"},{"line_number":47,"context_line":"        self.assertIsInstance(self.cloud.swift_service,"},{"line_number":48,"context_line":"                              swift_service.SwiftService)"},{"line_number":49,"context_line":"        endpoint_mock.assert_called_with(service_key\u003d\u0027object-store\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_7a21dc9e","line":49,"updated":"2015-06-03 16:46:33.000000000","message":"Its sad we dont have a way to assert that our auth vars are properly set in swift_service, like we do with swift_client...","commit_id":"4f0043f6e1ad3fa1507f7c112fb9b09ab9e80114"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"3e1af50ee86ac58f0c42d05cb96c205d1540d05a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        auth_mock.return_value \u003d \u0027zulu\u0027"},{"line_number":47,"context_line":"        self.assertIsInstance(self.cloud.swift_service,"},{"line_number":48,"context_line":"                              swift_service.SwiftService)"},{"line_number":49,"context_line":"        endpoint_mock.assert_called_with(service_key\u003d\u0027object-store\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_73169ea8","line":49,"in_reply_to":"5afe65bd_7a21dc9e","updated":"2015-06-03 22:29:16.000000000","message":"I couldn\u0027t find a way to do that and not dig DEEP into the internals of SwiftService with mocks. It is just a very opaque object. This is unfortunately just a \"don\u0027t explode\" test. But the functional tests in the next patch in the series will test exactly what you want, so I feel better about not asserting much here.","commit_id":"4f0043f6e1ad3fa1507f7c112fb9b09ab9e80114"}]}