)]}'
{"shade/tests/functional/test_compute.py":[{"author":{"_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},"change_message_id":"7251714388669ecc255359661825ca373ad6c47a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.assertEqual("},{"line_number":71,"context_line":"            self.image.name, self.cloud.get_image_name(self.image.name))"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_auto_ip(self):"},{"line_number":74,"context_line":"        if self.cloud.floating_ip_source is None:"},{"line_number":75,"context_line":"            self.skip("},{"line_number":76,"context_line":"                \u0027Cloud does not have floating ips\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_01d17457","line":73,"updated":"2015-06-03 09:06:54.000000000","message":"I added a bunch of tests to the end of keystone-* change-sets. This includes testing auto IPs: https://review.openstack.org/#/c/177036/28/shade/tests/functional/test_floating_ip.py\n\nShall we use these or those?","commit_id":"925fed775338f3481a72609ed760b84e7fb125f0"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"9028e64b702f038b232b3a86730a52319b4140f9","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.assertEqual("},{"line_number":71,"context_line":"            self.image.name, self.cloud.get_image_name(self.image.name))"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_auto_ip(self):"},{"line_number":74,"context_line":"        if self.cloud.floating_ip_source is None:"},{"line_number":75,"context_line":"            self.skip("},{"line_number":76,"context_line":"                \u0027Cloud does not have floating ips\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_bd23dca6","line":73,"in_reply_to":"5afe65bd_01d17457","updated":"2015-06-03 12:41:55.000000000","message":"I think if you add a call to meta.get_hostvars_from_server() to your tests, and asserts to test for a dict, in 177036 (which is a better place for this, IMO), then this review could be abandoned.","commit_id":"925fed775338f3481a72609ed760b84e7fb125f0"}]}
