)]}'
{"shade/__init__.py":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"d1dd91e647532b5f5cdf26479008d0f0dbada0a2","unresolved":false,"context_lines":[{"line_number":3500,"context_line":"                exc_info\u003dTrue)"},{"line_number":3501,"context_line":"            raise OpenStackCloudException(str(e))"},{"line_number":3502,"context_line":""},{"line_number":3503,"context_line":"    def create_endpoint(self, service_name_or_id, public_url, interface\u003dNone,"},{"line_number":3504,"context_line":"                        internal_url\u003dNone, admin_url\u003dNone, region\u003dNone,"},{"line_number":3505,"context_line":"                        enabled\u003dNone):"},{"line_number":3506,"context_line":"        \"\"\"Create a Keystone endpoint."}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_4e0a1e28","line":3503,"updated":"2015-08-18 11:03:54.000000000","message":"missing url\u003dNone","commit_id":"a1a0926f592f61459f58a2d7c5e00ec466efaefb"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"d1dd91e647532b5f5cdf26479008d0f0dbada0a2","unresolved":false,"context_lines":[{"line_number":3507,"context_line":""},{"line_number":3508,"context_line":"        As an admin function, it is assumed that the user will know whether"},{"line_number":3509,"context_line":"        they are using keystone v2 or v3 and will either give all three urls"},{"line_number":3510,"context_line":"        for keystone v2 or a url and interface for keystone v3."},{"line_number":3511,"context_line":""},{"line_number":3512,"context_line":"        :param service_name_or_id: Service name or id for this endpoint."},{"line_number":3513,"context_line":"        :param interface: Can be public, internal or private."}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_2e0d6a3e","line":3510,"updated":"2015-08-18 11:03:54.000000000","message":"For compatibility, cannot the interface be determined based on the parameters?\n\nIf I am specifying public_url, its clear the interface\u003dpublic and the url\u003dkeyvalue\n\nThis would also allow both v2 and v3 endpoints to be created the same exact way.\n\nThe major difference I suppose would be the case where you specify three urls and get returned three different endpoint ids which is an understandable blocker to doing it.","commit_id":"a1a0926f592f61459f58a2d7c5e00ec466efaefb"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"b9210841f78f85a4d6ddd6d64e04e69419cc0fe7","unresolved":false,"context_lines":[{"line_number":3527,"context_line":"        if service is None:"},{"line_number":3528,"context_line":"            raise OpenStackCloudException(\"service {service} not found\".format("},{"line_number":3529,"context_line":"                service\u003dservice_name_or_id))"},{"line_number":3530,"context_line":"        if self.api_versions[\u0027identity\u0027] \u003d\u003d \u00273\u0027:"},{"line_number":3531,"context_line":"            if not interface or not url:"},{"line_number":3532,"context_line":"                raise OpenStackCloudException("},{"line_number":3533,"context_line":"                    \"interface and url parameters are required for \""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_447afd25","line":3530,"updated":"2015-08-18 11:46:11.000000000","message":"This will make creating v2 endpoints in a cloud with v3 enabled impossible. This is bad for a number of reasons. The two biggest ones are v3 created endpoints are not visible to v2 clients and we can\u0027t test creation of v2 endpoints in a v3 enabled cloud.\n\nIf the first if block were to check if interface or url is set and have an elif for the second to check for public_url, that would allow the parameters to dictate what type of api the endpoint would get created under.\n\nA final else could be used to raise an exception","commit_id":"a1a0926f592f61459f58a2d7c5e00ec466efaefb"}]}
