)]}'
{"shade/meta.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"8f111a2293dcb6d9b9bb2f92c5c668a077543348","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        if key_name is not None and k !\u003d key_name:"},{"line_number":36,"context_line":"            # key_name is specified and it doesn\u0027t match the current network."},{"line_number":37,"context_line":"            # Continue with the next one"},{"line_number":38,"context_line":"            continue"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        for interface_spec in v:"},{"line_number":41,"context_line":"            if ext_tag is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_d4f9f54e","line":38,"updated":"2015-06-15 12:02:02.000000000","message":"You\u0027ve removed the section of code that extends the return list with values from \u0027addresses\u0027. I don\u0027t think that is intentional? If it is, an explanation of why that is done is warranted, I think. Otherwise, looks like a major loss of functionality.","commit_id":"669af9aa6083a7de717dde47251e506c99e06295"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"a926c3d7f5c64402722d0ec6a33cd23c2a2e346f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        if key_name is not None and k !\u003d key_name:"},{"line_number":36,"context_line":"            # key_name is specified and it doesn\u0027t match the current network."},{"line_number":37,"context_line":"            # Continue with the next one"},{"line_number":38,"context_line":"            continue"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        for interface_spec in v:"},{"line_number":41,"context_line":"            if ext_tag is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_ef4b022a","line":38,"in_reply_to":"fa32b979_d4f9f54e","updated":"2015-06-15 12:15:25.000000000","message":"Ok, nevermind. After seeing the next review in the series, I see that this *is* intentional, and the commit message makes more sense now.","commit_id":"669af9aa6083a7de717dde47251e506c99e06295"},{"author":{"_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},"change_message_id":"7d8137207972bbef1d9ee3a84ef281fa3eb51f27","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        if key_name is not None and k !\u003d key_name:"},{"line_number":36,"context_line":"            # key_name is specified and it doesn\u0027t match the current network."},{"line_number":37,"context_line":"            # Continue with the next one"},{"line_number":38,"context_line":"            continue"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        for interface_spec in v:"},{"line_number":41,"context_line":"            if ext_tag is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_8f6356b1","line":38,"in_reply_to":"fa32b979_d4f9f54e","updated":"2015-06-15 12:14:20.000000000","message":"The intention here is to \"improve\" that part by checking also the ext_tag.\nThe idea is to filter out things proceeding only if each condition is met.","commit_id":"669af9aa6083a7de717dde47251e506c99e06295"}]}