)]}'
{"shade/meta.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"957ca865833a9436c21652561a5b6a76ba164fdd","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"def get_server_external_ipv4(cloud, server):"},{"line_number":74,"context_line":"    if server.accessIPv4:"},{"line_number":75,"context_line":"        return server.accessIPv4"},{"line_number":76,"context_line":"    if cloud.has_service(\u0027network\u0027):"},{"line_number":77,"context_line":"        try:"},{"line_number":78,"context_line":"            # Search a fixed IP attached to an external net. Unfortunately"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_7fb57d2f","line":75,"updated":"2015-06-19 15:48:40.000000000","message":"We should be using the dict form, not object.","commit_id":"ba0c8b8f72875feafea28715b8220e220a20f884"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"957ca865833a9436c21652561a5b6a76ba164fdd","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    :return: a string containing the IPv6 address or None"},{"line_number":132,"context_line":"    \"\"\""},{"line_number":133,"context_line":"    if server.accessIPv6:"},{"line_number":134,"context_line":"        return server.accessIPv6"},{"line_number":135,"context_line":"    addresses \u003d find_nova_addresses(addresses\u003dserver.addresses, version\u003d6)"},{"line_number":136,"context_line":"    if addresses:"},{"line_number":137,"context_line":"        return addresses[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_df7a8977","line":134,"updated":"2015-06-19 15:48:40.000000000","message":"Again, dict form, please.","commit_id":"ba0c8b8f72875feafea28715b8220e220a20f884"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"4a00981655c9019712cd387d2a3fd10ab5b220fb","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    \"\"\""},{"line_number":133,"context_line":"    if server.accessIPv6:"},{"line_number":134,"context_line":"        return server.accessIPv6"},{"line_number":135,"context_line":"    addresses \u003d find_nova_addresses(addresses\u003dserver.addresses, version\u003d6)"},{"line_number":136,"context_line":"    if addresses:"},{"line_number":137,"context_line":"        return addresses[0]"},{"line_number":138,"context_line":"    return None"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_bfd785be","line":135,"updated":"2015-06-19 15:54:50.000000000","message":"And while you\u0027re add it, can you please fix the server.addresses, too? I know you didn\u0027t introduce it, but it needs changed.","commit_id":"ba0c8b8f72875feafea28715b8220e220a20f884"},{"author":{"_account_id":11610,"name":"Timothy R. Chavez","email":"timrchavez@us.ibm.com","username":"timrchavez"},"change_message_id":"cab51c4cfd1c5a194b6d2eeb40b20727d2ab15a6","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"def get_server_external_ipv4(cloud, server):"},{"line_number":74,"context_line":"    if server[\u0027accessIPv4\u0027]:"},{"line_number":75,"context_line":"        return server[\u0027accessIPv4\u0027]"},{"line_number":76,"context_line":"    if cloud.has_service(\u0027network\u0027):"},{"line_number":77,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_27511c63","line":74,"updated":"2015-06-19 21:49:10.000000000","message":"I\u0027m not familiar with this.  Will there always be a key called \u0027accessIPv4\u0027 and if it\u0027s available, it\u0027ll be something other then None?","commit_id":"c61cce6497aeef751122368b5568b1ae0d1b8708"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"07aa554152c2abce188d2a2021a5179db514c89e","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"def get_server_external_ipv4(cloud, server):"},{"line_number":74,"context_line":"    if server[\u0027accessIPv4\u0027]:"},{"line_number":75,"context_line":"        return server[\u0027accessIPv4\u0027]"},{"line_number":76,"context_line":"    if cloud.has_service(\u0027network\u0027):"},{"line_number":77,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_dbda88e9","line":74,"in_reply_to":"fa32b979_27511c63","updated":"2015-06-20 12:00:17.000000000","message":"Yes - it\u0027s a part of the nova server structure since folsom. However, only Rackspace actually sets it. It will either be \u0027\u0027 or the ip that should be used.","commit_id":"c61cce6497aeef751122368b5568b1ae0d1b8708"},{"author":{"_account_id":11610,"name":"Timothy R. Chavez","email":"timrchavez@us.ibm.com","username":"timrchavez"},"change_message_id":"cab51c4cfd1c5a194b6d2eeb40b20727d2ab15a6","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    :return: a string containing the IPv6 address or None"},{"line_number":132,"context_line":"    \"\"\""},{"line_number":133,"context_line":"    if server[\u0027accessIPv6\u0027]:"},{"line_number":134,"context_line":"        return server[\u0027accessIPv6\u0027]"},{"line_number":135,"context_line":"    addresses \u003d find_nova_addresses(addresses\u003dserver[\u0027addresses\u0027], version\u003d6)"},{"line_number":136,"context_line":"    if addresses:"},{"line_number":137,"context_line":"        return addresses[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_27d83cef","line":134,"updated":"2015-06-19 21:49:10.000000000","message":"Your commit message only mentions accessIPv6 -- maybe it should be amended to also mention accessIPv6?","commit_id":"c61cce6497aeef751122368b5568b1ae0d1b8708"}],"shade/tests/unit/test_meta.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"957ca865833a9436c21652561a5b6a76ba164fdd","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            id\u003d\u0027test-id\u0027, name\u003d\u0027test-name\u0027, status\u003d\u0027ACTIVE\u0027,"},{"line_number":138,"context_line":"            accessIPv4\u003dPUBLIC_V4)"},{"line_number":139,"context_line":"        ip \u003d meta.get_server_external_ipv4("},{"line_number":140,"context_line":"            cloud\u003dshade.openstack_cloud(), server\u003dsrv)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        self.assertEqual(PUBLIC_V4, ip)"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_bfc0e57d","line":140,"updated":"2015-06-19 15:48:40.000000000","message":"Pretty sure that get_server_external_ipv4() expects (at least, it absolutely should expect) a server as returned from obj_to_dict().","commit_id":"ba0c8b8f72875feafea28715b8220e220a20f884"}]}