)]}'
{"shade/__init__.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"498bedcad9ee520e87a28bc40c36036ab4eb0ed8","unresolved":false,"context_lines":[{"line_number":2347,"context_line":"                            self.log.debug("},{"line_number":2348,"context_line":"                                \"Failed deleting server {server} that booted\""},{"line_number":2349,"context_line":"                                \" without an IP address. Manual cleanup is\""},{"line_number":2350,"context_line":"                                \" required.\".format(server\u003dserver.id),"},{"line_number":2351,"context_line":"                                exc_info\u003dTrue)"},{"line_number":2352,"context_line":"                            raise OpenStackCloudException("},{"line_number":2353,"context_line":"                                \"Server reached ACTIVE state without being\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_77b1d4e0","line":2350,"updated":"2015-08-05 00:43:51.000000000","message":"server[\u0027id\u0027], please. Shouldn\u0027t assume an object from obj_to_dict(). We need to get out of this habit and remove attribute references in current code.","commit_id":"cc8ec261b68a9b1e2ecca0b670235bbbad399563"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"498bedcad9ee520e87a28bc40c36036ab4eb0ed8","unresolved":false,"context_lines":[{"line_number":2401,"context_line":"        server \u003d self.get_server(name_or_id)"},{"line_number":2402,"context_line":"        return self._delete_server(server, wait\u003dwait, timeout\u003dtimeout)"},{"line_number":2403,"context_line":""},{"line_number":2404,"context_line":"    def _delete_server(self, server, wait\u003dFalse, timeout\u003d180):"},{"line_number":2405,"context_line":"        if server:"},{"line_number":2406,"context_line":"            try:"},{"line_number":2407,"context_line":"                self.manager.submitTask(_tasks.ServerDelete(server\u003dserver.id))"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_17e2d09f","line":2404,"updated":"2015-08-05 00:43:51.000000000","message":"Love this optimization.","commit_id":"cc8ec261b68a9b1e2ecca0b670235bbbad399563"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"498bedcad9ee520e87a28bc40c36036ab4eb0ed8","unresolved":false,"context_lines":[{"line_number":2404,"context_line":"    def _delete_server(self, server, wait\u003dFalse, timeout\u003d180):"},{"line_number":2405,"context_line":"        if server:"},{"line_number":2406,"context_line":"            try:"},{"line_number":2407,"context_line":"                self.manager.submitTask(_tasks.ServerDelete(server\u003dserver.id))"},{"line_number":2408,"context_line":"            except nova_exceptions.NotFound:"},{"line_number":2409,"context_line":"                return"},{"line_number":2410,"context_line":"            except Exception as e:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_37dd8ce0","line":2407,"updated":"2015-08-05 00:43:51.000000000","message":"I know you didn\u0027t add this bit of code, but can you go ahead and change this to server[\u0027id\u0027] as well?","commit_id":"cc8ec261b68a9b1e2ecca0b670235bbbad399563"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"3bf3e44bab65fa051f67f5c192dc09ef9bbaf0c0","unresolved":false,"context_lines":[{"line_number":2354,"context_line":"                                \" allocated an IP address AND then could not\""},{"line_number":2355,"context_line":"                                \" be deleted: {0}\".format(e),"},{"line_number":2356,"context_line":"                                extra_data\u003ddict(server\u003dserver))"},{"line_number":2357,"context_line":"                        raise OpenStackCloudException("},{"line_number":2358,"context_line":"                            \u0027Server reached ACTIVE state without being\u0027"},{"line_number":2359,"context_line":"                            \u0027 allocated an IP address.\u0027,"},{"line_number":2360,"context_line":"                            extra_data\u003ddict(server\u003dserver))"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_d516324b","line":2357,"updated":"2015-08-06 20:33:45.000000000","message":"Should we log this case too?","commit_id":"84e3aae8da39142dc3acc97dd7ff2683400b34c5"}],"shade/tests/unit/test_create_server.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"3bf3e44bab65fa051f67f5c192dc09ef9bbaf0c0","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                              return_value\u003dfake_server):"},{"line_number":161,"context_line":"                self.assertRaises("},{"line_number":162,"context_line":"                    OpenStackCloudException, self.client.create_server,"},{"line_number":163,"context_line":"                    wait\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_559ea2b9","line":163,"updated":"2015-08-06 20:33:45.000000000","message":"We should probably also add a test case for when the delete fails, but thats super exceptional and just a different log case so not super worried about it.","commit_id":"84e3aae8da39142dc3acc97dd7ff2683400b34c5"}]}