)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"8c315c5afcca198da64e9db9b40dec4dc6e34b97","unresolved":false,"context_lines":[{"line_number":9,"context_line":"With this commit, list_servers() calls expand_server_vars() by default,"},{"line_number":10,"context_line":"and introduces a new parameter `detailed` that when True will result in"},{"line_number":11,"context_line":"get_hostvars_from_server() being called for each server.  The `detailed`"},{"line_number":12,"context_line":"parameter is available on list_servers, search_servers, and get_servers."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This addresses \u003chttps://storyboard.openstack.org/#!/story/2000386\u003e"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3a29b11f_a97bdb28","line":12,"updated":"2015-10-24 01:00:04.000000000","message":"This says nothing about security groups, which is really confusing, and enough to make me stop the review from progressing, because I want to make sure those changes (which look fine) are intended.","commit_id":"46ce75860f671e2737698fbaf7606d9b6895bf35"}],"shade/__init__.py":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"fe9c2181a37ab4c0e0c33232566444f9ee8539b6","unresolved":false,"context_lines":[{"line_number":1270,"context_line":"                    self._servers_lock.release()"},{"line_number":1271,"context_line":"        return self._servers"},{"line_number":1272,"context_line":""},{"line_number":1273,"context_line":"    def _expand_server_sg(self, server):"},{"line_number":1274,"context_line":"        sg \u003d self.manager.submitTask("},{"line_number":1275,"context_line":"            _tasks.ServerListSecurityGroups(server\u003dserver))"},{"line_number":1276,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_d17043df","line":1273,"updated":"2015-10-23 18:29:04.000000000","message":"Should pass this list through _utils.normalize_nova_secgroups","commit_id":"cd2e7f659b42274036372ebbd46c2536fd9a029d"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"fe9c2181a37ab4c0e0c33232566444f9ee8539b6","unresolved":false,"context_lines":[{"line_number":1279,"context_line":""},{"line_number":1280,"context_line":"        return server"},{"line_number":1281,"context_line":""},{"line_number":1282,"context_line":"    def _list_servers(self, detailed_security_groups\u003dFalse):"},{"line_number":1283,"context_line":"        try:"},{"line_number":1284,"context_line":"            servers \u003d self.manager.submitTask(_tasks.ServerList())"},{"line_number":1285,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_b1426767","line":1282,"updated":"2015-10-23 18:29:04.000000000","message":"I kinda think we should add _expand_server_sg to meta.get_hostvars_from_server and have this just be details\u003dFalse and if it\u0027s true call get_hostvars_from_server on the list and search that.\n\nBut I think that\u0027s a good debatable point.","commit_id":"cd2e7f659b42274036372ebbd46c2536fd9a029d"}]}