)]}'
{"shade/__init__.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"b66ac93a2f0dc0fa60a6b45cbbd7632549494ff0","unresolved":false,"context_lines":[{"line_number":2546,"context_line":"        return vol"},{"line_number":2547,"context_line":""},{"line_number":2548,"context_line":"    def create_volume_snapshot(self, volume_id, force\u003dFalse,"},{"line_number":2549,"context_line":"                               display_name\u003dNone, display_description\u003dNone):"},{"line_number":2550,"context_line":"        try:"},{"line_number":2551,"context_line":"            snapshot \u003d self.manager.submitTask("},{"line_number":2552,"context_line":"                _tasks.VolumeSnapshotCreate("}],"source_content_type":"text/x-python","patch_set":6,"id":"1a26ad4f_19d01953","line":2549,"updated":"2015-10-27 18:41:23.000000000","message":"Needs method documentation.","commit_id":"69dacba81bbd15bd618104134b8c5d5387e92e9b"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"b66ac93a2f0dc0fa60a6b45cbbd7632549494ff0","unresolved":false,"context_lines":[{"line_number":2562,"context_line":""},{"line_number":2563,"context_line":"        return meta.obj_to_dict(snapshot)"},{"line_number":2564,"context_line":""},{"line_number":2565,"context_line":"    def get_volume_snapshot(self, snapshot_id):"},{"line_number":2566,"context_line":"        try:"},{"line_number":2567,"context_line":"            snapshot \u003d self.manager.submitTask("},{"line_number":2568,"context_line":"                _tasks.VolumeSnapshotGet("}],"source_content_type":"text/x-python","patch_set":6,"id":"1a26ad4f_99dd0973","line":2565,"updated":"2015-10-27 18:41:23.000000000","message":"Needs method documentation.\n\nDo we want to allow a get by snapshot display name? If so, you\u0027ll need to follow the pattern for the other get methods.\n\nBTW, I sort of think we probably want to allow by name, as well. We\u0027ve also been adding get_THING_by_id() methods to do exactly what this method is doing, since it is more efficient/faster.","commit_id":"69dacba81bbd15bd618104134b8c5d5387e92e9b"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"b66ac93a2f0dc0fa60a6b45cbbd7632549494ff0","unresolved":false,"context_lines":[{"line_number":2577,"context_line":""},{"line_number":2578,"context_line":"        return meta.obj_to_dict(snapshot)"},{"line_number":2579,"context_line":""},{"line_number":2580,"context_line":"    def list_volume_snapshots(self, detailed\u003dTrue, search_opts\u003dNone):"},{"line_number":2581,"context_line":"        try:"},{"line_number":2582,"context_line":"            return obj_to_dict("},{"line_number":2583,"context_line":"                self.manager.submitTask("}],"source_content_type":"text/x-python","patch_set":6,"id":"1a26ad4f_f9ce7db3","line":2580,"updated":"2015-10-27 18:41:23.000000000","message":"Needs method documentation.","commit_id":"69dacba81bbd15bd618104134b8c5d5387e92e9b"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"b66ac93a2f0dc0fa60a6b45cbbd7632549494ff0","unresolved":false,"context_lines":[{"line_number":2579,"context_line":""},{"line_number":2580,"context_line":"    def list_volume_snapshots(self, detailed\u003dTrue, search_opts\u003dNone):"},{"line_number":2581,"context_line":"        try:"},{"line_number":2582,"context_line":"            return obj_to_dict("},{"line_number":2583,"context_line":"                self.manager.submitTask("},{"line_number":2584,"context_line":"                    _tasks.VolumeSnapshotList(detailed, search_opts)"},{"line_number":2585,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a26ad4f_b9a00592","line":2582,"updated":"2015-10-27 18:41:23.000000000","message":"You want obj_list_to_dict() here.","commit_id":"69dacba81bbd15bd618104134b8c5d5387e92e9b"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"b66ac93a2f0dc0fa60a6b45cbbd7632549494ff0","unresolved":false,"context_lines":[{"line_number":2590,"context_line":"                \"Error getting a list of snapshots: %s\" % e"},{"line_number":2591,"context_line":"            )"},{"line_number":2592,"context_line":""},{"line_number":2593,"context_line":"    def delete_volume_snapshot(self, snapshot):"},{"line_number":2594,"context_line":"        try:"},{"line_number":2595,"context_line":"            return self.manager.submitTask("},{"line_number":2596,"context_line":"                _tasks.VolumeSnapshotDelete(snapshot\u003dsnapshot)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a26ad4f_1937b9b1","line":2593,"updated":"2015-10-27 18:41:23.000000000","message":"Needs method documentation.\n\nAlso, our delete methods have a pattern of returning True if the delete succeeded, False if there was nothing to delete, and exception on error. Please see our coding guidelines.","commit_id":"69dacba81bbd15bd618104134b8c5d5387e92e9b"}],"shade/tests/functional/test_volume.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"b66ac93a2f0dc0fa60a6b45cbbd7632549494ff0","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_volumes(self):"},{"line_number":39,"context_line":"        \u0027\u0027\u0027Test volume and snapshot functionality\u0027\u0027\u0027"},{"line_number":40,"context_line":"        volume_name \u003d str(uuid.uuid4())"},{"line_number":41,"context_line":"        self.addDetail(\u0027volume\u0027, content.text_content(volume_name))"},{"line_number":42,"context_line":"        self.addCleanup(self.cloud.delete_volume, volume_name)"},{"line_number":43,"context_line":"        volume \u003d self.cloud.create_volume(volume_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a26ad4f_9972e97b","line":40,"updated":"2015-10-27 18:41:23.000000000","message":"Better to just use self.getUniqueString().","commit_id":"69dacba81bbd15bd618104134b8c5d5387e92e9b"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"b66ac93a2f0dc0fa60a6b45cbbd7632549494ff0","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        \u0027\u0027\u0027Test volume and snapshot functionality\u0027\u0027\u0027"},{"line_number":40,"context_line":"        volume_name \u003d str(uuid.uuid4())"},{"line_number":41,"context_line":"        self.addDetail(\u0027volume\u0027, content.text_content(volume_name))"},{"line_number":42,"context_line":"        self.addCleanup(self.cloud.delete_volume, volume_name)"},{"line_number":43,"context_line":"        volume \u003d self.cloud.create_volume(volume_name)"},{"line_number":44,"context_line":"        snapshot \u003d self.cloud.create_volume_snapshot(volume[\u0027id\u0027])"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a26ad4f_39bf15d2","line":42,"updated":"2015-10-27 18:41:23.000000000","message":"Your cleanup method needs to be a bit smarter. Delete volume only if one was actually created and delete the snapshot, too, if it was created.","commit_id":"69dacba81bbd15bd618104134b8c5d5387e92e9b"}],"shade/tests/unit/test_create_volume_snapshot.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"76ec7b74984a14f45e4ef3f2a24fc5308101f516","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        Test that create_volume_snapshot with a wait returns the volume"},{"line_number":41,"context_line":"        snapshot when its status changes to \"available\"."},{"line_number":42,"context_line":"        \"\"\""},{"line_number":43,"context_line":"        with patch(\"shade.OpenStackCloud\"):"},{"line_number":44,"context_line":"            build_snapshot \u003d fakes.FakeVolumeSnapshot(\u00271234\u0027, \u0027creating\u0027,"},{"line_number":45,"context_line":"                                                      \u0027foo\u0027, \u0027derpysnapshot\u0027)"},{"line_number":46,"context_line":"            fake_snapshot \u003d fakes.FakeVolumeSnapshot(\u00271234\u0027, \u0027available\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"1a26ad4f_2bff5b35","line":43,"updated":"2015-10-30 13:39:27.000000000","message":"We try not use this method of patching.\n\n1) It causes extraneous indenting.\n2) The way you\u0027ve mocked the calls, you\u0027re unable to validate that the methods were actually called with the parameters you expected.\n\nUse the @mock.patch.object decorator to mock the individual API calls, which will give you a variable that you can use to validate the call and call args.\n\nFor instance, you need to validate that volume_snapshots.create is called with the arguments you expect: volume_id\u003d\u00271234\u0027, force\u003dFalse, etc.\n\nIf you need assistance, feel free to ping me in IRC.  :)","commit_id":"4d036460937cf4d778413b529de6d78c160a13f5"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"76ec7b74984a14f45e4ef3f2a24fc5308101f516","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                    build_snapshot, fake_snapshot]"},{"line_number":53,"context_line":"            }"},{"line_number":54,"context_line":"            OpenStackCloud.cinder_client \u003d Mock(**config)"},{"line_number":55,"context_line":"            self.assertEqual("},{"line_number":56,"context_line":"                self.client.create_volume_snapshot(volume_id\u003d\u00271234\u0027,"},{"line_number":57,"context_line":"                                                   wait\u003dTrue),"},{"line_number":58,"context_line":"                meta.obj_to_dict(fake_snapshot))"}],"source_content_type":"text/x-python","patch_set":17,"id":"1a26ad4f_6b10f3a8","line":55,"updated":"2015-10-30 13:39:27.000000000","message":"Order of assertEqual() args should be (\u003cexpected\u003e, \u003cactual\u003e)\n\nIt\u0027s stupid, yes, but it makes the output of that method make sense when it fails.","commit_id":"4d036460937cf4d778413b529de6d78c160a13f5"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"5bb9d0342c7aa235864274c3e2abc48d68cfbf6d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"\"\"\""},{"line_number":16,"context_line":"test_volume_snapshot"},{"line_number":17,"context_line":"----------------------------------"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Tests for the `create_volume_snapshot` command."}],"source_content_type":"text/x-python","patch_set":18,"id":"1a26ad4f_8999d221","line":16,"updated":"2015-10-30 18:41:08.000000000","message":"nit: test_create_volume_snapshot","commit_id":"2d13047235f224855a2a95c9217e57a97afa662c"}],"shade/tests/unit/test_delete_volume_snapshot.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"5bb9d0342c7aa235864274c3e2abc48d68cfbf6d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"\"\"\""},{"line_number":16,"context_line":"test_volume_snapshot"},{"line_number":17,"context_line":"----------------------------------"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Tests for the `create_volume_snapshot` command."}],"source_content_type":"text/x-python","patch_set":18,"id":"1a26ad4f_49a3ba4f","line":16,"updated":"2015-10-30 18:41:08.000000000","message":"nit: test_delete_volume_snapshot","commit_id":"2d13047235f224855a2a95c9217e57a97afa662c"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"5bb9d0342c7aa235864274c3e2abc48d68cfbf6d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"test_volume_snapshot"},{"line_number":17,"context_line":"----------------------------------"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Tests for the `create_volume_snapshot` command."},{"line_number":20,"context_line":"\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from mock import patch"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a26ad4f_89c0f2e1","line":19,"updated":"2015-10-30 18:41:08.000000000","message":"delete_volume_snapshot","commit_id":"2d13047235f224855a2a95c9217e57a97afa662c"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"5bb9d0342c7aa235864274c3e2abc48d68cfbf6d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from shade.exc import (OpenStackCloudException, OpenStackCloudTimeout)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class TestCreateVolumeSnapshot(base.TestCase):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(TestCreateVolumeSnapshot, self).setUp()"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a26ad4f_e98ac6be","line":29,"updated":"2015-10-30 18:41:08.000000000","message":"should be TestDeleteVolumeSnapshot","commit_id":"2d13047235f224855a2a95c9217e57a97afa662c"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"5bb9d0342c7aa235864274c3e2abc48d68cfbf6d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"class TestCreateVolumeSnapshot(base.TestCase):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(TestCreateVolumeSnapshot, self).setUp()"},{"line_number":33,"context_line":"        config \u003d os_client_config.OpenStackConfig()"},{"line_number":34,"context_line":"        self.client \u003d OpenStackCloud("},{"line_number":35,"context_line":"            cloud_config\u003dconfig.get_one_cloud(validate\u003dFalse))"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a26ad4f_a994cee1","line":32,"updated":"2015-10-30 18:41:08.000000000","message":"TestDeleteVolumeSnapshot","commit_id":"2d13047235f224855a2a95c9217e57a97afa662c"}]}
