)]}'
{"shade/operatorcloud.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"10577e5373066772102191c0a3c37dc6d11403d3","unresolved":false,"context_lines":[{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        with _utils.shade_exceptions{"},{"line_number":434,"context_line":"            \"Error updating machine via patch operation on node {node}\""},{"line_number":435,"context_line":"            \"{msg}\".format(node\u003dname_or_id, msg\u003dstr(e))"},{"line_number":436,"context_line":"        ):"},{"line_number":437,"context_line":"            return self.manager.submitTask("},{"line_number":438,"context_line":"                _tasks.MachinePatch(node_id\u003dname_or_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_2dbed1d4","line":435,"updated":"2015-11-04 16:12:40.000000000","message":"No need to pass the exception message here (the msg\u003d part) since the context manager tacks that on automatically.","commit_id":"0cf8fca72a4d934211d63bde3d3fc58720f6431e"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"10577e5373066772102191c0a3c37dc6d11403d3","unresolved":false,"context_lines":[{"line_number":531,"context_line":""},{"line_number":532,"context_line":"        with _utils.shade_exceptions("},{"line_number":533,"context_line":"            \"Machine update failed - patch operation failed on Machine {node}\""},{"line_number":534,"context_line":"            \"Error: {msg}\".format(node\u003dname_or_id, msg\u003dstr(e))"},{"line_number":535,"context_line":"        ):"},{"line_number":536,"context_line":"            if not patch:"},{"line_number":537,"context_line":"                return dict("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_cdb4e5f3","line":534,"updated":"2015-11-04 16:12:40.000000000","message":"ditto","commit_id":"0cf8fca72a4d934211d63bde3d3fc58720f6431e"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"10577e5373066772102191c0a3c37dc6d11403d3","unresolved":false,"context_lines":[{"line_number":594,"context_line":"        \"\"\""},{"line_number":595,"context_line":"        with _utils.shade_exceptions("},{"line_number":596,"context_line":"            \"Baremetal machine node failed change provision\""},{"line_number":597,"context_line":"            \" state to {state}: {msg}\".format(state\u003dstate, msg\u003dstr(e))"},{"line_number":598,"context_line":"        ):"},{"line_number":599,"context_line":"            machine \u003d self.manager.submitTask("},{"line_number":600,"context_line":"                _tasks.MachineSetProvision(node_uuid\u003dname_or_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_4dc9d577","line":597,"updated":"2015-11-04 16:12:40.000000000","message":"ditto","commit_id":"0cf8fca72a4d934211d63bde3d3fc58720f6431e"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"e1917f275961ed438f91d9c8d1a141a7b6b5a685","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        return self._ironic_client"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def list_nics(self):"},{"line_number":59,"context_line":"        with _utils.shade_exceptions():"},{"line_number":60,"context_line":"            return self.manager.submitTask(_tasks.MachinePortList())"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def list_nics_for_machine(self, uuid):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_04164255","line":59,"updated":"2015-11-04 18:30:41.000000000","message":"You\u0027ve lost the non-exception part of the error message here. What you want is:\n\n  with _utils.shade_exceptions(\"Error fetching machine port list\"):","commit_id":"4be3809058f5287460a5ba18040d7f78c962c7e9"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"e1917f275961ed438f91d9c8d1a141a7b6b5a685","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                \"Machine must be in \u0027manage\u0027 or \u0027available\u0027 state to \""},{"line_number":154,"context_line":"                \"engage inspection: Machine: %s State: %s\""},{"line_number":155,"context_line":"                % (machine[\u0027uuid\u0027], machine[\u0027provision_state\u0027]))"},{"line_number":156,"context_line":"        with _utils.shade_exceptions():"},{"line_number":157,"context_line":"            machine \u003d self.node_set_provision_state(machine[\u0027uuid\u0027], \u0027inspect\u0027)"},{"line_number":158,"context_line":"            if wait:"},{"line_number":159,"context_line":"                for count in _utils._iterate_timeout("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_ff0ceb3c","line":156,"updated":"2015-11-04 18:30:41.000000000","message":"Ditto on missing error message.","commit_id":"4be3809058f5287460a5ba18040d7f78c962c7e9"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"e1917f275961ed438f91d9c8d1a141a7b6b5a685","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        :returns: Returns a dictonary representing the new"},{"line_number":223,"context_line":"                  baremetal node."},{"line_number":224,"context_line":"        \"\"\""},{"line_number":225,"context_line":"        with _utils.shade.exceptions():"},{"line_number":226,"context_line":"            machine \u003d self.manager.submitTask(_tasks.MachineCreate(**kwargs))"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        created_nics \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_9f14bf44","line":225,"updated":"2015-11-04 18:30:41.000000000","message":"Ditto","commit_id":"4be3809058f5287460a5ba18040d7f78c962c7e9"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"e1917f275961ed438f91d9c8d1a141a7b6b5a685","unresolved":false,"context_lines":[{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        with _utils.shade_exceptions("},{"line_number":255,"context_line":"            \"Error transitioning node to available state: \""},{"line_number":256,"context_line":"            \"{state}\".format(state\u003dstate)"},{"line_number":257,"context_line":"        ):"},{"line_number":258,"context_line":"            if wait:"},{"line_number":259,"context_line":"                for count in _utils._iterate_timeout("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_1f4e8f6f","line":256,"updated":"2015-11-04 18:30:41.000000000","message":"This isn\u0027t quite the same as the previous error message. You want:\n\n   with _utils.shade_exceptions(\"Error transitioning node to available state\"):","commit_id":"4be3809058f5287460a5ba18040d7f78c962c7e9"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"e1917f275961ed438f91d9c8d1a141a7b6b5a685","unresolved":false,"context_lines":[{"line_number":410,"context_line":"        :returns: Dictonary representing the newly updated node."},{"line_number":411,"context_line":"        \"\"\""},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        with _utils.shade_exceptions{"},{"line_number":414,"context_line":"            \"Error updating machine via patch operation on node \""},{"line_number":415,"context_line":"            \"{node}\".format(node\u003dname_or_id)"},{"line_number":416,"context_line":"        ):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_1fde8f11","line":413,"updated":"2015-11-04 18:30:41.000000000","message":"{ should be (","commit_id":"4be3809058f5287460a5ba18040d7f78c962c7e9"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"e1917f275961ed438f91d9c8d1a141a7b6b5a685","unresolved":false,"context_lines":[{"line_number":776,"context_line":"        service_type \u003d kwargs.get(\u0027type\u0027, kwargs.get(\u0027service_type\u0027))"},{"line_number":777,"context_line":"        description \u003d kwargs.get(\u0027description\u0027, None)"},{"line_number":778,"context_line":"        with _utils.shade_exceptions("},{"line_number":779,"context_line":"            \"Failed to create service \""},{"line_number":780,"context_line":"            \"{name}\".format(name\u003dname)"},{"line_number":781,"context_line":"        ):"},{"line_number":782,"context_line":"            if self.cloud_config.get_api_version(\u0027identity\u0027).startswith(\u00272\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_7f5ebb13","line":779,"updated":"2015-11-04 18:30:41.000000000","message":"nit: No need to split the string up here. It should all fit on a single line.","commit_id":"4be3809058f5287460a5ba18040d7f78c962c7e9"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"e1917f275961ed438f91d9c8d1a141a7b6b5a685","unresolved":false,"context_lines":[{"line_number":855,"context_line":"        else:"},{"line_number":856,"context_line":"            service_kwargs \u003d {\u0027service\u0027: service[\u0027id\u0027]}"},{"line_number":857,"context_line":"        with _utils.shade_exceptions("},{"line_number":858,"context_line":"            \"Failed to delete service \""},{"line_number":859,"context_line":"            \"{id}\".format(id\u003dservice[\u0027id\u0027])"},{"line_number":860,"context_line":"        ):"},{"line_number":861,"context_line":"            self.manager.submitTask(_tasks.ServiceDelete(**service_kwargs))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_bf92e39d","line":858,"updated":"2015-11-04 18:30:41.000000000","message":"nit: Another unnecessary string split","commit_id":"4be3809058f5287460a5ba18040d7f78c962c7e9"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"e1917f275961ed438f91d9c8d1a141a7b6b5a685","unresolved":false,"context_lines":[{"line_number":937,"context_line":"            with _utils.shade_exceptions("},{"line_number":938,"context_line":"                \"Failed to create endpoint for service \""},{"line_number":939,"context_line":"                \"{service}\".format(service\u003dservice[\u0027name\u0027])"},{"line_number":940,"context_line":"            ):"},{"line_number":941,"context_line":"                endpoint \u003d self.manager.submitTask(_tasks.EndpointCreate("},{"line_number":942,"context_line":"                    region\u003dregion,"},{"line_number":943,"context_line":"                    **args"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_df41e70c","line":940,"updated":"2015-11-04 18:30:41.000000000","message":"Let\u0027s move the \u0027for\u0027 part to inside this context.","commit_id":"4be3809058f5287460a5ba18040d7f78c962c7e9"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"e1917f275961ed438f91d9c8d1a141a7b6b5a685","unresolved":false,"context_lines":[{"line_number":954,"context_line":"            the openstack API call."},{"line_number":955,"context_line":"        \"\"\""},{"line_number":956,"context_line":"        # ToDo: support v3 api (dguerri)"},{"line_number":957,"context_line":"        with _utils.shade_exceptions:"},{"line_number":958,"context_line":"            endpoints \u003d self.manager.submitTask(_tasks.EndpointList())"},{"line_number":959,"context_line":""},{"line_number":960,"context_line":"        return endpoints"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_dfdd6743","line":957,"updated":"2015-11-04 18:30:41.000000000","message":"Missing ()\u0027s and missing error string.","commit_id":"4be3809058f5287460a5ba18040d7f78c962c7e9"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"e1917f275961ed438f91d9c8d1a141a7b6b5a685","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"        else:"},{"line_number":1019,"context_line":"            endpoint_kwargs \u003d {\u0027endpoint\u0027: endpoint[\u0027id\u0027]}"},{"line_number":1020,"context_line":"        with _utils.shade_exceptions("},{"line_number":1021,"context_line":"            \"Failed to delete endpoint \""},{"line_number":1022,"context_line":"            \"{id}\".format(id\u003did)"},{"line_number":1023,"context_line":"        ):"},{"line_number":1024,"context_line":"            self.manager.submitTask(_tasks.EndpointDelete(**endpoint_kwargs))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_5ff2d7d3","line":1021,"updated":"2015-11-04 18:30:41.000000000","message":"nit: Unnecessary string split","commit_id":"4be3809058f5287460a5ba18040d7f78c962c7e9"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"e1917f275961ed438f91d9c8d1a141a7b6b5a685","unresolved":false,"context_lines":[{"line_number":1038,"context_line":"        :raise OpenStackCloudException: if the domain cannot be created"},{"line_number":1039,"context_line":"        \"\"\""},{"line_number":1040,"context_line":"        with _utils.shade_exceptions("},{"line_number":1041,"context_line":"            \"Failed to create domain \""},{"line_number":1042,"context_line":"            \"{name}\".format(name\u003dname)"},{"line_number":1043,"context_line":"        ):"},{"line_number":1044,"context_line":"            domain \u003d self.manager.submitTask(_tasks.DomainCreate("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_1fbbefe6","line":1041,"updated":"2015-11-04 18:30:41.000000000","message":"nit: Unnecessary string split","commit_id":"4be3809058f5287460a5ba18040d7f78c962c7e9"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"e1917f275961ed438f91d9c8d1a141a7b6b5a685","unresolved":false,"context_lines":[{"line_number":1050,"context_line":"    def update_domain("},{"line_number":1051,"context_line":"            self, domain_id, name\u003dNone, description\u003dNone, enabled\u003dNone):"},{"line_number":1052,"context_line":"        with _utils.shade_exceptions("},{"line_number":1053,"context_line":"            \"Error in updating domain \""},{"line_number":1054,"context_line":"            \"{domain}\".format(domain\u003ddomain_id)"},{"line_number":1055,"context_line":"        ):"},{"line_number":1056,"context_line":"            return self.manager.submitTask(_tasks.DomainUpdate("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_ffb70bf3","line":1053,"updated":"2015-11-04 18:30:41.000000000","message":"nit: Unnecessary string split","commit_id":"4be3809058f5287460a5ba18040d7f78c962c7e9"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"e1917f275961ed438f91d9c8d1a141a7b6b5a685","unresolved":false,"context_lines":[{"line_number":1067,"context_line":"            the openstack API call."},{"line_number":1068,"context_line":"        \"\"\""},{"line_number":1069,"context_line":"        with _utils.shade_exceptions("},{"line_number":1070,"context_line":"            \"Failed to delete domian \""},{"line_number":1071,"context_line":"            \"{id}\".format(id\u003ddomain_id)"},{"line_number":1072,"context_line":"        ):"},{"line_number":1073,"context_line":"            # Deleting a domain is expensive, so disabling it first increases"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_1fa20faf","line":1070,"updated":"2015-11-04 18:30:41.000000000","message":"nit: Unnecessary string split\n\nAlso \u0027domian\u0027 should be \u0027domain\u0027","commit_id":"4be3809058f5287460a5ba18040d7f78c962c7e9"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"e1917f275961ed438f91d9c8d1a141a7b6b5a685","unresolved":false,"context_lines":[{"line_number":1086,"context_line":"        \"\"\""},{"line_number":1087,"context_line":"        with _utils.shade_exceptions("},{"line_number":1088,"context_line":"            \"Failed to list domains\""},{"line_number":1089,"context_line":"        ):"},{"line_number":1090,"context_line":"            domains \u003d self.manager.submitTask(_tasks.DomainList())"},{"line_number":1091,"context_line":"        return domains"},{"line_number":1092,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_5fa0979f","line":1089,"updated":"2015-11-04 18:30:41.000000000","message":"nit: This should all fit on a single line.","commit_id":"4be3809058f5287460a5ba18040d7f78c962c7e9"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"e1917f275961ed438f91d9c8d1a141a7b6b5a685","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"        \"\"\""},{"line_number":1108,"context_line":"        with _utils.shade_exceptions("},{"line_number":1109,"context_line":"            \"Failed to list domains\""},{"line_number":1110,"context_line":"        ):"},{"line_number":1111,"context_line":"            domains \u003d self.manager.submitTask("},{"line_number":1112,"context_line":"                _tasks.DomainList(**filters))"},{"line_number":1113,"context_line":"        return domains"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_7f9b1b73","line":1110,"updated":"2015-11-04 18:30:41.000000000","message":"nit: This should all fit on a single line.","commit_id":"4be3809058f5287460a5ba18040d7f78c962c7e9"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"e1917f275961ed438f91d9c8d1a141a7b6b5a685","unresolved":false,"context_lines":[{"line_number":1204,"context_line":"        :raises: OpenStackCloudException on operation error."},{"line_number":1205,"context_line":"        \"\"\""},{"line_number":1206,"context_line":"        with _utils.shade_exceptions("},{"line_number":1207,"context_line":"            \"Failed to create flavor \""},{"line_number":1208,"context_line":"            \"{name}\".format(name\u003dname)"},{"line_number":1209,"context_line":"        ):"},{"line_number":1210,"context_line":"            flavor \u003d self.manager.submitTask("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_df824700","line":1207,"updated":"2015-11-04 18:30:41.000000000","message":"nit: Unnecessary string split","commit_id":"4be3809058f5287460a5ba18040d7f78c962c7e9"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"e1917f275961ed438f91d9c8d1a141a7b6b5a685","unresolved":false,"context_lines":[{"line_number":1232,"context_line":"            return False"},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"        with _utils.shade_exceptions("},{"line_number":1235,"context_line":"            \"Unable to delete flavor \""},{"line_number":1236,"context_line":"            \"{name}\".format(name\u003dname_or_id)"},{"line_number":1237,"context_line":"        ):"},{"line_number":1238,"context_line":"            self.manager.submitTask(_tasks.FlavorDelete(flavor\u003dflavor[\u0027id\u0027]))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_9fa4bfa6","line":1235,"updated":"2015-11-04 18:30:41.000000000","message":"nit: Unnecessary string split","commit_id":"4be3809058f5287460a5ba18040d7f78c962c7e9"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"2215acb6f58f41ef267632ac6279abc67d2124dc","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        :returns: Returns a dictonary representing the new"},{"line_number":223,"context_line":"                  baremetal node."},{"line_number":224,"context_line":"        \"\"\""},{"line_number":225,"context_line":"        with _utils.shade.exceptions(\"Error registering machine with Ironic\"):"},{"line_number":226,"context_line":"            machine \u003d self.manager.submitTask(_tasks.MachineCreate(**kwargs))"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        created_nics \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_7821ebb3","line":225,"updated":"2015-11-04 23:02:27.000000000","message":"shade_exceptions","commit_id":"324527fa3628449c06b086d486c7dcbf3af7df34"}]}
