)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"844ced16bd41aac160a291cc66663e4ee8de3c99","unresolved":false,"context_lines":[{"line_number":606,"context_line":"    def get_template_contents("},{"line_number":607,"context_line":"            self, template_file\u003dNone, template_url\u003dNone,"},{"line_number":608,"context_line":"            template_object\u003dNone, files\u003dNone):"},{"line_number":609,"context_line":"        with _utils.shade_exceptions(\"Error in processing template files\"):"},{"line_number":610,"context_line":"            return template_utils.get_template_contents("},{"line_number":611,"context_line":"                template_file\u003dtemplate_file, template_url\u003dtemplate_url,"},{"line_number":612,"context_line":"                template_object\u003dtemplate_object, files\u003dfiles)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_6cfffbaa","line":609,"updated":"2015-11-09 17:15:19.000000000","message":"nit: technically, this isn\u0027t needed here since OSCE exceptions won\u0027t be thrown from another libraries methods, but I also cannot think of a reason to not use the context manager here.","commit_id":"84f609c2a9863ea2f1d0704981df75d0fc161b25"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"844ced16bd41aac160a291cc66663e4ee8de3c99","unresolved":false,"context_lines":[{"line_number":770,"context_line":"                \"Error getting {service} endpoint on {cloud}:{region}\".format("},{"line_number":771,"context_line":"                    service\u003dservice_key,"},{"line_number":772,"context_line":"                    cloud\u003dself.name,"},{"line_number":773,"context_line":"                    region\u003dself.region_name)):"},{"line_number":774,"context_line":"            # keystone is a special case in keystone, because what?"},{"line_number":775,"context_line":"            if service_key \u003d\u003d \u0027identity\u0027:"},{"line_number":776,"context_line":"                endpoint \u003d self.keystone_session.get_endpoint("}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_ecae8b97","line":773,"updated":"2015-11-09 17:15:19.000000000","message":"You\u0027ll need to keep this one as it was so that we can continue to catch keystoneauth1 exceptions (you left that one below, which is a syntax error now).","commit_id":"84f609c2a9863ea2f1d0704981df75d0fc161b25"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"844ced16bd41aac160a291cc66663e4ee8de3c99","unresolved":false,"context_lines":[{"line_number":1124,"context_line":"        \"\"\""},{"line_number":1125,"context_line":"        # First, try to actually get images from glance, it\u0027s more efficient"},{"line_number":1126,"context_line":"        images \u003d []"},{"line_number":1127,"context_line":"        with _utils.shade.exceptions(\"Error fetching image list\"):"},{"line_number":1128,"context_line":""},{"line_number":1129,"context_line":"            # Creates a generator - does not actually talk to the cloud API"},{"line_number":1130,"context_line":"            # hardcoding page size for now. We\u0027ll have to get MUCH smarter"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_2ccb3320","line":1127,"updated":"2015-11-09 17:15:19.000000000","message":"Same deal as above... we need to catch glanceclient exceptions, so can\u0027t use the context manager here.","commit_id":"84f609c2a9863ea2f1d0704981df75d0fc161b25"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"844ced16bd41aac160a291cc66663e4ee8de3c99","unresolved":false,"context_lines":[{"line_number":1536,"context_line":"        :raises: OpenStackCloudException on operation error."},{"line_number":1537,"context_line":"        \"\"\""},{"line_number":1538,"context_line":"        with _utils.shade_exceptions(\"Unable to delete keypair {name}\".format("},{"line_number":1539,"context_line":"            name\u003dname)):"},{"line_number":1540,"context_line":"            self.manager.submitTask(_tasks.KeypairDelete(key\u003dname))"},{"line_number":1541,"context_line":"        except nova_exceptions.NotFound:"},{"line_number":1542,"context_line":"            self.log.debug(\"Keypair %s not found for deleting\" % name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_cc9f0702","line":1539,"updated":"2015-11-09 17:15:19.000000000","message":"Same here. Can\u0027t use the manager b/c we need to catch nova exceptions too.","commit_id":"84f609c2a9863ea2f1d0704981df75d0fc161b25"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"844ced16bd41aac160a291cc66663e4ee8de3c99","unresolved":false,"context_lines":[{"line_number":2661,"context_line":"    def _nova_delete_floating_ip(self, floating_ip_id):"},{"line_number":2662,"context_line":"        with _utils.shade_exceptions("},{"line_number":2663,"context_line":"                \"Unable to delete floating IP id {fip_id}\".format("},{"line_number":2664,"context_line":"                    fip_id\u003dfloating_ip_id)):"},{"line_number":2665,"context_line":"            self.manager.submitTask("},{"line_number":2666,"context_line":"                _tasks.NovaFloatingIPDelete(floating_ip\u003dfloating_ip_id))"},{"line_number":2667,"context_line":"        except nova_exceptions.NotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_ec70cbde","line":2664,"updated":"2015-11-09 17:15:19.000000000","message":"Again, can\u0027t use the manager here.","commit_id":"84f609c2a9863ea2f1d0704981df75d0fc161b25"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"844ced16bd41aac160a291cc66663e4ee8de3c99","unresolved":false,"context_lines":[{"line_number":2845,"context_line":"    def _nova_detach_ip_from_server(self, server_id, floating_ip_id):"},{"line_number":2846,"context_line":"        with _utils.shade_exceptions("},{"line_number":2847,"context_line":"                \"Error detaching IP {ip} from instance {id}\".format("},{"line_number":2848,"context_line":"                    ip\u003dfloating_ip_id, id\u003dserver_id)):"},{"line_number":2849,"context_line":"            f_ip \u003d self.get_floating_ip(id\u003dfloating_ip_id)"},{"line_number":2850,"context_line":"            if f_ip is None:"},{"line_number":2851,"context_line":"                raise OpenStackCloudException("}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_4c823796","line":2848,"updated":"2015-11-09 17:15:19.000000000","message":"Again, can\u0027t use the manager here.","commit_id":"84f609c2a9863ea2f1d0704981df75d0fc161b25"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"844ced16bd41aac160a291cc66663e4ee8de3c99","unresolved":false,"context_lines":[{"line_number":3169,"context_line":"                                floating_ip\u003dfloating_ip,"},{"line_number":3170,"context_line":"                                id\u003dserver[\u0027id\u0027]))"},{"line_number":3171,"context_line":"                    self.delete_floating_ip(ips[0][\u0027id\u0027])"},{"line_number":3172,"context_line":"            with _utils.shade_exceptions(\"Error in deleting server\"):"},{"line_number":3173,"context_line":"                self.manager.submitTask("},{"line_number":3174,"context_line":"                    _tasks.ServerDelete(server\u003dserver[\u0027id\u0027]))"},{"line_number":3175,"context_line":"            except nova_exceptions.NotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_8c5fbf40","line":3172,"updated":"2015-11-09 17:15:19.000000000","message":"Can\u0027t use the manager here.","commit_id":"84f609c2a9863ea2f1d0704981df75d0fc161b25"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"844ced16bd41aac160a291cc66663e4ee8de3c99","unresolved":false,"context_lines":[{"line_number":3181,"context_line":"        for count in _utils._iterate_timeout("},{"line_number":3182,"context_line":"                timeout,"},{"line_number":3183,"context_line":"                \"Timed out waiting for server to get deleted.\"):"},{"line_number":3184,"context_line":"            with _utils.shade_exceptions(\"Error in deleting server\"):"},{"line_number":3185,"context_line":"                server \u003d self.get_server_by_id(server[\u0027id\u0027])"},{"line_number":3186,"context_line":"                if not server:"},{"line_number":3187,"context_line":"                    return"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_ac5ac34e","line":3184,"updated":"2015-11-09 17:15:19.000000000","message":"Can\u0027t use the manager here.","commit_id":"84f609c2a9863ea2f1d0704981df75d0fc161b25"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"844ced16bd41aac160a291cc66663e4ee8de3c99","unresolved":false,"context_lines":[{"line_number":4055,"context_line":"        elif self.secgroup_source \u003d\u003d \u0027nova\u0027:"},{"line_number":4056,"context_line":"            with _utils.shade_exceptions("},{"line_number":4057,"context_line":"                    \"Failed to delete security group rule {id}\".format("},{"line_number":4058,"context_line":"                        id\u003drule_id)):"},{"line_number":4059,"context_line":"                self.manager.submitTask("},{"line_number":4060,"context_line":"                    _tasks.NovaSecurityGroupRuleDelete(rule\u003drule_id)"},{"line_number":4061,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_0c32ef10","line":4058,"updated":"2015-11-09 17:15:19.000000000","message":"Can\u0027t use the manager here.","commit_id":"84f609c2a9863ea2f1d0704981df75d0fc161b25"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"275896c9a001bf72e9ccbdb77120a53b1d3eac1e","unresolved":false,"context_lines":[{"line_number":611,"context_line":"                template_file\u003dtemplate_file, template_url\u003dtemplate_url,"},{"line_number":612,"context_line":"                template_object\u003dtemplate_object, files\u003dfiles)"},{"line_number":613,"context_line":"        except OpenStackCloudException:"},{"line_number":614,"context_line":"            raise"},{"line_number":615,"context_line":"        except Exception as e:"},{"line_number":616,"context_line":"            raise OpenStackCloudException("},{"line_number":617,"context_line":"                \"Error in processing template files: %s\" % str(e))"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_48353af5","line":614,"updated":"2015-11-09 20:28:46.000000000","message":"OSCE is not raised from a non-shade library.","commit_id":"bee03530b925ce1049aeafdf55ef7ef64c6fd7ac"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"cffed82b173a8322fbff09b5269babf04789b668","unresolved":false,"context_lines":[{"line_number":3154,"context_line":"            server \u003d self.manager.submitTask(_tasks.ServerRebuild("},{"line_number":3155,"context_line":"                server\u003dserver_id, image\u003dimage_id))"},{"line_number":3156,"context_line":"        except OpenStackCloudException:"},{"line_number":3157,"context_line":"            raise"},{"line_number":3158,"context_line":"        except Exception as e:"},{"line_number":3159,"context_line":"            raise OpenStackCloudException("},{"line_number":3160,"context_line":"                \"Error in rebuilding instance: {0}\".format(e))"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_fc8390ca","line":3157,"updated":"2015-11-09 21:57:21.000000000","message":"Not sure why you changed this one, but it can use the _utils.shade_exceptions() context manager.","commit_id":"d5d0b4c6baa003510554a587731a46c3e29593d4"}]}