)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"83577c50c652cf87d46560189441d8ac4920c568","unresolved":false,"context_lines":[{"line_number":1029,"context_line":"        if self.secgroup_source not in (\u0027nova\u0027, \u0027neutron\u0027):"},{"line_number":1030,"context_line":"            return []"},{"line_number":1031,"context_line":""},{"line_number":1032,"context_line":"        try:"},{"line_number":1033,"context_line":"            groups \u003d self.manager.submitTask("},{"line_number":1034,"context_line":"                _tasks.ServerListSecurityGroups(server\u003dserver[\u0027id\u0027]))"},{"line_number":1035,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_95c54d3d","line":1032,"updated":"2015-11-10 16:38:52.000000000","message":"We need to be using _utils.shade_exceptions() here. Not sure how we missed not having exception handling.  :(","commit_id":"07731609ed110b5d729dbea9fdc635d208e99de8"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"83577c50c652cf87d46560189441d8ac4920c568","unresolved":false,"context_lines":[{"line_number":1033,"context_line":"            groups \u003d self.manager.submitTask("},{"line_number":1034,"context_line":"                _tasks.ServerListSecurityGroups(server\u003dserver[\u0027id\u0027]))"},{"line_number":1035,"context_line":"        except Exception:"},{"line_number":1036,"context_line":"            return []"},{"line_number":1037,"context_line":""},{"line_number":1038,"context_line":"        return _utils.normalize_nova_secgroups(groups)"},{"line_number":1039,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_559605f1","line":1036,"updated":"2015-11-10 16:38:52.000000000","message":"Returning an empty list on exception is inconsistent with the other list methods. But using the context manager should handle that.","commit_id":"07731609ed110b5d729dbea9fdc635d208e99de8"}]}