)]}'
{"shade/inventory.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"94ab4084d556756fc2db7f57db40e949e8a4ffed","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                if expand:"},{"line_number":60,"context_line":"                    server_vars \u003d cloud.get_openstack_vars(server)"},{"line_number":61,"context_line":"                else:"},{"line_number":62,"context_line":"                    server_vars \u003d meta.expand_server_vars(cloud, server)"},{"line_number":63,"context_line":"                hostvars.append(server_vars)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        return hostvars"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_e1546155","line":62,"updated":"2015-12-31 00:04:16.000000000","message":"Kind of weird that when expand is False we still expand something. Perhaps we should document that expand really does here?","commit_id":"5297ed92b21fea48be87eed3fb17af0c1ea32f22"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"85c4b8c0d3dcd716ecf02b5bc13527e79d8734ac","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                if expand:"},{"line_number":60,"context_line":"                    server_vars \u003d cloud.get_openstack_vars(server)"},{"line_number":61,"context_line":"                else:"},{"line_number":62,"context_line":"                    server_vars \u003d meta.expand_server_vars(cloud, server)"},{"line_number":63,"context_line":"                hostvars.append(server_vars)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        return hostvars"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_c1559d1d","line":62,"in_reply_to":"fa69d971_e1546155","updated":"2015-12-31 00:18:56.000000000","message":"Done","commit_id":"5297ed92b21fea48be87eed3fb17af0c1ea32f22"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"94ab4084d556756fc2db7f57db40e949e8a4ffed","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        if expand:"},{"line_number":77,"context_line":"            func \u003d self.search_hosts"},{"line_number":78,"context_line":"        else:"},{"line_number":79,"context_line":"            func \u003d self._short_search_hosts"},{"line_number":80,"context_line":"        return _utils._get_entity(func, name_or_id, filters)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_0152d567","line":79,"updated":"2015-12-31 00:04:16.000000000","message":"I *think* you can handle this using functools.partial() instead of creating the _short_search_hosts() method. Take a look at how get_server() uses it.","commit_id":"5297ed92b21fea48be87eed3fb17af0c1ea32f22"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"85c4b8c0d3dcd716ecf02b5bc13527e79d8734ac","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        if expand:"},{"line_number":77,"context_line":"            func \u003d self.search_hosts"},{"line_number":78,"context_line":"        else:"},{"line_number":79,"context_line":"            func \u003d self._short_search_hosts"},{"line_number":80,"context_line":"        return _utils._get_entity(func, name_or_id, filters)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_6131510b","line":79,"in_reply_to":"fa69d971_0152d567","updated":"2015-12-31 00:18:56.000000000","message":"Done","commit_id":"5297ed92b21fea48be87eed3fb17af0c1ea32f22"}],"shade/meta.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"94ab4084d556756fc2db7f57db40e949e8a4ffed","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    server_vars.pop(\u0027links\u0027, None)"},{"line_number":237,"context_line":"    server_vars[\u0027flavor\u0027].pop(\u0027links\u0027, None)"},{"line_number":238,"context_line":"    # OpenStack can return image as a string when you\u0027ve booted from volume"},{"line_number":239,"context_line":"    if str(server[\u0027image\u0027]) !\u003d server[\u0027image\u0027]:"},{"line_number":240,"context_line":"        server_vars[\u0027image\u0027].pop(\u0027links\u0027, None)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    # First, add an IP address. Set it to \u0027\u0027 rather than None if it does"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_a14e69bf","line":239,"updated":"2015-12-31 00:04:16.000000000","message":"This might read better using isinstance() here if you push another change, but sorta \u0027meh\u0027 about it.","commit_id":"5297ed92b21fea48be87eed3fb17af0c1ea32f22"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"85c4b8c0d3dcd716ecf02b5bc13527e79d8734ac","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    server_vars.pop(\u0027links\u0027, None)"},{"line_number":237,"context_line":"    server_vars[\u0027flavor\u0027].pop(\u0027links\u0027, None)"},{"line_number":238,"context_line":"    # OpenStack can return image as a string when you\u0027ve booted from volume"},{"line_number":239,"context_line":"    if str(server[\u0027image\u0027]) !\u003d server[\u0027image\u0027]:"},{"line_number":240,"context_line":"        server_vars[\u0027image\u0027].pop(\u0027links\u0027, None)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    # First, add an IP address. Set it to \u0027\u0027 rather than None if it does"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_213b59ed","line":239,"in_reply_to":"fa69d971_a14e69bf","updated":"2015-12-31 00:18:56.000000000","message":"It\u0027s a move of code from elsewhere. Didn\u0027t want to dork with it too much.","commit_id":"5297ed92b21fea48be87eed3fb17af0c1ea32f22"}]}