)]}'
{"shade/tests/unit/test_inventory.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"824440d7ecee641c2b16193b9a3c53d0534a4bc3","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    @mock.patch(\"os_client_config.config.OpenStackConfig\")"},{"line_number":46,"context_line":"    @mock.patch(\"shade.OpenStackCloud\")"},{"line_number":47,"context_line":"    def test__init_one_cloud(self, mock_cloud, mock_config):"},{"line_number":48,"context_line":"        mock_config.return_value.get_all_clouds.return_value \u003d [{}, {}]"},{"line_number":49,"context_line":"        mock_config.return_value.get_one_cloud.return_value \u003d [{}]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        inv \u003d inventory.OpenStackInventory(cloud\u003d\u0027supercloud\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_ab000d35","line":48,"updated":"2016-01-11 12:57:24.000000000","message":"Mocking get_all_clouds() return value isn\u0027t necessary since it shouldn\u0027t get called.","commit_id":"01bb1c2551ca799e8a0fa7308c613e042ae4be14"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"824440d7ecee641c2b16193b9a3c53d0534a4bc3","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.assertIsInstance(inv.clouds, list)"},{"line_number":57,"context_line":"        self.assertEqual(1, len(inv.clouds))"},{"line_number":58,"context_line":"        self.assertFalse(mock_config.return_value.get_all_clouds.called)"},{"line_number":59,"context_line":"        self.assertTrue(mock_config.return_value.get_one_cloud.called)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @mock.patch(\"os_client_config.config.OpenStackConfig\")"},{"line_number":62,"context_line":"    @mock.patch(\"shade.OpenStackCloud\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_4bf9514d","line":59,"updated":"2016-01-11 12:57:24.000000000","message":"Instead of making sure get_one_cloud() simply gets called, better to mock out get_one_cloud() and use assert_called_once_with() so you can verify the cloud value is used as its argument.","commit_id":"01bb1c2551ca799e8a0fa7308c613e042ae4be14"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"824440d7ecee641c2b16193b9a3c53d0534a4bc3","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        \"\"\""},{"line_number":65,"context_line":"        Test that when os-client-config can\u0027t find a named cloud, a"},{"line_number":66,"context_line":"        shade exception is emitted."},{"line_number":67,"context_line":"        \"\"\""},{"line_number":68,"context_line":"        mock_config.return_value.get_all_clouds.return_value \u003d [{}, {}]"},{"line_number":69,"context_line":"        mock_config.return_value.get_one_cloud.return_value \u003d [{}]"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_6bf6955e","line":67,"updated":"2016-01-11 12:57:24.000000000","message":"This test *totally* is not testing for an exception. It\u0027s the same as the test above it.  :)","commit_id":"01bb1c2551ca799e8a0fa7308c613e042ae4be14"}]}