)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"f39b285025554d459746271de0d6b705e33f61b3","unresolved":false,"context_lines":[{"line_number":882,"context_line":"            except (heat_exceptions.NotFound, heat_exceptions.CommandError):"},{"line_number":883,"context_line":"                # heatclient might raise NotFound or CommandError on"},{"line_number":884,"context_line":"                # not found during poll_for_events"},{"line_number":885,"context_line":"                pass"},{"line_number":886,"context_line":"            stack \u003d self.get_stack(name_or_id)"},{"line_number":887,"context_line":"            if stack and stack[\u0027stack_status\u0027] \u003d\u003d \u0027DELETE_FAILED\u0027:"},{"line_number":888,"context_line":"                raise OpenStackCloudException("}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_46c2b634","line":885,"updated":"2016-03-16 08:32:36.000000000","message":"I see the except for NotFound, since next line the get_stack will give \u0027False\u0027, thus honoring the method contract of returning false if not found.\n\nHowever, do we want to mask the CommandError exception?","commit_id":"bf2ac1142a8182dd2392cf6adcf540d9b7c1f96f"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e7b55ec6ca6763c3c2d05a2450adf0d865a5dfce","unresolved":false,"context_lines":[{"line_number":882,"context_line":"            except (heat_exceptions.NotFound, heat_exceptions.CommandError):"},{"line_number":883,"context_line":"                # heatclient might raise NotFound or CommandError on"},{"line_number":884,"context_line":"                # not found during poll_for_events"},{"line_number":885,"context_line":"                pass"},{"line_number":886,"context_line":"            stack \u003d self.get_stack(name_or_id)"},{"line_number":887,"context_line":"            if stack and stack[\u0027stack_status\u0027] \u003d\u003d \u0027DELETE_FAILED\u0027:"},{"line_number":888,"context_line":"                raise OpenStackCloudException("}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_547989f5","line":885,"in_reply_to":"1af94dfe_46c2b634","updated":"2016-03-17 00:51:29.000000000","message":"Its a bug of heatclient-1.0.0 that it raises NotFound sometimes and CommandError other times when a stack is not found.\n\nAlso, heat may return a 404 or the required DELETE_COMPLETE event depending on poll timings","commit_id":"bf2ac1142a8182dd2392cf6adcf540d9b7c1f96f"}]}
