)]}'
{"shade/tests/unit/base.py":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"68e1e0b5a44b3125b40b3500dbfa2c4785b84521","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class TestCase(base.TestCase):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self, cloud_name\u003d\u0027clouds.yaml\u0027):"},{"line_number":32,"context_line":"        \"\"\"Run before each test method to initialize test environment.\"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        super(TestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":34,"id":"1a122d0e_5e288085","line":31,"updated":"2016-05-04 12:59:45.000000000","message":"Sorry to nitpick a word, but cloud_name is confusing to me, since clouds.yaml contains named clouds. Perhaps can we call the parameter \"cloud_config_fixture\"?","commit_id":"34434ed7267583ee993014c15b0b7323a53495ee"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"82ecc085ebd323f0518cf83034637b3ecd228055","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                                             _nosleep))"},{"line_number":45,"context_line":"        self.fixtures_directory \u003d \u0027shade/tests/unit/fixtures\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        self.fixtures_directory \u003d \u0027shade/tests/unit/fixtures\u0027"},{"line_number":48,"context_line":"        # Isolate os-client-config from test environment"},{"line_number":49,"context_line":"        config \u003d tempfile.NamedTemporaryFile(delete\u003dFalse)"},{"line_number":50,"context_line":"        cloud_path \u003d \u0027%s/clouds/%s\u0027 % (self.fixtures_directory,"}],"source_content_type":"text/x-python","patch_set":39,"id":"7aa08908_79f502ca","line":47,"updated":"2016-06-09 16:46:22.000000000","message":"Duplicate line here for some reason.","commit_id":"240a0d6b4bb9a6ee5ac4afbe3ed735214fb63e51"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"27821e31a663be45ba0b349d795e7929dca427b1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                                             _nosleep))"},{"line_number":45,"context_line":"        self.fixtures_directory \u003d \u0027shade/tests/unit/fixtures\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        self.fixtures_directory \u003d \u0027shade/tests/unit/fixtures\u0027"},{"line_number":48,"context_line":"        # Isolate os-client-config from test environment"},{"line_number":49,"context_line":"        config \u003d tempfile.NamedTemporaryFile(delete\u003dFalse)"},{"line_number":50,"context_line":"        cloud_path \u003d \u0027%s/clouds/%s\u0027 % (self.fixtures_directory,"}],"source_content_type":"text/x-python","patch_set":39,"id":"7aa08908_0a68beb9","line":47,"in_reply_to":"7aa08908_79f502ca","updated":"2016-06-10 06:12:05.000000000","message":"rebase problems, fixed","commit_id":"240a0d6b4bb9a6ee5ac4afbe3ed735214fb63e51"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"82ecc085ebd323f0518cf83034637b3ecd228055","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        else:"},{"line_number":66,"context_line":"            self.record_fixtures \u003d None"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        test_cloud \u003d os.environ.get(\u0027SHADE_OS_CLOUD\u0027, \u0027_test_cloud_\u0027)"},{"line_number":69,"context_line":"        self.config \u003d occ.OpenStackConfig("},{"line_number":70,"context_line":"            config_files\u003d[config.name],"},{"line_number":71,"context_line":"            vendor_files\u003d[vendor.name])"}],"source_content_type":"text/x-python","patch_set":39,"id":"7aa08908_f998d21d","line":68,"updated":"2016-06-09 16:46:22.000000000","message":"What\u0027s the purpose of making this an env variable? You\u0027re not allowing this to be passed in through tox.ini so it\u0027s always going to be \u0027_test_cloud_\u0027.","commit_id":"240a0d6b4bb9a6ee5ac4afbe3ed735214fb63e51"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"27821e31a663be45ba0b349d795e7929dca427b1","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        else:"},{"line_number":66,"context_line":"            self.record_fixtures \u003d None"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        test_cloud \u003d os.environ.get(\u0027SHADE_OS_CLOUD\u0027, \u0027_test_cloud_\u0027)"},{"line_number":69,"context_line":"        self.config \u003d occ.OpenStackConfig("},{"line_number":70,"context_line":"            config_files\u003d[config.name],"},{"line_number":71,"context_line":"            vendor_files\u003d[vendor.name])"}],"source_content_type":"text/x-python","patch_set":39,"id":"7aa08908_aaa9aae1","line":68,"in_reply_to":"7aa08908_f998d21d","updated":"2016-06-10 06:12:05.000000000","message":"The idea is that, in the future, we can run these tests against multiple clouds. So setting the environment var, will allow to read the proper clouds.yaml file here, and record against that.\nI added that var into passenv in tox.ini","commit_id":"240a0d6b4bb9a6ee5ac4afbe3ed735214fb63e51"}],"shade/tests/unit/test_create_server.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"9f53e2588f771a013492278618bab5dd0ecf4ee6","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        Test that an exception in the novaclient create raises an exception in"},{"line_number":44,"context_line":"        create_server."},{"line_number":45,"context_line":"        \"\"\""},{"line_number":46,"context_line":"        with patch(\"shade.OpenStackCloud.nova_client\"):"},{"line_number":47,"context_line":"            config \u003d {"},{"line_number":48,"context_line":"                \"servers.create.side_effect\": Exception(\"exception\"),"},{"line_number":49,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a122d0e_11a64053","line":46,"updated":"2016-05-02 20:31:53.000000000","message":"I don\u0027t see why you are changing this. This test, and all of the ones changed here, pass without this change.","commit_id":"8216fc25980a31103c32ecea1e8fa939c2f80e59"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"f6d4ee2a1aa3f96c53eb45c423cc5d7dc2f0319c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        Test that an exception in the novaclient create raises an exception in"},{"line_number":44,"context_line":"        create_server."},{"line_number":45,"context_line":"        \"\"\""},{"line_number":46,"context_line":"        with patch(\"shade.OpenStackCloud.nova_client\"):"},{"line_number":47,"context_line":"            config \u003d {"},{"line_number":48,"context_line":"                \"servers.create.side_effect\": Exception(\"exception\"),"},{"line_number":49,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a122d0e_9bc35438","line":46,"in_reply_to":"1a122d0e_11a64053","updated":"2016-05-04 09:14:55.000000000","message":"It was causing my tests to fail due to some side effect. But i will have to revisit it, with the latest changes for keystoneauth fixture.","commit_id":"8216fc25980a31103c32ecea1e8fa939c2f80e59"}],"shade/tests/unit/test_flavors.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"9f53e2588f771a013492278618bab5dd0ecf4ee6","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        test_cloud \u003d os.environ.get(\u0027SHADE_OS_CLOUD\u0027, \u0027_test_cloud_\u0027)"},{"line_number":30,"context_line":"        self.op_cloud \u003d shade.OperatorCloud("},{"line_number":31,"context_line":"            cloud_config\u003dself.config.get_one_cloud(cloud\u003dtest_cloud))"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @mock.patch.object(shade.OpenStackCloud, \u0027nova_client\u0027)"},{"line_number":34,"context_line":"    def test_create_flavor(self, mock_nova):"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a122d0e_f10aa426","line":31,"updated":"2016-05-02 20:31:53.000000000","message":"Since we already have similar logic in base.py for self.cloud, I think it makes sense to just move this bit of code for self.op_cloud to base.py as well so that the logic is grouped together. And we can probably remove duplication of operator cloud stuff later on from other tests.","commit_id":"8216fc25980a31103c32ecea1e8fa939c2f80e59"}]}