)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"d973a2b8e8ed76eff4c02317badd69bceeec3dc1","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                self._internal_network_name_or_id \u003d net[\u0027name\u0027]"},{"line_number":157,"context_line":"            if net[\u0027nat_destination\u0027]:"},{"line_number":158,"context_line":"                self._nat_destination \u003d net[\u0027name\u0027]"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        self._use_external_network \u003d cloud_config.config.get("},{"line_number":161,"context_line":"            \u0027use_external_network\u0027, True)"},{"line_number":162,"context_line":"        self._use_internal_network \u003d cloud_config.config.get("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_6f4d3cc3","line":159,"updated":"2016-04-01 18:24:24.000000000","message":"We should probably be a kind library and raise some sort of warning if multiple values are supplied (for either internal, external or nat). Otherwise, we\u0027re just going to pick a random network for the internet/external/nat\u0027d one.","commit_id":"dad1ca8f8b3c04da5140d1238905520de9d67e05"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"2e5dc380da2cbef329986fbac6bc15e94955837c","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                self._internal_network_name_or_id \u003d net[\u0027name\u0027]"},{"line_number":157,"context_line":"            if net[\u0027nat_destination\u0027]:"},{"line_number":158,"context_line":"                self._nat_destination \u003d net[\u0027name\u0027]"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        self._use_external_network \u003d cloud_config.config.get("},{"line_number":161,"context_line":"            \u0027use_external_network\u0027, True)"},{"line_number":162,"context_line":"        self._use_internal_network \u003d cloud_config.config.get("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_bc4beeaf","line":159,"in_reply_to":"ba0121b8_6f4d3cc3","updated":"2016-04-04 16:36:47.000000000","message":"I see this is handled by OCC, so yay.","commit_id":"dad1ca8f8b3c04da5140d1238905520de9d67e05"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"d973a2b8e8ed76eff4c02317badd69bceeec3dc1","unresolved":false,"context_lines":[{"line_number":1470,"context_line":"                        \u0027Multiple networks were found matching {nat_net}\u0027"},{"line_number":1471,"context_line":"                        \u0027 which is the network configured to be the NAT\u0027"},{"line_number":1472,"context_line":"                        \u0027 destination. Please check your cloud resources.\u0027"},{"line_number":1473,"context_line":"                        \u0027 It is probably a good idea to configured this\u0027"},{"line_number":1474,"context_line":"                        \u0027 network by id rather than by name.\u0027.format("},{"line_number":1475,"context_line":"                            nat_net\u003dself._nat_destination))"},{"line_number":1476,"context_line":"                self._external_network_stamp \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_2a75f262","line":1473,"updated":"2016-04-01 18:24:24.000000000","message":"nit: s/configured/configure/","commit_id":"dad1ca8f8b3c04da5140d1238905520de9d67e05"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"97ef821313ecd530580191679a1e4af7c7341541","unresolved":false,"context_lines":[{"line_number":1400,"context_line":"                if self._network_list_stamp:"},{"line_number":1401,"context_line":"                    return"},{"line_number":1402,"context_line":"                if (not self._use_external_network"},{"line_number":1403,"context_line":"                        and not self._use_internal_network):"},{"line_number":1404,"context_line":"                    # Both have been flagged as skip - don\u0027t do a list"},{"line_number":1405,"context_line":"                    return"},{"line_number":1406,"context_line":"                if not self.has_service(\u0027network\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a1b2928_4b4d9e71","line":1403,"updated":"2016-04-11 17:00:26.000000000","message":"I hate these variables, fwiw.","commit_id":"6ab2431f868894df5cd9d7dfedbe32657f326343"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"7df5d54ddb86640c6674851dd89edb1ba3319905","unresolved":false,"context_lines":[{"line_number":1400,"context_line":"                if self._network_list_stamp:"},{"line_number":1401,"context_line":"                    return"},{"line_number":1402,"context_line":"                if (not self._use_external_network"},{"line_number":1403,"context_line":"                        and not self._use_internal_network):"},{"line_number":1404,"context_line":"                    # Both have been flagged as skip - don\u0027t do a list"},{"line_number":1405,"context_line":"                    return"},{"line_number":1406,"context_line":"                if not self.has_service(\u0027network\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a1b2928_37740034","line":1403,"in_reply_to":"7a1b2928_4b4d9e71","updated":"2016-04-11 19:44:00.000000000","message":"aww. but they love you!","commit_id":"6ab2431f868894df5cd9d7dfedbe32657f326343"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"97ef821313ecd530580191679a1e4af7c7341541","unresolved":false,"context_lines":[{"line_number":1444,"context_line":"                            \u0027provider:network_type\u0027 not in network):"},{"line_number":1445,"context_line":"                        internal_networks.append(network)"},{"line_number":1446,"context_line":""},{"line_number":1447,"context_line":"                    # NAT Destinatoin"},{"line_number":1448,"context_line":"                    if self._nat_destination in ("},{"line_number":1449,"context_line":"                            network[\u0027name\u0027], network[\u0027id\u0027]):"},{"line_number":1450,"context_line":"                        if nat_destination:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a1b2928_f04bb9ae","line":1447,"updated":"2016-04-11 17:00:26.000000000","message":"nit: s/Destinatoin/Destination","commit_id":"6ab2431f868894df5cd9d7dfedbe32657f326343"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"7df5d54ddb86640c6674851dd89edb1ba3319905","unresolved":false,"context_lines":[{"line_number":1444,"context_line":"                            \u0027provider:network_type\u0027 not in network):"},{"line_number":1445,"context_line":"                        internal_networks.append(network)"},{"line_number":1446,"context_line":""},{"line_number":1447,"context_line":"                    # NAT Destinatoin"},{"line_number":1448,"context_line":"                    if self._nat_destination in ("},{"line_number":1449,"context_line":"                            network[\u0027name\u0027], network[\u0027id\u0027]):"},{"line_number":1450,"context_line":"                        if nat_destination:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a1b2928_f779e830","line":1447,"in_reply_to":"7a1b2928_f04bb9ae","updated":"2016-04-11 19:44:00.000000000","message":"Done","commit_id":"6ab2431f868894df5cd9d7dfedbe32657f326343"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"97ef821313ecd530580191679a1e4af7c7341541","unresolved":false,"context_lines":[{"line_number":1506,"context_line":"                self._external_networks \u003d external_networks"},{"line_number":1507,"context_line":"                self._internal_networks \u003d internal_networks"},{"line_number":1508,"context_line":"                self._nat_destination_network \u003d nat_destination"},{"line_number":1509,"context_line":"                self._default_network_network \u003d default_network"},{"line_number":1510,"context_line":""},{"line_number":1511,"context_line":"                self._network_list_stamp \u003d True"},{"line_number":1512,"context_line":"            finally:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a1b2928_106d9598","line":1509,"updated":"2016-04-11 17:00:26.000000000","message":"_default_network_network is a totally awesome variable name","commit_id":"6ab2431f868894df5cd9d7dfedbe32657f326343"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"7df5d54ddb86640c6674851dd89edb1ba3319905","unresolved":false,"context_lines":[{"line_number":1506,"context_line":"                self._external_networks \u003d external_networks"},{"line_number":1507,"context_line":"                self._internal_networks \u003d internal_networks"},{"line_number":1508,"context_line":"                self._nat_destination_network \u003d nat_destination"},{"line_number":1509,"context_line":"                self._default_network_network \u003d default_network"},{"line_number":1510,"context_line":""},{"line_number":1511,"context_line":"                self._network_list_stamp \u003d True"},{"line_number":1512,"context_line":"            finally:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a1b2928_b79e5054","line":1509,"in_reply_to":"7a1b2928_106d9598","updated":"2016-04-11 19:44:00.000000000","message":"/me wins","commit_id":"6ab2431f868894df5cd9d7dfedbe32657f326343"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"03c9955d7d8ccd7ed0295fad8d501f6908410be2","unresolved":false,"context_lines":[{"line_number":3303,"context_line":"        port \u003d None"},{"line_number":3304,"context_line":"        if not fixed_address:"},{"line_number":3305,"context_line":"            nat_network \u003d self.get_nat_destination()"},{"line_number":3306,"context_line":"            if len(ports) \u003d\u003d 1 or not self._nat_destination:"},{"line_number":3307,"context_line":"                port \u003d ports[0]"},{"line_number":3308,"context_line":"                if nat_network is None:"},{"line_number":3309,"context_line":"                    warnings.warn("}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_582c81ab","line":3306,"updated":"2016-04-11 22:03:57.000000000","message":"In the len(ports) \u003d\u003d 1 case I am not sure we need to print the warning below. At the very least the warning message isn\u0027t accurate, nothing is selected at random shade uses the only option available to it.","commit_id":"6ab2431f868894df5cd9d7dfedbe32657f326343"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"97ef821313ecd530580191679a1e4af7c7341541","unresolved":false,"context_lines":[{"line_number":3318,"context_line":"            else:"},{"line_number":3319,"context_line":"                for maybe_port in ports:"},{"line_number":3320,"context_line":"                    if maybe_port[\u0027network_id\u0027] \u003d\u003d nat_network[\u0027id\u0027]:"},{"line_number":3321,"context_line":"                        port \u003d maybe_port"},{"line_number":3322,"context_line":"                if not port:"},{"line_number":3323,"context_line":"                    raise OpenStackCloudException("},{"line_number":3324,"context_line":"                        \u0027No port on server {server} was found matching the\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a1b2928_1082b594","line":3321,"updated":"2016-04-11 17:00:26.000000000","message":"We should short-circuit/break here if we find a matching port. Otherwise we\u0027ll always go through ALL the ports.","commit_id":"6ab2431f868894df5cd9d7dfedbe32657f326343"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"7df5d54ddb86640c6674851dd89edb1ba3319905","unresolved":false,"context_lines":[{"line_number":3318,"context_line":"            else:"},{"line_number":3319,"context_line":"                for maybe_port in ports:"},{"line_number":3320,"context_line":"                    if maybe_port[\u0027network_id\u0027] \u003d\u003d nat_network[\u0027id\u0027]:"},{"line_number":3321,"context_line":"                        port \u003d maybe_port"},{"line_number":3322,"context_line":"                if not port:"},{"line_number":3323,"context_line":"                    raise OpenStackCloudException("},{"line_number":3324,"context_line":"                        \u0027No port on server {server} was found matching the\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a1b2928_b7a49057","line":3321,"in_reply_to":"7a1b2928_1082b594","updated":"2016-04-11 19:44:00.000000000","message":"Done","commit_id":"6ab2431f868894df5cd9d7dfedbe32657f326343"}]}
