)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"66c093752c1dc31fc2991665a340ceb3a7e6f213","unresolved":false,"context_lines":[{"line_number":1469,"context_line":"                if len(_all_networks) \u003d\u003d 1:"},{"line_number":1470,"context_line":"                    self._nat_destination_network \u003d _all_networks[0]"},{"line_number":1471,"context_line":"                elif len(_all_networks) \u003e 1:"},{"line_number":1472,"context_line":"                    net_ids \u003d [net[\u0027id\u0027] for net in _all_networks]"},{"line_number":1473,"context_line":"                    target_ids \u003d set()"},{"line_number":1474,"context_line":"                    for subnet in self.list_subnets():"},{"line_number":1475,"context_line":"                        if \u0027gateway_ip\u0027 in subnet and subnet[\u0027gateway_ip\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_8a87de5f","line":1472,"updated":"2016-04-01 18:17:25.000000000","message":"net_ids is never used.","commit_id":"2b92ee6175933573d273412a13c794036c4e4113"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"66c093752c1dc31fc2991665a340ceb3a7e6f213","unresolved":false,"context_lines":[{"line_number":1474,"context_line":"                    for subnet in self.list_subnets():"},{"line_number":1475,"context_line":"                        if \u0027gateway_ip\u0027 in subnet and subnet[\u0027gateway_ip\u0027]:"},{"line_number":1476,"context_line":"                            target_ids.add(subnet[\u0027network_id\u0027])"},{"line_number":1477,"context_line":"                    for net in all_networks:"},{"line_number":1478,"context_line":"                        if net[\u0027id\u0027] in target_ids:"},{"line_number":1479,"context_line":"                            self._nat_destination_network \u003d net"},{"line_number":1480,"context_line":"                            break"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_ea7ada75","line":1477,"updated":"2016-04-01 18:17:25.000000000","message":"all_networks is missing a leading _ here.  However, I do wonder why it has one in the first place.","commit_id":"2b92ee6175933573d273412a13c794036c4e4113"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"66c093752c1dc31fc2991665a340ceb3a7e6f213","unresolved":false,"context_lines":[{"line_number":1483,"context_line":"                            \u0027Multiple networks were found matching {nat_net}\u0027"},{"line_number":1484,"context_line":"                            \u0027 which is the network configured to be the NAT\u0027"},{"line_number":1485,"context_line":"                            \u0027 destination. Please check your cloud resources.\u0027"},{"line_number":1486,"context_line":"                            \u0027 It is probably a good idea to configured this\u0027"},{"line_number":1487,"context_line":"                            \u0027 network by id rather than by name.\u0027.format("},{"line_number":1488,"context_line":"                                nat_net\u003dself._nat_destination))"},{"line_number":1489,"context_line":"                self._external_network_stamp \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_ca7d566e","line":1486,"updated":"2016-04-01 18:17:25.000000000","message":"s/configured/configure/","commit_id":"2b92ee6175933573d273412a13c794036c4e4113"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"526c3222c4cea2ed3e3243d161100162fd419a8a","unresolved":false,"context_lines":[{"line_number":1459,"context_line":"                                \u0027 by name.\u0027.format("},{"line_number":1460,"context_line":"                                    nat_net\u003dself._nat_destination))"},{"line_number":1461,"context_line":"                        nat_destination \u003d network"},{"line_number":1462,"context_line":"                    else:"},{"line_number":1463,"context_line":"                        # TODO(mordred) need a config value for floating"},{"line_number":1464,"context_line":"                        # ips for this cloud so that we can skip this"},{"line_number":1465,"context_line":"                        # No configured nat destination, we have to figured"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_e76dbc05","line":1462,"updated":"2016-04-12 17:25:59.000000000","message":"Should this clause be \"if self._nat_destination is None\" rather than \"if the current network is not self._nat_destination\"?\n\nI ask because I believe as written this will run regardless of whether self._nat_destination is actually set.  And if it is set, and there is more than one network with a gateway IP, this clause may run first, and then the second network which matches self._nat_destination would hit the clause above and error out.  In other words, we would error about multiple matching networks despite the user specifying exactly (the correct) one.\n\nI bet it wouldn\u0027t be too hard to test this case.","commit_id":"efcaf32d81e6e2cb10249b25f740bd5f153aa390"}]}
