)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"2cd7e863fbfe20f0478d063cd62f6e75ba375c26","unresolved":false,"context_lines":[{"line_number":3026,"context_line":""},{"line_number":3027,"context_line":"        :param network: Nova pool name or Neutron network name or id."},{"line_number":3028,"context_line":"        :param server: (optional) Server dict for the server to create"},{"line_number":3029,"context_line":"                       the IP for and to which it should be attached"},{"line_number":3030,"context_line":""},{"line_number":3031,"context_line":"        :returns: a floating IP address"},{"line_number":3032,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_fb598c5b","line":3029,"updated":"2016-04-06 09:26:56.000000000","message":"need to update doc","commit_id":"379c2e1c4a0053bc9a66ccfcfadde8229e65e481"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"2cd7e863fbfe20f0478d063cd62f6e75ba375c26","unresolved":false,"context_lines":[{"line_number":3200,"context_line":"        return server"},{"line_number":3201,"context_line":""},{"line_number":3202,"context_line":"    def _get_free_fixed_port(self, server, fixed_address\u003dNone,"},{"line_number":3203,"context_line":"                             internal_network\u003dNone):"},{"line_number":3204,"context_line":"        # If we are caching port lists, we may not find the port for"},{"line_number":3205,"context_line":"        # our server if the list is old.  Try for at least 2 cache"},{"line_number":3206,"context_line":"        # periods if that is the case."}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_2733ea15","line":3203,"updated":"2016-04-06 09:26:56.000000000","message":"docstring here would be nice","commit_id":"379c2e1c4a0053bc9a66ccfcfadde8229e65e481"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"2cd7e863fbfe20f0478d063cd62f6e75ba375c26","unresolved":false,"context_lines":[{"line_number":3213,"context_line":"                \"Timeout waiting for port to show up in list\","},{"line_number":3214,"context_line":"                wait\u003dself._PORT_AGE):"},{"line_number":3215,"context_line":"            try:"},{"line_number":3216,"context_line":"                if internal_network:"},{"line_number":3217,"context_line":"                    ports \u003d self.search_ports(filters\u003d{\u0027device_id\u0027:"},{"line_number":3218,"context_line":"                                                       server[\u0027id\u0027],"},{"line_number":3219,"context_line":"                                                       \u0027network\u0027:"},{"line_number":3220,"context_line":"                                                       internal_network})"},{"line_number":3221,"context_line":"                else:"},{"line_number":3222,"context_line":"                    ports \u003d self.search_ports(filters\u003d{\u0027device_id\u0027:"},{"line_number":3223,"context_line":"                                                       server[\u0027id\u0027]})"},{"line_number":3224,"context_line":"                break"},{"line_number":3225,"context_line":"            except OpenStackCloudTimeout:"},{"line_number":3226,"context_line":"                ports \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_3bc82422","line":3223,"range":{"start_line":3216,"start_character":0,"end_line":3223,"end_character":69},"updated":"2016-04-06 09:26:56.000000000","message":"How about:\n\n\n  port_filter \u003d {\u0027device_id\u0027: server[\u0027id\u0027]}\n  if internal_network:\n      port_filter[\"network\"] \u003d internal_network\n  ports \u003d self.search_ports(filters\u003dport_filters)","commit_id":"379c2e1c4a0053bc9a66ccfcfadde8229e65e481"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"2cd7e863fbfe20f0478d063cd62f6e75ba375c26","unresolved":false,"context_lines":[{"line_number":3374,"context_line":"                     to the server in Nova. Defaults to False."},{"line_number":3375,"context_line":"        :param timeout: (optional) Seconds to wait, defaults to 60."},{"line_number":3376,"context_line":"                        See the ``wait`` parameter."},{"line_number":3377,"context_line":""},{"line_number":3378,"context_line":"        :returns: the update server dict"},{"line_number":3379,"context_line":"        \"\"\""},{"line_number":3380,"context_line":"        if reuse:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_bbb1d491","line":3377,"updated":"2016-04-06 09:26:56.000000000","message":"need to update doc","commit_id":"379c2e1c4a0053bc9a66ccfcfadde8229e65e481"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"f52249ce4948a9a6145499616e6dee068b764fac","unresolved":false,"context_lines":[{"line_number":3027,"context_line":"        :param network: Nova pool name or Neutron network name or id."},{"line_number":3028,"context_line":"        :param server: (optional) Server dict for the server to create"},{"line_number":3029,"context_line":"                       the IP for and to which it should be attached"},{"line_number":3030,"context_line":""},{"line_number":3031,"context_line":"        :returns: a floating IP address"},{"line_number":3032,"context_line":""},{"line_number":3033,"context_line":"        :raises: ``OpenStackCloudException``, on operation error."}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_89076017","line":3030,"updated":"2016-04-06 12:43:55.000000000","message":"Need to update doc","commit_id":"1a06e15c0660bc16b17ccd47f6216595057be1b1"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"f52249ce4948a9a6145499616e6dee068b764fac","unresolved":false,"context_lines":[{"line_number":3201,"context_line":""},{"line_number":3202,"context_line":"    def _get_free_fixed_port(self, server, fixed_address\u003dNone,"},{"line_number":3203,"context_line":"                             internal_network\u003dNone):"},{"line_number":3204,"context_line":"        \"\"\"Returns fixed port."},{"line_number":3205,"context_line":""},{"line_number":3206,"context_line":"        :param server: Server dict."},{"line_number":3207,"context_line":"        :param fixed_address: Fixed IP address."}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_89a3e0ff","line":3204,"updated":"2016-04-06 12:43:55.000000000","message":"Returns server\u0027s port","commit_id":"1a06e15c0660bc16b17ccd47f6216595057be1b1"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"f52249ce4948a9a6145499616e6dee068b764fac","unresolved":false,"context_lines":[{"line_number":3204,"context_line":"        \"\"\"Returns fixed port."},{"line_number":3205,"context_line":""},{"line_number":3206,"context_line":"        :param server: Server dict."},{"line_number":3207,"context_line":"        :param fixed_address: Fixed IP address."},{"line_number":3208,"context_line":"        :param internal_network: Name of the network of the port."},{"line_number":3209,"context_line":"        \"\"\""},{"line_number":3210,"context_line":"        # If we are caching port lists, we may not find the port for"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_29f0d4fd","line":3207,"updated":"2016-04-06 12:43:55.000000000","message":"fixed ip address of the port","commit_id":"1a06e15c0660bc16b17ccd47f6216595057be1b1"},{"author":{"_account_id":19619,"name":"Michal Pryc","email":"mpryc@redhat.com","username":"migi"},"change_message_id":"73c1280cd5ba97ff19c2952e3604128b8a5d2e00","unresolved":false,"context_lines":[{"line_number":3222,"context_line":"            try:"},{"line_number":3223,"context_line":"                port_filter \u003d {\u0027device_id\u0027: server[\u0027id\u0027]}"},{"line_number":3224,"context_line":"                if internal_network:"},{"line_number":3225,"context_line":"                    port_filter[\u0027network\u0027] \u003d internal_network"},{"line_number":3226,"context_line":"                ports \u003d self.search_ports(filters\u003dport_filter)"},{"line_number":3227,"context_line":"                break"},{"line_number":3228,"context_line":"            except OpenStackCloudTimeout:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_7a6b3586","line":3225,"updated":"2016-04-08 07:26:55.000000000","message":"This case is never tested in the unit tests, otherwise the change looks ok.\nPlease fix or comment why it should not be tested before getting +1.","commit_id":"f66978ccf2017e3b2eba093dbb2debedaf1b88d7"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"8e116cb070f68916b5bc442e30c62cd5acc646a3","unresolved":false,"context_lines":[{"line_number":3345,"context_line":"        port \u003d None"},{"line_number":3346,"context_line":"        if not fixed_address:"},{"line_number":3347,"context_line":"            if nat_destination:"},{"line_number":3348,"context_line":"                nat_network \u003d self.get_network(nat_destination)"},{"line_number":3349,"context_line":"            else:"},{"line_number":3350,"context_line":"                nat_network \u003d self.get_nat_destination()"},{"line_number":3351,"context_line":"            if len(ports) \u003d\u003d 1 or not nat_network:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a18252c_28c94f79","line":3348,"updated":"2016-04-12 14:32:15.000000000","message":"I think if we fail to find the network given to us by the user, we should throw an exception here rather than falling through to the warning below and the behavior of choosing one at random. This could be confusing for the user.","commit_id":"9148cce2bf42f1aa7375c7b797a6cf5a4d840b40"}]}
