)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"a2a759c89c431423a4b8d6263291309a32aec53b","unresolved":false,"context_lines":[{"line_number":5022,"context_line":"                \"Zone %s not found.\" % name_or_id)"},{"line_number":5023,"context_line":""},{"line_number":5024,"context_line":"        # We capitalize the type in case the user sends in lowercase"},{"line_number":5025,"context_line":"        type_ \u003d type_.upper()"},{"line_number":5026,"context_line":""},{"line_number":5027,"context_line":"        with _utils.shade_exceptions("},{"line_number":5028,"context_line":"                \"Unable to create recordset {name}\".format(name\u003dname)):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_01136467","line":5025,"updated":"2016-04-18 14:31:15.000000000","message":"Same as zone","commit_id":"99183405af78578d0e33b9eaadc05d8af4ace7b3"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"0ff1ac1730fe0dece47dab840fbf34d305177026","unresolved":false,"context_lines":[{"line_number":5022,"context_line":"                \"Zone %s not found.\" % name_or_id)"},{"line_number":5023,"context_line":""},{"line_number":5024,"context_line":"        # We capitalize the type in case the user sends in lowercase"},{"line_number":5025,"context_line":"        type_ \u003d type_.upper()"},{"line_number":5026,"context_line":""},{"line_number":5027,"context_line":"        with _utils.shade_exceptions("},{"line_number":5028,"context_line":"                \"Unable to create recordset {name}\".format(name\u003dname)):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_1cd747c0","line":5025,"in_reply_to":"1a122d0e_01136467","updated":"2016-04-18 14:42:24.000000000","message":"In this case \"type\" refers to RecordSet type (i.e. A, AAAA, CNAME, MX etc) I don\u0027t think it could work the same as the suggestion you made for the zone patch.","commit_id":"99183405af78578d0e33b9eaadc05d8af4ace7b3"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"a2a759c89c431423a4b8d6263291309a32aec53b","unresolved":false,"context_lines":[{"line_number":5054,"context_line":"            raise OpenStackCloudException("},{"line_number":5055,"context_line":"                \"Recordset %s not found.\" % name_or_id)"},{"line_number":5056,"context_line":""},{"line_number":5057,"context_line":"        updated_recordset \u003d {}"},{"line_number":5058,"context_line":"        if records is not None:"},{"line_number":5059,"context_line":"            updated_recordset[\u0027records\u0027] \u003d records"},{"line_number":5060,"context_line":"        if description is not None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_a11b907f","line":5057,"updated":"2016-04-18 14:31:15.000000000","message":"Same comment as zones patch","commit_id":"99183405af78578d0e33b9eaadc05d8af4ace7b3"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"095c58c464c690647796d8934aa0c393526916ed","unresolved":false,"context_lines":[{"line_number":4961,"context_line":"            A dictionary of meta data to use for further filtering"},{"line_number":4962,"context_line":""},{"line_number":4963,"context_line":"        :returns:  A recordset dict or None if no matching recordset is"},{"line_number":4964,"context_line":"        found."},{"line_number":4965,"context_line":""},{"line_number":4966,"context_line":"        \"\"\""},{"line_number":4967,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a122d0e_508fbf22","line":4964,"updated":"2016-04-25 16:43:51.000000000","message":"nit: I think you\u0027ll need to indent the second line of the docstring for it to format correctly.","commit_id":"faa19ccab0c6d48d4a52c062caacd975456b8c8f"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"001dabd38637c234172c5be3a21ada6822b150b7","unresolved":false,"context_lines":[{"line_number":4965,"context_line":""},{"line_number":4966,"context_line":"        \"\"\""},{"line_number":4967,"context_line":"        try:"},{"line_number":4968,"context_line":"            return self.manager.submitTask(_tasks.RecordSetGet("},{"line_number":4969,"context_line":"                zone\u003dzone,"},{"line_number":4970,"context_line":"                recordset\u003dname_or_id))"},{"line_number":4971,"context_line":"        except:"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a122d0e_ccd51c1c","line":4968,"updated":"2016-04-23 12:51:25.000000000","message":"Normally we have get be a filter on list and search. However, since recordset requires zone as an arg, similar to get_object, maybe it\u0027s not bad to do get here?\n\nI was also going to say that I wasn\u0027t sue about the zone required argument, but it is in fact required in the REST API.","commit_id":"faa19ccab0c6d48d4a52c062caacd975456b8c8f"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"095c58c464c690647796d8934aa0c393526916ed","unresolved":false,"context_lines":[{"line_number":4966,"context_line":"        \"\"\""},{"line_number":4967,"context_line":"        try:"},{"line_number":4968,"context_line":"            return self.manager.submitTask(_tasks.RecordSetGet("},{"line_number":4969,"context_line":"                zone\u003dzone,"},{"line_number":4970,"context_line":"                recordset\u003dname_or_id))"},{"line_number":4971,"context_line":"        except:"},{"line_number":4972,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a122d0e_3092034c","line":4969,"updated":"2016-04-25 16:43:51.000000000","message":"Right. The get is usually just a filter, although we have some get APIs that call APIs directly for performance reasons (these are few). If we aren\u0027t going to use the list or search call, then we cannot support the \u0027filters\u0027 parameter, which isn\u0027t even used here in this method. So you need to either decide on flexibility (supporting filters) or performance (direct API call).","commit_id":"faa19ccab0c6d48d4a52c062caacd975456b8c8f"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"001dabd38637c234172c5be3a21ada6822b150b7","unresolved":false,"context_lines":[{"line_number":4981,"context_line":""},{"line_number":4982,"context_line":"        :param zone: Name or ID of the zone managing the recordset"},{"line_number":4983,"context_line":"        :param name: Name of the recordset"},{"line_number":4984,"context_line":"        :param type_: Type of the recordset"},{"line_number":4985,"context_line":"        :param records: List of the recordset definitions"},{"line_number":4986,"context_line":"        :param description: Description of the recordset"},{"line_number":4987,"context_line":"        :param ttl: TTL value of the recordset"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a122d0e_6c95e83e","line":4984,"updated":"2016-04-23 12:51:25.000000000","message":"docs don\u0027t match parameter. can be fixed in a follow up","commit_id":"faa19ccab0c6d48d4a52c062caacd975456b8c8f"}],"shade/tests/unit/test_recordset.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"5d58d9ee31cd7bd5a8ac88fd0b7a0abe03b0c4a1","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def setUp(self):"},{"line_number":47,"context_line":"        super(TestRecordset, self).setUp()"},{"line_number":48,"context_line":"        self.cloud \u003d shade.openstack_cloud(validate\u003dFalse)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @mock.patch.object(shade.OpenStackCloud, \u0027designate_client\u0027)"},{"line_number":51,"context_line":"    def test_create_recordset(self, mock_designate):"}],"source_content_type":"text/x-python","patch_set":25,"id":"1a122d0e_7e66ee51","line":48,"updated":"2016-04-26 18:48:23.000000000","message":"Is there any reason you create a new self.cloud here rather than use the one from the base class?","commit_id":"c13e4f9325c29046334888cfe2668dd5937f26c0"}]}