)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f9aa8ae0f7d06b09ad2ea11d98d567bbc2b5532e","unresolved":false,"context_lines":[{"line_number":3254,"context_line":""},{"line_number":3255,"context_line":"        :raises: ``OpenStackCloudException``, on operation error."},{"line_number":3256,"context_line":"        \"\"\""},{"line_number":3257,"context_line":"        for _ in _utils._iterate_timeout("},{"line_number":3258,"context_line":"                timeout,"},{"line_number":3259,"context_line":"                \"Timeout waiting for floating IP to delete\"):"},{"line_number":3260,"context_line":"            if self.has_service(\u0027network\u0027) and not self._use_nova_floating():"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_be839403","line":3257,"updated":"2016-04-18 23:19:42.000000000","message":"It is usually best to let _ be the gettext function.","commit_id":"9f705007f5a9476422448e73870e300705a28c46"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"b499f6c9604ecb6cdd28b6bc3716acdaaeae3704","unresolved":false,"context_lines":[{"line_number":3263,"context_line":"                except OpenStackCloudURINotFound as e:"},{"line_number":3264,"context_line":"                    self.log.debug("},{"line_number":3265,"context_line":"                        \"Something went wrong talking to neutron API: \""},{"line_number":3266,"context_line":"                        \"\u0027{msg}\u0027. Trying with Nova.\".format(msg\u003dstr(e)))"},{"line_number":3267,"context_line":"            else:"},{"line_number":3268,"context_line":"                result \u003d self._nova_delete_floating_ip(floating_ip_id)"},{"line_number":3269,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_1eee08ec","line":3266,"updated":"2016-04-18 23:16:08.000000000","message":"This doesn\u0027t fall through anymore (like the message says).","commit_id":"9f705007f5a9476422448e73870e300705a28c46"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f9aa8ae0f7d06b09ad2ea11d98d567bbc2b5532e","unresolved":false,"context_lines":[{"line_number":3270,"context_line":"            if wait:"},{"line_number":3271,"context_line":"                # No need to check - we got an error already"},{"line_number":3272,"context_line":"                if not result:"},{"line_number":3273,"context_line":"                    continue"},{"line_number":3274,"context_line":"                try:"},{"line_number":3275,"context_line":"                    f_ip \u003d self.get_floating_ip(id\u003dfloating_ip_id)"},{"line_number":3276,"context_line":"                    if not f_ip:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_1e9c4868","line":3273,"updated":"2016-04-18 23:19:42.000000000","message":"Instead of continuing shouldn\u0027t we break? Or do we want to risk retrying with the possibility of spending 3 minutes failing to delete a thing that can\u0027t delete?","commit_id":"9f705007f5a9476422448e73870e300705a28c46"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"b499f6c9604ecb6cdd28b6bc3716acdaaeae3704","unresolved":false,"context_lines":[{"line_number":3275,"context_line":"                    f_ip \u003d self.get_floating_ip(id\u003dfloating_ip_id)"},{"line_number":3276,"context_line":"                    if not f_ip:"},{"line_number":3277,"context_line":"                        return True"},{"line_number":3278,"context_line":"                except Exception:"},{"line_number":3279,"context_line":"                    continue"},{"line_number":3280,"context_line":""},{"line_number":3281,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_7ebbbce5","line":3278,"updated":"2016-04-18 23:16:08.000000000","message":"Should we debug log the exception?","commit_id":"9f705007f5a9476422448e73870e300705a28c46"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f9aa8ae0f7d06b09ad2ea11d98d567bbc2b5532e","unresolved":false,"context_lines":[{"line_number":3276,"context_line":"                    if not f_ip:"},{"line_number":3277,"context_line":"                        return True"},{"line_number":3278,"context_line":"                except Exception:"},{"line_number":3279,"context_line":"                    continue"},{"line_number":3280,"context_line":""},{"line_number":3281,"context_line":"        return True"},{"line_number":3282,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_5e8c0035","line":3279,"updated":"2016-04-18 23:19:42.000000000","message":"See above.","commit_id":"9f705007f5a9476422448e73870e300705a28c46"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"9a3fb7527741a12b7d9374426aaf1a8396288699","unresolved":false,"context_lines":[{"line_number":3260,"context_line":"            result \u003d self._delete_floating_ip(floating_ip_id)"},{"line_number":3261,"context_line":""},{"line_number":3262,"context_line":"            if not wait or not result:"},{"line_number":3263,"context_line":"                return result"},{"line_number":3264,"context_line":""},{"line_number":3265,"context_line":"            if wait:"},{"line_number":3266,"context_line":"                f_ip \u003d self.get_floating_ip(id\u003dfloating_ip_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_8ca3f6ff","line":3263,"updated":"2016-04-19 13:32:26.000000000","message":"How can \u0027result\u0027 be anything other than None here? You\u0027ve modified both _neutron_delete_floating_ip and _nova_delete_floating_ip to return nothing.","commit_id":"04d7c0d45d74bd23745720fdb3beafa286c85bf4"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"9a3fb7527741a12b7d9374426aaf1a8396288699","unresolved":false,"context_lines":[{"line_number":3289,"context_line":"        except Exception as e:"},{"line_number":3290,"context_line":"            raise OpenStackCloudException("},{"line_number":3291,"context_line":"                \"Unable to delete floating IP id {fip_id}: {msg}\".format("},{"line_number":3292,"context_line":"                    fip_id\u003dfloating_ip_id, msg\u003dstr(e)))"},{"line_number":3293,"context_line":""},{"line_number":3294,"context_line":"    def _nova_delete_floating_ip(self, floating_ip_id):"},{"line_number":3295,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_2c890276","line":3292,"updated":"2016-04-19 13:32:26.000000000","message":"Why don\u0027t we return the boolean anymore?","commit_id":"04d7c0d45d74bd23745720fdb3beafa286c85bf4"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"9a3fb7527741a12b7d9374426aaf1a8396288699","unresolved":false,"context_lines":[{"line_number":3304,"context_line":"                \"Unable to delete floating IP id {fip_id}: {msg}\".format("},{"line_number":3305,"context_line":"                    fip_id\u003dfloating_ip_id, msg\u003dstr(e)))"},{"line_number":3306,"context_line":""},{"line_number":3307,"context_line":"        return"},{"line_number":3308,"context_line":""},{"line_number":3309,"context_line":"    def _attach_ip_to_server("},{"line_number":3310,"context_line":"            self, server, floating_ip,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_ec8b8a66","line":3307,"updated":"2016-04-19 13:32:26.000000000","message":"Why don\u0027t we return the boolean anymore?","commit_id":"04d7c0d45d74bd23745720fdb3beafa286c85bf4"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"3849dec8ea04f46913e8439308f2a07a2c67886d","unresolved":false,"context_lines":[{"line_number":3251,"context_line":"        :param retry: number of times to retry. Optional, defaults to two,"},{"line_number":3252,"context_line":"                      which is in addition to the initial delete call."},{"line_number":3253,"context_line":"                      A value of 0 will cause no checking of results to"},{"line_number":3254,"context_line":"                      occur."},{"line_number":3255,"context_line":""},{"line_number":3256,"context_line":"        :returns: True if the IP address has been deleted, False if the IP"},{"line_number":3257,"context_line":"                  address was not found."}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_7e7b8e8c","line":3254,"updated":"2016-04-19 18:14:57.000000000","message":"The obvious first question is \"why is 2 the default?\"  I think we should mention that here.","commit_id":"344ec093b166d41cd289d593cc781fed5fb2a13e"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"3849dec8ea04f46913e8439308f2a07a2c67886d","unresolved":false,"context_lines":[{"line_number":3258,"context_line":""},{"line_number":3259,"context_line":"        :raises: ``OpenStackCloudException``, on operation error."},{"line_number":3260,"context_line":"        \"\"\""},{"line_number":3261,"context_line":"        for count in range(0, retry + 1):"},{"line_number":3262,"context_line":"            result \u003d self._delete_floating_ip(floating_ip_id)"},{"line_number":3263,"context_line":""},{"line_number":3264,"context_line":"            if not retry or not result:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_1e441a48","line":3261,"updated":"2016-04-19 18:14:57.000000000","message":"This will execute one more time than requested:\n\n   range(0,3) \u003d [0,1,2]","commit_id":"344ec093b166d41cd289d593cc781fed5fb2a13e"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"7cb225a826fd05fd664d8beb47bbbd507bda747b","unresolved":false,"context_lines":[{"line_number":3258,"context_line":""},{"line_number":3259,"context_line":"        :raises: ``OpenStackCloudException``, on operation error."},{"line_number":3260,"context_line":"        \"\"\""},{"line_number":3261,"context_line":"        for count in range(0, retry + 1):"},{"line_number":3262,"context_line":"            result \u003d self._delete_floating_ip(floating_ip_id)"},{"line_number":3263,"context_line":""},{"line_number":3264,"context_line":"            if not retry or not result:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_5ee4d2aa","line":3261,"in_reply_to":"1a122d0e_1e441a48","updated":"2016-04-19 18:27:33.000000000","message":"I think the idea is it will always run once, then retry 2 more times. This means you do 2 + 1 \u003d 3 total attempts.\n\nHowever we should do retry \u003d max(0, retry) before we do this maths to avoid negative values.","commit_id":"344ec093b166d41cd289d593cc781fed5fb2a13e"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"3623752bd02208ff4a95b37db94f2424f47c0de7","unresolved":false,"context_lines":[{"line_number":3258,"context_line":""},{"line_number":3259,"context_line":"        :raises: ``OpenStackCloudException``, on operation error."},{"line_number":3260,"context_line":"        \"\"\""},{"line_number":3261,"context_line":"        for count in range(0, retry + 1):"},{"line_number":3262,"context_line":"            result \u003d self._delete_floating_ip(floating_ip_id)"},{"line_number":3263,"context_line":""},{"line_number":3264,"context_line":"            if not retry or not result:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_01caff4d","line":3261,"in_reply_to":"1a122d0e_5ee4d2aa","updated":"2016-04-19 18:43:57.000000000","message":"Yeah, I totally misinterpreted the parameter as \"number of attempts\" and not \"retries after initial\". Disregard all of my comments on this PS.","commit_id":"344ec093b166d41cd289d593cc781fed5fb2a13e"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"3849dec8ea04f46913e8439308f2a07a2c67886d","unresolved":false,"context_lines":[{"line_number":3261,"context_line":"        for count in range(0, retry + 1):"},{"line_number":3262,"context_line":"            result \u003d self._delete_floating_ip(floating_ip_id)"},{"line_number":3263,"context_line":""},{"line_number":3264,"context_line":"            if not retry or not result:"},{"line_number":3265,"context_line":"                return result"},{"line_number":3266,"context_line":""},{"line_number":3267,"context_line":"            f_ip \u003d self.get_floating_ip(id\u003dfloating_ip_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_fef83ec5","line":3264,"updated":"2016-04-19 18:14:57.000000000","message":"\"not retry\"?  I do not think that means what you think it means.  :)  If retry is zero, we\u0027ll never even get inside this loop.","commit_id":"344ec093b166d41cd289d593cc781fed5fb2a13e"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"7cb225a826fd05fd664d8beb47bbbd507bda747b","unresolved":false,"context_lines":[{"line_number":3261,"context_line":"        for count in range(0, retry + 1):"},{"line_number":3262,"context_line":"            result \u003d self._delete_floating_ip(floating_ip_id)"},{"line_number":3263,"context_line":""},{"line_number":3264,"context_line":"            if not retry or not result:"},{"line_number":3265,"context_line":"                return result"},{"line_number":3266,"context_line":""},{"line_number":3267,"context_line":"            f_ip \u003d self.get_floating_ip(id\u003dfloating_ip_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_5efb3247","line":3264,"in_reply_to":"1a122d0e_fef83ec5","updated":"2016-04-19 18:27:33.000000000","message":"See comment above. This is necessary to deal with the logic in use there.","commit_id":"344ec093b166d41cd289d593cc781fed5fb2a13e"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"3849dec8ea04f46913e8439308f2a07a2c67886d","unresolved":false,"context_lines":[{"line_number":3274,"context_line":"            \" the floating ip is still in existence. Aborting further\""},{"line_number":3275,"context_line":"            \" operations.\".format("},{"line_number":3276,"context_line":"                id\u003dfloating_ip_id, ip\u003df_ip[\u0027floating_ip_address\u0027],"},{"line_number":3277,"context_line":"                retry\u003dretry + 1))"},{"line_number":3278,"context_line":""},{"line_number":3279,"context_line":"    def _delete_floating_ip(self, floating_ip_id):"},{"line_number":3280,"context_line":"        if self.has_service(\u0027network\u0027) and not self._use_nova_floating():"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_feae7ee4","line":3277,"updated":"2016-04-19 18:14:57.000000000","message":"I don\u0027t think you want retry+1 here, since that will not report the incorrect number of retries.","commit_id":"344ec093b166d41cd289d593cc781fed5fb2a13e"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"9b94974591ce6089a7f1d66f312d7717ffe49975","unresolved":false,"context_lines":[{"line_number":3264,"context_line":"            if (retry \u003d\u003d 0) or not result:"},{"line_number":3265,"context_line":"                return result"},{"line_number":3266,"context_line":""},{"line_number":3267,"context_line":"            f_ip \u003d self.get_floating_ip(id\u003dfloating_ip_id)"},{"line_number":3268,"context_line":"            if not f_ip:"},{"line_number":3269,"context_line":"                return True"},{"line_number":3270,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1a122d0e_834c4f9f","line":3267,"updated":"2016-04-19 21:30:15.000000000","message":"I think we should add a comment here mentioning the Neutron bug that can cause our code to return True on a delete, and it not really being deleted, thus the need for this block of code to recheck.","commit_id":"340f93f049fa70168bffb8a1905ad09849943726"}]}
