)]}'
{"shade/_utils.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"45f23baf95e24ac5e9e06ed4da12db20d876283a","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            network\u003dnetwork_id,"},{"line_number":324,"context_line":"            floating_network_id\u003dnetwork_id,"},{"line_number":325,"context_line":"            port_id\u003dip.get(\u0027port_id\u0027),"},{"line_number":326,"context_line":"            router_id\u003dip.get(\u0027router_id\u0027),"},{"line_number":327,"context_line":"            attached\u003d(ip.get(\u0027port_id\u0027) is not None and"},{"line_number":328,"context_line":"                      ip.get(\u0027port_id\u0027) !\u003d \u0027\u0027),"},{"line_number":329,"context_line":"            status\u003dip[\u0027status\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_1fb819e5","line":326,"updated":"2016-04-21 18:03:04.000000000","message":"According to a paste you gave me earlier, the port_id and router_id do not show up in a list operation. If these are None as we report them from the list op, wouldn\u0027t that be misleading (since they likely should have real values, but we just don\u0027t have them)?","commit_id":"01acfd8f98bea218d5ca5ab480d87ea2e44c565c"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"ac171689af0a4dbe4b35d84c3c9bf44e34a187b8","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            network\u003dnetwork_id,"},{"line_number":324,"context_line":"            floating_network_id\u003dnetwork_id,"},{"line_number":325,"context_line":"            port_id\u003dip.get(\u0027port_id\u0027),"},{"line_number":326,"context_line":"            router_id\u003dip.get(\u0027router_id\u0027),"},{"line_number":327,"context_line":"            attached\u003d(ip.get(\u0027port_id\u0027) is not None and"},{"line_number":328,"context_line":"                      ip.get(\u0027port_id\u0027) !\u003d \u0027\u0027),"},{"line_number":329,"context_line":"            status\u003dip[\u0027status\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_9a19d77c","line":326,"in_reply_to":"1a122d0e_1fb819e5","updated":"2016-04-21 18:25:58.000000000","message":"NM. We get these back, we were just ignoring them.","commit_id":"01acfd8f98bea218d5ca5ab480d87ea2e44c565c"}],"shade/openstackcloud.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"668a76f90178bdcfecb0aae5e78b4c9c06b50e68","unresolved":false,"context_lines":[{"line_number":3243,"context_line":"                        \"Attempted to create FIP on port {port} for server\""},{"line_number":3244,"context_line":"                        \" {server} but something went wrong\".format("},{"line_number":3245,"context_line":"                            port\u003dport[\u0027id\u0027], server\u003dserver[\u0027id\u0027]))"},{"line_number":3246,"context_line":"                if wait:"},{"line_number":3247,"context_line":"                    for count in _utils._iterate_timeout("},{"line_number":3248,"context_line":"                            timeout,"},{"line_number":3249,"context_line":"                            \"Timeout waiting for the floating IP\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_f44bc45d","line":3246,"updated":"2016-04-21 17:36:25.000000000","message":"If the active state happens without attaching a floating IP we should move this wait outside of the if port block. If it only happens when the ip is attached to a server port we should document that here as the reason we wait for active only when attaching. Also the function docstring is incorrect if this is the case and should be updated as well.","commit_id":"46c889059f2454538336d33b92da50d4cc199fca"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"668a76f90178bdcfecb0aae5e78b4c9c06b50e68","unresolved":false,"context_lines":[{"line_number":3646,"context_line":""},{"line_number":3647,"context_line":"        return self._attach_ip_to_server("},{"line_number":3648,"context_line":"            server\u003dserver, floating_ip\u003df_ip, fixed_address\u003dfixed_address,"},{"line_number":3649,"context_line":"            wait\u003dwait, timeout\u003dtimeout)"},{"line_number":3650,"context_line":""},{"line_number":3651,"context_line":"    def add_ip_list("},{"line_number":3652,"context_line":"            self, server, ips, wait\u003dFalse, timeout\u003d60,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_549278a0","line":3649,"updated":"2016-04-21 17:36:25.000000000","message":"I am confused at why we would need to attach the ip to the server in a second call here when we can just do it as part of the floating ip creation above. Doing so would negate the need for this timeout math.","commit_id":"46c889059f2454538336d33b92da50d4cc199fca"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"668a76f90178bdcfecb0aae5e78b4c9c06b50e68","unresolved":false,"context_lines":[{"line_number":3719,"context_line":"            created \u003d True"},{"line_number":3720,"context_line":""},{"line_number":3721,"context_line":"        try:"},{"line_number":3722,"context_line":"            return self._attach_ip_to_server("},{"line_number":3723,"context_line":"                server\u003dserver, floating_ip\u003df_ip, wait\u003dwait, timeout\u003dtimeout,"},{"line_number":3724,"context_line":"                skip_attach\u003dskip_attach)"},{"line_number":3725,"context_line":"        except OpenStackCloudTimeout:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_14f760f6","line":3722,"updated":"2016-04-21 17:36:25.000000000","message":"See above.","commit_id":"46c889059f2454538336d33b92da50d4cc199fca"}]}