)]}'
{"shade/_tasks.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"5de0c5c6c4358aeda4ebec04cc2bd94cb0386aed","unresolved":false,"context_lines":[{"line_number":881,"context_line":""},{"line_number":882,"context_line":"class MagnumServicesList(task_manager.Task):"},{"line_number":883,"context_line":"    def main(self, client):"},{"line_number":884,"context_line":"        return client.magnum_client.mservices.list(detail\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_0f2bc6ec","line":884,"updated":"2016-05-27 16:36:10.000000000","message":"Do you not want to allow \u0027detail\u0027 to be a passed argument value? Or is the intention to always keep it as False?","commit_id":"a641379084731911519a7cf31b34684779cb34c4"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"7c2468ba9066d986439af7141a87be280a119d67","unresolved":false,"context_lines":[{"line_number":881,"context_line":""},{"line_number":882,"context_line":"class MagnumServicesList(task_manager.Task):"},{"line_number":883,"context_line":"    def main(self, client):"},{"line_number":884,"context_line":"        return client.magnum_client.mservices.list(detail\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_2b94bd35","line":884,"in_reply_to":"9abb7d3a_0f2bc6ec","updated":"2016-05-27 16:52:54.000000000","message":"At the moment the API returns the same for detail\u003dFalse or True. So just forcing to be false is ok","commit_id":"a641379084731911519a7cf31b34684779cb34c4"}],"shade/openstackcloud.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"5de0c5c6c4358aeda4ebec04cc2bd94cb0386aed","unresolved":false,"context_lines":[{"line_number":5656,"context_line":"        \"\"\"List all Magnum services."},{"line_number":5657,"context_line":"        :returns: a list of dicts containing the service details."},{"line_number":5658,"context_line":""},{"line_number":5659,"context_line":"        :raises: ``utils.shade_exceptions``: if something goes wrong during"},{"line_number":5660,"context_line":"            the openstack API call."},{"line_number":5661,"context_line":"        \"\"\""},{"line_number":5662,"context_line":"        with _utils.shade_exceptions(\"Error fetching Magnum services list\"):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_efbac2bf","line":5659,"updated":"2016-05-27 16:36:10.000000000","message":"A context manager is certainly NOT raised here.  :)","commit_id":"a641379084731911519a7cf31b34684779cb34c4"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"99206e18a4b7c90d19c5e64fb159c1325553562b","unresolved":false,"context_lines":[{"line_number":5656,"context_line":"        \"\"\"List all Magnum services."},{"line_number":5657,"context_line":"        :returns: a list of dicts containing the service details."},{"line_number":5658,"context_line":""},{"line_number":5659,"context_line":"        :raises: ``utils.shade_exceptions``: if something goes wrong during"},{"line_number":5660,"context_line":"            the openstack API call."},{"line_number":5661,"context_line":"        \"\"\""},{"line_number":5662,"context_line":"        with _utils.shade_exceptions(\"Error fetching Magnum services list\"):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_51829053","line":5659,"updated":"2016-05-27 17:31:48.000000000","message":"Still need to correct this to be OpenStackCloudException and not the context manager being returned.","commit_id":"78f245fdec94232e464e4f0b22f09b9aa2c7ba7d"}],"shade/tests/functional/test_magnum_services.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"5de0c5c6c4358aeda4ebec04cc2bd94cb0386aed","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        # Test that we can list services"},{"line_number":36,"context_line":"        services \u003d self.operator_cloud.list_magnum_services()"},{"line_number":37,"context_line":"        self.assertIsNotNone(services)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_cf209efa","line":37,"updated":"2016-05-27 16:36:10.000000000","message":"Would be nice if we could test for some specific values other than None. Perhaps that is a change for later, though.","commit_id":"a641379084731911519a7cf31b34684779cb34c4"}]}