)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"f558207c2a228fde429fb10828528a02d42656a8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add floating IPs to server dict ourselves"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The nova/neutron interaction as it relates to updating the network info"},{"line_number":10,"context_line":"cache in nova apparently does not believe in an object reality and"},{"line_number":11,"context_line":"instead prefers to think of things as unrealized quantum superpositions."},{"line_number":12,"context_line":"While those are great for particle physics, they make getting the"},{"line_number":13,"context_line":"address of the server hard. It therefore follows that we should"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dab17558_021714ee","line":10,"updated":"2016-05-12 18:44:34.000000000","message":"In another universe, you wrote \"objective\" here.","commit_id":"96f41298ca801648272ffa6e5cb7092d971b9fee"}],"shade/meta.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"40814b0a48c10107aaca0915d8f83645b4c13ab4","unresolved":false,"context_lines":[{"line_number":282,"context_line":"    address[\u0027OS-EXT-IPS:type\u0027] \u003d \u0027floating\u0027"},{"line_number":283,"context_line":"    # MAC address comes from the port, not the FIP. It also doesn\u0027t matter"},{"line_number":284,"context_line":"    # to anyone at the moment, so just make a fake one"},{"line_number":285,"context_line":"    address[\u0027OS-EXT-IPS-MAC:mac_addr\u0027] \u003d \u0027de:ad:be:ef:be:ef\u0027"},{"line_number":286,"context_line":"    return address"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_f6f0d5cb","line":285,"updated":"2016-05-12 19:24:18.000000000","message":"I think de mac prefix is unassigned even.","commit_id":"96f41298ca801648272ffa6e5cb7092d971b9fee"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"f558207c2a228fde429fb10828528a02d42656a8","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"def _get_suplemental_addresses(cloud, server):"},{"line_number":290,"context_line":"    fixed_ips \u003d []"},{"line_number":291,"context_line":"    fixed_ip_mapping \u003d {}"},{"line_number":292,"context_line":"    for name, network in server[\u0027addresses\u0027].items():"},{"line_number":293,"context_line":"        for address in network:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_62d26036","line":290,"updated":"2016-05-12 18:44:34.000000000","message":"You don\u0027t need this list...","commit_id":"96f41298ca801648272ffa6e5cb7092d971b9fee"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"f558207c2a228fde429fb10828528a02d42656a8","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            fixed_ips.append(address[\u0027addr\u0027])"},{"line_number":300,"context_line":"            fixed_ip_mapping[address[\u0027addr\u0027]] \u003d name"},{"line_number":301,"context_line":"    for fip in cloud.list_floating_ips():"},{"line_number":302,"context_line":"        if fip[\u0027fixed_ip_address\u0027] in fixed_ips:"},{"line_number":303,"context_line":"            fixed_net \u003d fixed_ip_mapping[fip[\u0027fixed_ip_address\u0027]]"},{"line_number":304,"context_line":"            server[\u0027addresses\u0027][fixed_net].append(_make_address_dict(fip))"},{"line_number":305,"context_line":"    return server[\u0027addresses\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_42d75c23","line":302,"updated":"2016-05-12 18:44:34.000000000","message":"...because the only time you use it is here, and this will work just as well by substituting fixed_ip_mapping.","commit_id":"96f41298ca801648272ffa6e5cb7092d971b9fee"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"40814b0a48c10107aaca0915d8f83645b4c13ab4","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    for fip in cloud.list_floating_ips():"},{"line_number":302,"context_line":"        if fip[\u0027fixed_ip_address\u0027] in fixed_ips:"},{"line_number":303,"context_line":"            fixed_net \u003d fixed_ip_mapping[fip[\u0027fixed_ip_address\u0027]]"},{"line_number":304,"context_line":"            server[\u0027addresses\u0027][fixed_net].append(_make_address_dict(fip))"},{"line_number":305,"context_line":"    return server[\u0027addresses\u0027]"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_796df6cb","line":304,"updated":"2016-05-12 19:24:18.000000000","message":"Does the FIP know which network it belongs too and does it make sense to set the network to that name in the addresses dict? Or is this the datastructure used when nova and neutron function properly?","commit_id":"96f41298ca801648272ffa6e5cb7092d971b9fee"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"3fd3cf311603968537611e6e4aa41c717e3e3e14","unresolved":false,"context_lines":[{"line_number":282,"context_line":"    address[\u0027OS-EXT-IPS:type\u0027] \u003d \u0027floating\u0027"},{"line_number":283,"context_line":"    # MAC address comes from the port, not the FIP. It also doesn\u0027t matter"},{"line_number":284,"context_line":"    # to anyone at the moment, so just make a fake one"},{"line_number":285,"context_line":"    address[\u0027OS-EXT-IPS-MAC:mac_addr\u0027] \u003d \u0027de:ad:be:ef:be:ef\u0027"},{"line_number":286,"context_line":"    return address"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_0e833057","line":285,"updated":"2016-07-12 16:08:33.000000000","message":"mmm, tasty beef","commit_id":"7dd138c8f4c8b8761b0b50d3ce9c7c4f770f8c61"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"3fd3cf311603968537611e6e4aa41c717e3e3e14","unresolved":false,"context_lines":[{"line_number":286,"context_line":"    return address"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"def _get_suplemental_addresses(cloud, server):"},{"line_number":290,"context_line":"    fixed_ip_mapping \u003d {}"},{"line_number":291,"context_line":"    for name, network in server[\u0027addresses\u0027].items():"},{"line_number":292,"context_line":"        for address in network:"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_b37b65bd","line":289,"updated":"2016-07-12 16:08:33.000000000","message":"nit: s/suplemental/supplemental/  or a more easily spelled word  :)","commit_id":"7dd138c8f4c8b8761b0b50d3ce9c7c4f770f8c61"}]}
