)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"deadd2c413437275eba69e36651b74275c441ac9","unresolved":false,"context_lines":[{"line_number":5556,"context_line":"        return True"},{"line_number":5557,"context_line":""},{"line_number":5558,"context_line":"    @_utils.cache_on_arguments()"},{"line_number":5559,"context_line":"    def list_bay_pods(self, bay_uuid, detail\u003dFalse):"},{"line_number":5560,"context_line":"        \"\"\"List Magnum bay pods."},{"line_number":5561,"context_line":""},{"line_number":5562,"context_line":"        :param string bay_uuid. String to indicate the bay uuid"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_83f6ee5a","line":5559,"updated":"2016-05-16 14:29:18.000000000","message":"detail is unused.","commit_id":"d5d338d0b292fc9ab3909d97198a4d6c5f9b48c2"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"deadd2c413437275eba69e36651b74275c441ac9","unresolved":false,"context_lines":[{"line_number":5604,"context_line":"                }"},{"line_number":5605,"context_line":""},{"line_number":5606,"context_line":"        :returns: A volume dict or None if no matching pod is"},{"line_number":5607,"context_line":"        found."},{"line_number":5608,"context_line":""},{"line_number":5609,"context_line":"        \"\"\""},{"line_number":5610,"context_line":"        if hasattr(name_or_id, \u0027id\u0027):"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_e3c7fa0f","line":5607,"updated":"2016-05-16 14:29:18.000000000","message":"nit: indent following text for proper formatting\n\nhttp://docs-draft.openstack.org/50/316650/7/check/gate-shade-docs/7c90e72//doc/build/html/usage.html#shade.OpenStackCloud.get_bay_pod","commit_id":"d5d338d0b292fc9ab3909d97198a4d6c5f9b48c2"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"deadd2c413437275eba69e36651b74275c441ac9","unresolved":false,"context_lines":[{"line_number":5608,"context_line":""},{"line_number":5609,"context_line":"        \"\"\""},{"line_number":5610,"context_line":"        if hasattr(name_or_id, \u0027id\u0027):"},{"line_number":5611,"context_line":"            return name_or_id"},{"line_number":5612,"context_line":""},{"line_number":5613,"context_line":"        entities \u003d self.search_bay_pods(bay_uuid, name_or_id,"},{"line_number":5614,"context_line":"                                        filters\u003dfilters)"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_c3091697","line":5611,"updated":"2016-05-16 14:29:18.000000000","message":"I don\u0027t think I like this from a consistency view point. All of our other name_or_id params are pure strings. None of them allow objects.","commit_id":"d5d338d0b292fc9ab3909d97198a4d6c5f9b48c2"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"deadd2c413437275eba69e36651b74275c441ac9","unresolved":false,"context_lines":[{"line_number":5632,"context_line":"            the openstack API call"},{"line_number":5633,"context_line":"        \"\"\""},{"line_number":5634,"context_line":""},{"line_number":5635,"context_line":"        self.list_bay_pods.invalidate(self)"},{"line_number":5636,"context_line":"        with _utils.shade_exceptions("},{"line_number":5637,"context_line":"                \"Error creating pod for bay {bay_uuid}\".format("},{"line_number":5638,"context_line":"                    bay_uuid\u003dbay_uuid)):"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_e674289d","line":5635,"updated":"2016-05-16 14:29:18.000000000","message":"This invalidate() seems unnecessary.","commit_id":"d5d338d0b292fc9ab3909d97198a4d6c5f9b48c2"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"deadd2c413437275eba69e36651b74275c441ac9","unresolved":false,"context_lines":[{"line_number":5659,"context_line":"        if not bay_pod:"},{"line_number":5660,"context_line":"            self.log.debug("},{"line_number":5661,"context_line":"                \"Bay pod {name_or_id} does not exist\".format("},{"line_number":5662,"context_line":"                    bay_uuid\u003dbay_uuid,"},{"line_number":5663,"context_line":"                    name_or_id\u003dname_or_id),"},{"line_number":5664,"context_line":"                exc_info\u003dTrue)"},{"line_number":5665,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_26791083","line":5662,"updated":"2016-05-16 14:29:18.000000000","message":"bay_uuid is not referenced in the string.","commit_id":"d5d338d0b292fc9ab3909d97198a4d6c5f9b48c2"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"deadd2c413437275eba69e36651b74275c441ac9","unresolved":false,"context_lines":[{"line_number":5691,"context_line":"        :returns: a dict representing the updated bay pod."},{"line_number":5692,"context_line":""},{"line_number":5693,"context_line":"        :raises: OpenStackCloudException on operation error."},{"line_number":5694,"context_line":"        \"\"\""},{"line_number":5695,"context_line":"        bay_pod \u003d self.get_bay_pod(bay_uuid, name_or_id)"},{"line_number":5696,"context_line":"        if not bay_pod:"},{"line_number":5697,"context_line":"            raise OpenStackCloudException("}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_260c70eb","line":5694,"updated":"2016-05-16 14:29:18.000000000","message":"You should invalidate your cache here to make sure the bay still exists before attempting the update.","commit_id":"d5d338d0b292fc9ab3909d97198a4d6c5f9b48c2"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"deadd2c413437275eba69e36651b74275c441ac9","unresolved":false,"context_lines":[{"line_number":5702,"context_line":"                \"%s operation not in \u0027add\u0027, \u0027replace\u0027, \u0027remove\u0027\" % operation)"},{"line_number":5703,"context_line":""},{"line_number":5704,"context_line":"        patches \u003d _utils.generate_patches_from_kwargs(operation, **kwargs)"},{"line_number":5705,"context_line":"        self.list_bay_pods.invalidate(self)"},{"line_number":5706,"context_line":""},{"line_number":5707,"context_line":"        with _utils.shade_exceptions("},{"line_number":5708,"context_line":"                \"Error updating bay pod {0}\".format(name_or_id)):"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_6621584d","line":5705,"updated":"2016-05-16 14:29:18.000000000","message":"Move this invalidate() to the top of the method.","commit_id":"d5d338d0b292fc9ab3909d97198a4d6c5f9b48c2"}]}
