)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"a5139550b0f342463b06bd1f4fb34ff23ce8e855","unresolved":false,"context_lines":[{"line_number":4302,"context_line":"                        extra_data\u003ddict(server\u003dserver))"},{"line_number":4303,"context_line":"        return server"},{"line_number":4304,"context_line":""},{"line_number":4305,"context_line":"    def server_set_metadata(self, name_or_id, metadata):"},{"line_number":4306,"context_line":"        \"\"\"Set metadata in a server instance."},{"line_number":4307,"context_line":""},{"line_number":4308,"context_line":"        :param str name_or_id: The name or id of the server instance"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_f85aa029","line":4305,"updated":"2016-06-02 09:57:47.000000000","message":"I\u0027ve tested this on a devstack instance and works.\n\nHowever, please change the method names to \u0027set_server_metadata\u0027, to follow the action+resource pattern of other methods.\n\n(Yeah, I know the _tasks are reverse :/ ).","commit_id":"a85e418f901c44fa21022c31097577c35b398cbb"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"ed93ca8e2c9c3fc1623e765a0e3822074dde1d25","unresolved":false,"context_lines":[{"line_number":4302,"context_line":"                        extra_data\u003ddict(server\u003dserver))"},{"line_number":4303,"context_line":"        return server"},{"line_number":4304,"context_line":""},{"line_number":4305,"context_line":"    def set_metadata_server(self, name_or_id, metadata):"},{"line_number":4306,"context_line":"        \"\"\"Set metadata in a server instance."},{"line_number":4307,"context_line":""},{"line_number":4308,"context_line":"        :param str name_or_id: The name or id of the server instance"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_22045d48","line":4305,"updated":"2016-06-13 13:59:26.000000000","message":"Please note, this is actually more confusing than before. It needs to be \"set_server_metadata\" not \"set_metadata_server\". The action here is setting the server\u0027s metadata. Otherwise it feels like you\u0027re saying \"set the metadata server\", as if you can change the URL for a server\u0027s metadata service.","commit_id":"a7030bcabb8e0f9eff527b5931421e73abf296d7"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"ed93ca8e2c9c3fc1623e765a0e3822074dde1d25","unresolved":false,"context_lines":[{"line_number":4306,"context_line":"        \"\"\"Set metadata in a server instance."},{"line_number":4307,"context_line":""},{"line_number":4308,"context_line":"        :param str name_or_id: The name or id of the server instance"},{"line_number":4309,"context_line":"            to update."},{"line_number":4310,"context_line":"        :param dict metadata: A dictionary with the key\u003dvalue pairs"},{"line_number":4311,"context_line":"            to set in the server instance."},{"line_number":4312,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_02016138","line":4309,"updated":"2016-06-13 13:59:26.000000000","message":"So, these, and delete_server, are the only server methods that take name_or_id. That seems rather odd. I\u0027m not sure this patch is wrong, but why do some things take a \u0027server\u0027 object, and others take a \u0027name_or_id\u0027, and others take a \u0027server_id\u0027? I think this might need discussion on a broader scale, but I really would like to know why, say, rebuild, takes a server dict, but delete takes name_or_id. Anyway, this isn\u0027t the reason for a -1, just something trying to start conversation.","commit_id":"a7030bcabb8e0f9eff527b5931421e73abf296d7"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"24ac83c1a7dbeafd588430c0246b58764bfbdfe7","unresolved":false,"context_lines":[{"line_number":4306,"context_line":"        \"\"\"Set metadata in a server instance."},{"line_number":4307,"context_line":""},{"line_number":4308,"context_line":"        :param str name_or_id: The name or id of the server instance"},{"line_number":4309,"context_line":"            to update."},{"line_number":4310,"context_line":"        :param dict metadata: A dictionary with the key\u003dvalue pairs"},{"line_number":4311,"context_line":"            to set in the server instance."},{"line_number":4312,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_ff61a0a9","line":4309,"in_reply_to":"7aa08908_02016138","updated":"2016-06-22 17:59:14.000000000","message":"I think name_or_id is fine. It\u0027s a pattern used in MANY of our API calls (more than just these and delete_server). I sort of hate that pattern myself now, but it is what it is.","commit_id":"a7030bcabb8e0f9eff527b5931421e73abf296d7"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"ed93ca8e2c9c3fc1623e765a0e3822074dde1d25","unresolved":false,"context_lines":[{"line_number":4308,"context_line":"        :param str name_or_id: The name or id of the server instance"},{"line_number":4309,"context_line":"            to update."},{"line_number":4310,"context_line":"        :param dict metadata: A dictionary with the key\u003dvalue pairs"},{"line_number":4311,"context_line":"            to set in the server instance."},{"line_number":4312,"context_line":""},{"line_number":4313,"context_line":"        :raises: OpenStackCloudException on operation error."},{"line_number":4314,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_62fae544","line":4311,"updated":"2016-06-13 13:59:26.000000000","message":"We need to be explicit on whether or not it updates existing metadata or replaces the whole metadata mapping.","commit_id":"a7030bcabb8e0f9eff527b5931421e73abf296d7"}]}