)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"cc423b5d7d2dbeaffe084df5712f5c8d0d2ac989","unresolved":false,"context_lines":[{"line_number":4621,"context_line":"    def create_object("},{"line_number":4622,"context_line":"            self, container, name, filename\u003dNone,"},{"line_number":4623,"context_line":"            md5\u003dNone, sha256\u003dNone, segment_size\u003dNone,"},{"line_number":4624,"context_line":"            use_slo\u003dTrue, metadata\u003d{},"},{"line_number":4625,"context_line":"            **headers):"},{"line_number":4626,"context_line":"        \"\"\"Create a file object"},{"line_number":4627,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_c10d70e9","line":4624,"range":{"start_line":4624,"start_character":35,"end_line":4624,"end_character":37},"updated":"2016-05-26 22:09:47.000000000","message":"You may want to use None here and initialize the dict in the method. Since metadata isn\u0027t modified, it doesn\u0027t matter right now, but if in the future this code modifies it, those modifications would be persisted for the next caller that didn\u0027t explicitly pass in metadata.","commit_id":"5b53887a0838b9baad1118da824d01255b3964ab"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"cc423b5d7d2dbeaffe084df5712f5c8d0d2ac989","unresolved":false,"context_lines":[{"line_number":4674,"context_line":"            for r in self.manager.submitTask(_tasks.ObjectCreate("},{"line_number":4675,"context_line":"                    container\u003dcontainer, objects\u003d[upload],"},{"line_number":4676,"context_line":"                    options\u003ddict("},{"line_number":4677,"context_line":"                        header\u003dheader_list,"},{"line_number":4678,"context_line":"                        segment_size\u003dsegment_size,"},{"line_number":4679,"context_line":"                        use_slo\u003duse_slo))):"},{"line_number":4680,"context_line":"                if not r[\u0027success\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_a1278c61","line":4677,"updated":"2016-05-26 22:09:47.000000000","message":"Instead of modifying header_list yourself, you could just add\n\n meta\u003dmetadata,\n\nhere.","commit_id":"5b53887a0838b9baad1118da824d01255b3964ab"},{"author":{"_account_id":18061,"name":"Caleb Boylan","email":"caleb.boylan@ormuco.com","username":"calebb"},"change_message_id":"524b972864091e8dbea77736e59f230526715c6f","unresolved":false,"context_lines":[{"line_number":4674,"context_line":"            for r in self.manager.submitTask(_tasks.ObjectCreate("},{"line_number":4675,"context_line":"                    container\u003dcontainer, objects\u003d[upload],"},{"line_number":4676,"context_line":"                    options\u003ddict("},{"line_number":4677,"context_line":"                        header\u003dheader_list,"},{"line_number":4678,"context_line":"                        segment_size\u003dsegment_size,"},{"line_number":4679,"context_line":"                        use_slo\u003duse_slo))):"},{"line_number":4680,"context_line":"                if not r[\u0027success\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_c7246061","line":4677,"in_reply_to":"bab6814e_a1278c61","updated":"2016-05-26 23:26:16.000000000","message":"It doesnt seem to work when I do that or when I set meta to a list generated from metadata (the same way header_list is generated), doesn\u0027t throw any syntax errors but when i use get_object the metadata is missing...","commit_id":"5b53887a0838b9baad1118da824d01255b3964ab"}],"shade/tests/functional/test_object.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"0678c20a5e9ee17c4e308425018f42818640b573","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                    sparse_file.name"},{"line_number":63,"context_line":"                    )"},{"line_number":64,"context_line":"                )"},{"line_number":65,"context_line":"            self.assertIsNotNone("},{"line_number":66,"context_line":"                self.demo_cloud.get_object_metadata(container_name, name))"},{"line_number":67,"context_line":"            self.assertIsNotNone("},{"line_number":68,"context_line":"                self.demo_cloud.get_object(container_name, name))"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_c7e620af","line":65,"updated":"2016-05-26 23:51:27.000000000","message":"Speaking of not having the expected metadata - this seems like a pretty loose assertion...","commit_id":"519a9e3f832b89380fbcc0fae90ad72843ab4781"}]}
