)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a6314feeddab87f5c120b2aeadc7061a1ec36e01","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow to register nodes from file"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Modified the register_nodes function to allow registering nodes"},{"line_number":10,"context_line":"from given json file."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id15c28988f33eaf2fe2023e0a0b6d68cb6d09697"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dada55a8_b41dbbbf","line":10,"range":{"start_line":9,"start_character":40,"end_line":10,"end_character":21},"updated":"2016-07-18 12:36:32.000000000","message":"Nit: The commit message does not quite match what the proposed change is doing.","commit_id":"c5a006274eddac05172cc3be2cfdf393361af965"}],"releasenotes/notes/node-register-from-file-4e187f7da1579db7.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a6314feeddab87f5c120b2aeadc7061a1ec36e01","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add support for registering nodes with ironic, from file with"},{"line_number":4,"context_line":"    nodes information in json format."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dada55a8_547c3f72","line":3,"range":{"start_line":3,"start_character":19,"end_line":3,"end_character":49},"updated":"2016-07-18 12:36:32.000000000","message":"s/registering nodes with ironic/registering a node\u0027s network information with a json file/ ?\n\nAt present, looking at the feature note that would be generated, it would imply to me that I can feed a json data structure of the node to the method and a node gets registered, but in the case of the code it does not.","commit_id":"c5a006274eddac05172cc3be2cfdf393361af965"}],"shade/operatorcloud.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"5a5ef9d3a8833a1441fa00fdd8ff25c887df2b31","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            return(machine)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def register_machine(self, nics, json_file\u003dNone, wait\u003dFalse, timeout\u003d3600,"},{"line_number":179,"context_line":"                         lock_timeout\u003d600, **kwargs):"},{"line_number":180,"context_line":"        \"\"\"Register Baremetal with Ironic"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        Allows for the registration of Baremetal nodes with Ironic"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_8801ef08","line":179,"updated":"2016-07-06 13:45:57.000000000","message":"New params need to added to the end of named parameter list, otherwise you break the current API.","commit_id":"4b9e9a27969cce84ed46a2e00f55ece4026d6409"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"37f290fdeb15b176a4cf8630d4ec4d122f8447e9","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                nodes_data \u003d json.load(nodes_f)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"                for node in nodes_data[\u0027nodes\u0027]:"},{"line_number":235,"context_line":"                    nics.append({\u0027mac\u0027: str(node[\u0027mac\u0027][0])})"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        created_nics \u003d []"},{"line_number":238,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_6818fe75","line":235,"updated":"2016-07-06 14:43:01.000000000","message":"You need to move this entire block within the shade_exceptions() context manager so no non-shade exceptions are thrown.\n\nPlease check out our coding standards doc: http://docs.openstack.org/infra/shade/coding.html","commit_id":"4b9e9a27969cce84ed46a2e00f55ece4026d6409"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a6314feeddab87f5c120b2aeadc7061a1ec36e01","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            return(machine)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def register_machine(self, nics, wait\u003dFalse, timeout\u003d3600,"},{"line_number":179,"context_line":"                         lock_timeout\u003d600, json_file\u003dNone, **kwargs):"},{"line_number":180,"context_line":"        \"\"\"Register Baremetal with Ironic"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        Allows for the registration of Baremetal nodes with Ironic"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_14880722","line":179,"range":{"start_line":179,"start_character":43,"end_line":179,"end_character":52},"updated":"2016-07-18 12:36:32.000000000","message":"json_file seems a little misleading to me in.  Perhaps network_json or nics_json? or nics_json_file?","commit_id":"c5a006274eddac05172cc3be2cfdf393361af965"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a6314feeddab87f5c120b2aeadc7061a1ec36e01","unresolved":false,"context_lines":[{"line_number":201,"context_line":"              ]"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        :param json_file: String value, defaulting to None, for loading nodes"},{"line_number":204,"context_line":"                          network information from json file."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        :param wait: Boolean value, defaulting to false, to wait for the"},{"line_number":207,"context_line":"                     node to reach the available state where the node can be"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_d92fc89f","line":204,"updated":"2016-07-18 12:36:32.000000000","message":"It would be helpful to provide an example of the json data structure for a user of this method.","commit_id":"c5a006274eddac05172cc3be2cfdf393361af965"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a6314feeddab87f5c120b2aeadc7061a1ec36e01","unresolved":false,"context_lines":[{"line_number":228,"context_line":"            machine \u003d self.manager.submitTask(_tasks.MachineCreate(**kwargs))"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"            if json_file:"},{"line_number":231,"context_line":"                with open(json_file) as nodes_f:"},{"line_number":232,"context_line":"                    nodes_data \u003d json.load(nodes_f)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"                    for node in nodes_data[\u0027nodes\u0027]:"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_94ceb781","line":231,"updated":"2016-07-18 12:36:32.000000000","message":"Not a nit, more of a out loud thought.\n\nIf I call shade with ansible and I add this feature to the ansible module, which could be executing on a remote server.... opening a file from my caller seems... problematic.  What if it was json network configuration mappings OR a file.\n\nThe other conundrum in my mind is that opening a file could actually become a risk if shade is ever put behind a REST interface.","commit_id":"c5a006274eddac05172cc3be2cfdf393361af965"}]}