)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"fd12282de65f2bd140772f7cca36075ee106d6a9","unresolved":false,"context_lines":[{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def _get_cache_time(self, resource_name):"},{"line_number":324,"context_line":"        return self.cloud_config.get_cache_resource_expiration("},{"line_number":325,"context_line":"            resource_name, None)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    def _get_cache(self, resource_name):"},{"line_number":328,"context_line":"        if resource_name and resource_name in self._resource_caches:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_3ad0d5c8","side":"PARENT","line":325,"updated":"2016-08-30 16:04:05.000000000","message":"See above note about SERVER_AGE and PORT_AGE","commit_id":"42eb9e307c47db1719a57b2e8820ec91c2e0da06"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"fd12282de65f2bd140772f7cca36075ee106d6a9","unresolved":false,"context_lines":[{"line_number":1364,"context_line":"            return self.manager.submit_task("},{"line_number":1365,"context_line":"                _tasks.SubnetList(**filters))[\u0027subnets\u0027]"},{"line_number":1366,"context_line":""},{"line_number":1367,"context_line":"    @_utils.cache_on_arguments(resource\u003d\u0027ports\u0027)"},{"line_number":1368,"context_line":"    def list_ports(self, filters\u003dNone):"},{"line_number":1369,"context_line":"        \"\"\"List all available ports."},{"line_number":1370,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_9a000136","side":"PARENT","line":1367,"updated":"2016-08-30 16:04:05.000000000","message":"This line is in error - it should be \"port\" not \"ports\" - however, when we re-introduce get_cache_time - perhaps we should allow it to work with both singular and plural.","commit_id":"42eb9e307c47db1719a57b2e8820ec91c2e0da06"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"fd12282de65f2bd140772f7cca36075ee106d6a9","unresolved":false,"context_lines":[{"line_number":63,"context_line":"# This halves the current default for Swift"},{"line_number":64,"context_line":"DEFAULT_MAX_FILE_SIZE \u003d (5 * 1024 * 1024 * 1024 + 2) / 2"},{"line_number":65,"context_line":"DEFAULT_SERVER_AGE \u003d 5"},{"line_number":66,"context_line":"DEFAULT_PORT_AGE \u003d 5"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"OBJECT_CONTAINER_ACLS \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_5a8599cc","line":66,"updated":"2016-08-30 16:04:05.000000000","message":"We can re-replace these with _get_cache_time safely I think.","commit_id":"3f226d151181fd476ee719cf2bc523f7c1fd7420"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"fd12282de65f2bd140772f7cca36075ee106d6a9","unresolved":false,"context_lines":[{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        def generate_key(*args, **kwargs):"},{"line_number":312,"context_line":"            arg_key \u003d \u0027,\u0027.join(args)"},{"line_number":313,"context_line":"            kw_keys \u003d sorted(kwargs.keys())"},{"line_number":314,"context_line":"            kwargs_key \u003d \u0027,\u0027.join("},{"line_number":315,"context_line":"                [\u0027%s:%s\u0027 % (k, kwargs[k]) for k in kw_keys if k !\u003d \u0027cache\u0027])"},{"line_number":316,"context_line":"            ans \u003d \"_\".join("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_ba4dc5c5","line":313,"updated":"2016-08-30 16:04:05.000000000","message":"This is likely also a safe/easy thing to re-apply","commit_id":"3f226d151181fd476ee719cf2bc523f7c1fd7420"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"fd12282de65f2bd140772f7cca36075ee106d6a9","unresolved":false,"context_lines":[{"line_number":4804,"context_line":""},{"line_number":4805,"context_line":"        # Reset the list servers cache time so that the next list server"},{"line_number":4806,"context_line":"        # call gets a new list"},{"line_number":4807,"context_line":"        self._servers_time \u003d self._servers_time - self._SERVER_AGE"},{"line_number":4808,"context_line":"        return True"},{"line_number":4809,"context_line":""},{"line_number":4810,"context_line":"    @_utils.valid_kwargs("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_1a31515a","line":4807,"updated":"2016-08-30 16:04:05.000000000","message":"For the record - I am not convinced this is a good idea. OTOH - it also might be related to the issues we saw.","commit_id":"3f226d151181fd476ee719cf2bc523f7c1fd7420"}]}
