)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"442ca2a4ad521a60ce341a04fdbb2b6f335ca5e3","unresolved":false,"context_lines":[{"line_number":6014,"context_line":"                name\u003dname, type_\u003dzone_type, email\u003demail,"},{"line_number":6015,"context_line":"                description\u003ddescription, ttl\u003dttl, masters\u003dmasters))"},{"line_number":6016,"context_line":"            self.list_zones.invalidate(self)"},{"line_number":6017,"context_line":"            return zones"},{"line_number":6018,"context_line":""},{"line_number":6019,"context_line":"    @_utils.valid_kwargs(\u0027email\u0027, \u0027description\u0027, \u0027ttl\u0027, \u0027masters\u0027)"},{"line_number":6020,"context_line":"    def update_zone(self, name_or_id, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_20113253","line":6017,"updated":"2016-10-05 13:08:49.000000000","message":"I think you want to unindent these last 2 lines one level. We don\u0027t call invalidate() within this context manager anywhere else (which would re-wrap any exceptions it might throw).","commit_id":"7b8f030bdf3ea69a9b28e998d0a426ca29d59a96"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"442ca2a4ad521a60ce341a04fdbb2b6f335ca5e3","unresolved":false,"context_lines":[{"line_number":6032,"context_line":""},{"line_number":6033,"context_line":"        :raises: OpenStackCloudException on operation error."},{"line_number":6034,"context_line":"        \"\"\""},{"line_number":6035,"context_line":"        zone \u003d self.get_zone(name_or_id)"},{"line_number":6036,"context_line":"        if not zone:"},{"line_number":6037,"context_line":"            raise OpenStackCloudException("},{"line_number":6038,"context_line":"                \"Zone %s not found.\" % name_or_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_a00aa2d0","line":6035,"updated":"2016-10-05 13:08:49.000000000","message":"Shouldn\u0027t we invalidate the cache before calling get_zone()?","commit_id":"7b8f030bdf3ea69a9b28e998d0a426ca29d59a96"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"442ca2a4ad521a60ce341a04fdbb2b6f335ca5e3","unresolved":false,"context_lines":[{"line_number":6042,"context_line":"            new_zone \u003d self.manager.submit_task("},{"line_number":6043,"context_line":"                _tasks.ZoneUpdate("},{"line_number":6044,"context_line":"                    zone\u003dzone[\u0027id\u0027], values\u003dkwargs))"},{"line_number":6045,"context_line":"            self.list_zones.invalidate(self)"},{"line_number":6046,"context_line":""},{"line_number":6047,"context_line":"        return new_zone"},{"line_number":6048,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_203852d3","line":6045,"updated":"2016-10-05 13:08:49.000000000","message":"Unindent.","commit_id":"7b8f030bdf3ea69a9b28e998d0a426ca29d59a96"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"442ca2a4ad521a60ce341a04fdbb2b6f335ca5e3","unresolved":false,"context_lines":[{"line_number":6056,"context_line":"        :raises: OpenStackCloudException on operation error."},{"line_number":6057,"context_line":"        \"\"\""},{"line_number":6058,"context_line":""},{"line_number":6059,"context_line":"        zone \u003d self.get_zone(name_or_id)"},{"line_number":6060,"context_line":"        if zone is None:"},{"line_number":6061,"context_line":"            self.log.debug(\"Zone %s not found for deleting\" % name_or_id)"},{"line_number":6062,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_401b9e1b","line":6059,"updated":"2016-10-05 13:08:49.000000000","message":"Invalidate cache before get_zone()?","commit_id":"7b8f030bdf3ea69a9b28e998d0a426ca29d59a96"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"442ca2a4ad521a60ce341a04fdbb2b6f335ca5e3","unresolved":false,"context_lines":[{"line_number":6065,"context_line":"                \"Error deleting zone {0}\".format(name_or_id)):"},{"line_number":6066,"context_line":"            self.manager.submit_task("},{"line_number":6067,"context_line":"                _tasks.ZoneDelete(zone\u003dzone[\u0027id\u0027]))"},{"line_number":6068,"context_line":"            self.list_zones.invalidate(self)"},{"line_number":6069,"context_line":""},{"line_number":6070,"context_line":"        return True"},{"line_number":6071,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_60325af3","line":6068,"updated":"2016-10-05 13:08:49.000000000","message":"Unindent.","commit_id":"7b8f030bdf3ea69a9b28e998d0a426ca29d59a96"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"442ca2a4ad521a60ce341a04fdbb2b6f335ca5e3","unresolved":false,"context_lines":[{"line_number":6131,"context_line":"                zone\u003dzone, name\u003dname, type_\u003drecordset_type, records\u003drecords,"},{"line_number":6132,"context_line":"                description\u003ddescription, ttl\u003dttl))"},{"line_number":6133,"context_line":"            self.list_recordsets.invalidate(self)"},{"line_number":6134,"context_line":"            return record_sets"},{"line_number":6135,"context_line":""},{"line_number":6136,"context_line":"    @_utils.valid_kwargs(\u0027description\u0027, \u0027ttl\u0027, \u0027records\u0027)"},{"line_number":6137,"context_line":"    def update_recordset(self, zone, name_or_id, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_c057ae00","line":6134,"updated":"2016-10-05 13:08:49.000000000","message":"Unindent.","commit_id":"7b8f030bdf3ea69a9b28e998d0a426ca29d59a96"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"442ca2a4ad521a60ce341a04fdbb2b6f335ca5e3","unresolved":false,"context_lines":[{"line_number":6152,"context_line":"            raise OpenStackCloudException("},{"line_number":6153,"context_line":"                \"Zone %s not found.\" % zone)"},{"line_number":6154,"context_line":""},{"line_number":6155,"context_line":"        recordset_obj \u003d self.get_recordset(zone, name_or_id)"},{"line_number":6156,"context_line":"        if recordset_obj is None:"},{"line_number":6157,"context_line":"            raise OpenStackCloudException("},{"line_number":6158,"context_line":"                \"Recordset %s not found.\" % name_or_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_40f2bed3","line":6155,"updated":"2016-10-05 13:08:49.000000000","message":"Invalidate cache before get_recordset()?","commit_id":"7b8f030bdf3ea69a9b28e998d0a426ca29d59a96"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"442ca2a4ad521a60ce341a04fdbb2b6f335ca5e3","unresolved":false,"context_lines":[{"line_number":6162,"context_line":"            new_recordset \u003d self.manager.submit_task("},{"line_number":6163,"context_line":"                _tasks.RecordSetUpdate("},{"line_number":6164,"context_line":"                    zone\u003dzone, recordset\u003dname_or_id, values\u003dkwargs))"},{"line_number":6165,"context_line":"            self.list_recordsets.invalidate(self)"},{"line_number":6166,"context_line":"        return new_recordset"},{"line_number":6167,"context_line":""},{"line_number":6168,"context_line":"    def delete_recordset(self, zone, name_or_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_203f72b5","line":6165,"updated":"2016-10-05 13:08:49.000000000","message":"Unindent.","commit_id":"7b8f030bdf3ea69a9b28e998d0a426ca29d59a96"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"442ca2a4ad521a60ce341a04fdbb2b6f335ca5e3","unresolved":false,"context_lines":[{"line_number":6176,"context_line":"        :raises: OpenStackCloudException on operation error."},{"line_number":6177,"context_line":"        \"\"\""},{"line_number":6178,"context_line":""},{"line_number":6179,"context_line":"        zone \u003d self.get_zone(zone)"},{"line_number":6180,"context_line":"        if zone is None:"},{"line_number":6181,"context_line":"            self.log.debug(\"Zone %s not found for deleting\" % zone)"},{"line_number":6182,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_e0b90aeb","line":6179,"updated":"2016-10-05 13:08:49.000000000","message":"Shouldn\u0027t we invalidate the cache before calling get_zone()?","commit_id":"7b8f030bdf3ea69a9b28e998d0a426ca29d59a96"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"442ca2a4ad521a60ce341a04fdbb2b6f335ca5e3","unresolved":false,"context_lines":[{"line_number":6181,"context_line":"            self.log.debug(\"Zone %s not found for deleting\" % zone)"},{"line_number":6182,"context_line":"            return False"},{"line_number":6183,"context_line":""},{"line_number":6184,"context_line":"        recordset \u003d self.get_recordset(zone[\u0027id\u0027], name_or_id)"},{"line_number":6185,"context_line":"        if recordset is None:"},{"line_number":6186,"context_line":"            self.log.debug(\"Recordset %s not found for deleting\" % name_or_id)"},{"line_number":6187,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_a0a622bf","line":6184,"updated":"2016-10-05 13:08:49.000000000","message":"And invalidate recordset cache?","commit_id":"7b8f030bdf3ea69a9b28e998d0a426ca29d59a96"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"442ca2a4ad521a60ce341a04fdbb2b6f335ca5e3","unresolved":false,"context_lines":[{"line_number":6190,"context_line":"                \"Error deleting recordset {0}\".format(name_or_id)):"},{"line_number":6191,"context_line":"            self.manager.submit_task("},{"line_number":6192,"context_line":"                _tasks.RecordSetDelete(zone\u003dzone[\u0027id\u0027], recordset\u003dname_or_id))"},{"line_number":6193,"context_line":"            self.list_recordsets.invalidate(self)"},{"line_number":6194,"context_line":""},{"line_number":6195,"context_line":"        return True"},{"line_number":6196,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_e073caaf","line":6193,"updated":"2016-10-05 13:08:49.000000000","message":"Unindent.","commit_id":"7b8f030bdf3ea69a9b28e998d0a426ca29d59a96"}]}
