)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a007acbcb217a4b198acb03fcfabb1f9a1853ca2","unresolved":false,"context_lines":[{"line_number":2438,"context_line":""},{"line_number":2439,"context_line":"    def download_image("},{"line_number":2440,"context_line":"            self, name_or_id, output_path\u003dNone, output_file\u003dNone,"},{"line_number":2441,"context_line":"            chunk_size\u003d1024):"},{"line_number":2442,"context_line":"        \"\"\"Download an image from glance by name or ID"},{"line_number":2443,"context_line":""},{"line_number":2444,"context_line":"        :param str name_or_id: Name or ID of the image."}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_dcdf3367","line":2441,"updated":"2016-12-05 11:04:28.000000000","message":"1024 is very low. For this kind of things I usually set it to 64k.\n\nSwift does 64k by default https://github.com/openstack/swift/blob/f0b3280e2b68f80709b3ea68a7bafb085af19d80/etc/object-server.conf-sample#L69\n\nAnd glance much more: https://github.com/openstack/glance_store/blob/5736659fe0edb4c8fd4d583a77017dc8beba774b/glance_store/driver.py#L36","commit_id":"9168dff6fb9cff68ae39b2c4cd4592539c49ad8a"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a007acbcb217a4b198acb03fcfabb1f9a1853ca2","unresolved":false,"context_lines":[{"line_number":2478,"context_line":"        with _utils.shade_exceptions(\"Unable to download image\"):"},{"line_number":2479,"context_line":"            if output_path:"},{"line_number":2480,"context_line":"                with open(output_path, \u0027wb\u0027) as fd:"},{"line_number":2481,"context_line":"                    for chunk in response.iter_content(chunk_size\u003d1024):"},{"line_number":2482,"context_line":"                        fd.write(chunk)"},{"line_number":2483,"context_line":"                return"},{"line_number":2484,"context_line":"            elif output_file:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_9cc85baa","line":2481,"updated":"2016-12-05 11:04:28.000000000","message":"s/chunk_size\u003d1024/chunk_size\u003dchunk_size/","commit_id":"9168dff6fb9cff68ae39b2c4cd4592539c49ad8a"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a007acbcb217a4b198acb03fcfabb1f9a1853ca2","unresolved":false,"context_lines":[{"line_number":2482,"context_line":"                        fd.write(chunk)"},{"line_number":2483,"context_line":"                return"},{"line_number":2484,"context_line":"            elif output_file:"},{"line_number":2485,"context_line":"                for chunk in response.iter_content(chunk_size\u003d1024):"},{"line_number":2486,"context_line":"                    output_file.write(chunk)"},{"line_number":2487,"context_line":"                return"},{"line_number":2488,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_bccd17b9","line":2485,"updated":"2016-12-05 11:04:28.000000000","message":"same","commit_id":"9168dff6fb9cff68ae39b2c4cd4592539c49ad8a"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7dd0fb15eca4c9d60f1e8d9bfda04af2709e538b","unresolved":false,"context_lines":[{"line_number":2478,"context_line":"        with _utils.shade_exceptions(\"Unable to download image\"):"},{"line_number":2479,"context_line":"            if output_path:"},{"line_number":2480,"context_line":"                with open(output_path, \u0027wb\u0027) as fd:"},{"line_number":2481,"context_line":"                    for chunk in response.iter_content(chunk_size\u003d1024):"},{"line_number":2482,"context_line":"                        fd.write(chunk)"},{"line_number":2483,"context_line":"                return"},{"line_number":2484,"context_line":"            elif output_file:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_33ad49e9","line":2481,"updated":"2016-12-07 11:09:30.000000000","message":"This should be chunk_size\u003dchunk_size","commit_id":"e40bd15f4c922f366e86ab24517edcc082638420"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"8ebfef411249f42ac45f9b3b8f722bba08d11561","unresolved":false,"context_lines":[{"line_number":2478,"context_line":"        with _utils.shade_exceptions(\"Unable to download image\"):"},{"line_number":2479,"context_line":"            if output_path:"},{"line_number":2480,"context_line":"                with open(output_path, \u0027wb\u0027) as fd:"},{"line_number":2481,"context_line":"                    for chunk in response.iter_content(chunk_size\u003d1024):"},{"line_number":2482,"context_line":"                        fd.write(chunk)"},{"line_number":2483,"context_line":"                return"},{"line_number":2484,"context_line":"            elif output_file:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_284bc12c","line":2481,"in_reply_to":"3a71b18c_33ad49e9","updated":"2016-12-08 23:35:58.000000000","message":"Done","commit_id":"e40bd15f4c922f366e86ab24517edcc082638420"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7dd0fb15eca4c9d60f1e8d9bfda04af2709e538b","unresolved":false,"context_lines":[{"line_number":2482,"context_line":"                        fd.write(chunk)"},{"line_number":2483,"context_line":"                return"},{"line_number":2484,"context_line":"            elif output_file:"},{"line_number":2485,"context_line":"                for chunk in response.iter_content(chunk_size\u003d1024):"},{"line_number":2486,"context_line":"                    output_file.write(chunk)"},{"line_number":2487,"context_line":"                return"},{"line_number":2488,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_73b3414d","line":2485,"updated":"2016-12-07 11:09:30.000000000","message":"This should be chunk_size\u003dchunk_size","commit_id":"e40bd15f4c922f366e86ab24517edcc082638420"}]}