)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"f1d2a7f5a7ec54e25e70ae7a8bfa3b7cef1334e1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add external_ipv4_floating_networks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Those network not properly tagged as external, even if the provider is \"physical_network\" shouldn\u0027t be part of the list of external networks. When shade tries to get a floating ip, made use of this list, but neutron will fail if the network is not configured as \"router:external \u003d True\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I2daa02805659ee2510a9203227d662161e60d51d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_981f555a","line":9,"updated":"2016-10-14 13:23:35.000000000","message":"If you wind up respinning this for any reason - please wrap this message.","commit_id":"b52655475ed0e1733c116b1e089775347b2afe92"}],"shade/openstackcloud.py":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"f1d2a7f5a7ec54e25e70ae7a8bfa3b7cef1334e1","unresolved":false,"context_lines":[{"line_number":1702,"context_line":"                    and network[\u0027router:external\u0027]) or"},{"line_number":1703,"context_line":"                    network.get(\u0027provider:physical_network\u0027)) and"},{"line_number":1704,"context_line":"                    network[\u0027name\u0027] not in self._internal_ipv4_names and"},{"line_number":1705,"context_line":"                    network[\u0027id\u0027] not in self._internal_ipv4_names):"},{"line_number":1706,"context_line":"                external_ipv4_networks.append(network)"},{"line_number":1707,"context_line":""},{"line_number":1708,"context_line":"            # Internal networks"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_184b455a","side":"PARENT","line":1705,"updated":"2016-10-14 13:23:35.000000000","message":"We need these two lines, because if a user has used clouds.yaml overrides to configure that a network is internal, it is then not external.","commit_id":"672c255cd5826b6d637b6dacf2edb423cdbf55c5"}]}
