)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"c31aa1bf55a338b34c17c3591c105f2267af6aea","unresolved":false,"context_lines":[{"line_number":2621,"context_line":"        if interface_type:"},{"line_number":2622,"context_line":"            filtered_ports \u003d []"},{"line_number":2623,"context_line":"            if (\u0027external_gateway_info\u0027 in router and"},{"line_number":2624,"context_line":"                \u0027external_fixed_ips\u0027 in router[\u0027external_gateway_info\u0027]):"},{"line_number":2625,"context_line":"                ext_fixed \u003d \\"},{"line_number":2626,"context_line":"                    router[\u0027external_gateway_info\u0027][\u0027external_fixed_ips\u0027]"},{"line_number":2627,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_41a192a8","side":"PARENT","line":2624,"updated":"2016-10-19 21:11:46.000000000","message":"Shouldn\u0027t this still fail if external_gateway_info is none? (I see the test - but I\u0027m worried the test is failing open - because doing \u0027external_fixed_ips\u0027 in None throws the error you mention.","commit_id":"ea04528cadc362b83cd64bb999a1bffec46ca14e"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"d158f23dcf49e9e13ffec0f34e4b63fd3a22d593","unresolved":false,"context_lines":[{"line_number":2621,"context_line":"        if interface_type:"},{"line_number":2622,"context_line":"            filtered_ports \u003d []"},{"line_number":2623,"context_line":"            if (\u0027external_gateway_info\u0027 in router and"},{"line_number":2624,"context_line":"                \u0027external_fixed_ips\u0027 in router[\u0027external_gateway_info\u0027]):"},{"line_number":2625,"context_line":"                ext_fixed \u003d \\"},{"line_number":2626,"context_line":"                    router[\u0027external_gateway_info\u0027][\u0027external_fixed_ips\u0027]"},{"line_number":2627,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_73e902b7","side":"PARENT","line":2624,"in_reply_to":"fa6399be_41a192a8","updated":"2016-10-20 07:43:26.000000000","message":"if external_gateway_info is none the whole if statement will read \"if None and \u0027external_fixed_ips\u0027 in router[\u0027external_gateway_info\u0027]\". But because of lazy evaluation, the second part of the if statement will never be evaluated. \n\nTry this: python -c \u0027if None and \"foo\" in None:  print(\"bar\")\u0027","commit_id":"ea04528cadc362b83cd64bb999a1bffec46ca14e"}]}
