)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"19e048b9dda939ab32d680591de56c1f1a71cadd","unresolved":false,"context_lines":[{"line_number":3729,"context_line":"                not self._floating_network_by_subnet_run):"},{"line_number":3730,"context_line":"            if self._floating_network_by_subnet_run:"},{"line_number":3731,"context_line":"                self._floating_network_by_subnet_lock.release()"},{"line_number":3732,"context_line":"                return self._floating_network_by_subnet"},{"line_number":3733,"context_line":"            try:"},{"line_number":3734,"context_line":"                for router in self.list_routers():"},{"line_number":3735,"context_line":"                    if router[\u0027admin_state_up\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_d87cc974","line":3732,"updated":"2016-10-19 14:04:39.000000000","message":"Please explain this: Once this code has run once and _floating_network_by_subnet_run is True, all other threads will attempt to get this lock in a non-blocking manner. Only one will get the lock and then return _floating_network_by_subnet. The threads that DO NOT get the lock will ALSO return _floating_network_by_subnet. I don\u0027t see how this solves a thundering herd problem.\n\nIn other words.. if you use a test for a non-None value for floating_network_by_subnet as the \"has run once check\" outside of the acquire(), you eliminate the need to keep trying to acquire a lock that is, effectively, useless.","commit_id":"9986646a131cf618476d24be18ab22f0da9de926"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"13b2b6daff5467d0757984997eff9e4ce9788838","unresolved":false,"context_lines":[{"line_number":3729,"context_line":"                not self._floating_network_by_subnet_run):"},{"line_number":3730,"context_line":"            if self._floating_network_by_subnet_run:"},{"line_number":3731,"context_line":"                self._floating_network_by_subnet_lock.release()"},{"line_number":3732,"context_line":"                return self._floating_network_by_subnet"},{"line_number":3733,"context_line":"            try:"},{"line_number":3734,"context_line":"                for router in self.list_routers():"},{"line_number":3735,"context_line":"                    if router[\u0027admin_state_up\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_58c5193a","line":3732,"in_reply_to":"fa6399be_d87cc974","updated":"2016-10-19 14:09:57.000000000","message":"Nevermind. I had to look more closely at the initial case to understand what this is solving.","commit_id":"9986646a131cf618476d24be18ab22f0da9de926"}]}
