)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"0ab5f580c28aa7f3fbb7970237b14b1e90da4e36","unresolved":false,"context_lines":[{"line_number":3023,"context_line":"                image_id\u003dimage.id, image_data\u003dimage_data))"},{"line_number":3024,"context_line":"        except Exception:"},{"line_number":3025,"context_line":"            self.log.debug(\"Deleting failed upload of image {image}\".format("},{"line_number":3026,"context_line":"                name\u003dname))"},{"line_number":3027,"context_line":"            self.manager.submit_task(_tasks.ImageDelete(image_id\u003dimage.id))"},{"line_number":3028,"context_line":"            raise"},{"line_number":3029,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_cfe076fd","line":3026,"updated":"2016-10-19 16:45:10.000000000","message":"That looks weird. Also that\u0027s not how you properly format string when you are logging. You should use\nself.log.debug(\u0027foo %s bar\u0027, \"my string\").\n\n\nThe point is, we should do lazy evaluation i.e not to string interpolation all the time.\n\nImagine I am using shade  but I am not interested in any sort of logging, then I don\u0027t want the expensive \u0027format\u0027 function call.","commit_id":"12424d6f79938f3cbedddc86629d47317ddab863"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"949ca22fbd9b14af020bd40456d838810cb87560","unresolved":false,"context_lines":[{"line_number":3023,"context_line":"                image_id\u003dimage.id, image_data\u003dimage_data))"},{"line_number":3024,"context_line":"        except Exception:"},{"line_number":3025,"context_line":"            self.log.debug(\"Deleting failed upload of image {image}\".format("},{"line_number":3026,"context_line":"                name\u003dname))"},{"line_number":3027,"context_line":"            self.manager.submit_task(_tasks.ImageDelete(image_id\u003dimage.id))"},{"line_number":3028,"context_line":"            raise"},{"line_number":3029,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_218c9e7e","line":3026,"in_reply_to":"fa6399be_cfe076fd","updated":"2016-10-19 21:02:58.000000000","message":"Fair enough. We should get someone to walk through the code and fix existing instances of that.","commit_id":"12424d6f79938f3cbedddc86629d47317ddab863"}]}
