)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"05652004d499f8a1e32f31a0ebfda860cafe67c7","unresolved":false,"context_lines":[{"line_number":2823,"context_line":"        return self._delete_image("},{"line_number":2824,"context_line":"            image, wait\u003dwait, timeout\u003dtimeout, delete_objects\u003ddelete_objects)"},{"line_number":2825,"context_line":""},{"line_number":2826,"context_line":"    def _delete_image("},{"line_number":2827,"context_line":"            self, image, wait\u003dFalse, timeout\u003d3600,"},{"line_number":2828,"context_line":"            delete_objects\u003dTrue):"},{"line_number":2829,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_49865114","line":2826,"updated":"2016-10-28 15:11:08.000000000","message":"What\u0027s the reason you\u0027re breaking this up into a private method?","commit_id":"3883a53993e5cf4ca304a984f923866c7511ec4b"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"841477f06f1857db67e68d164c2a0ab20ea24607","unresolved":false,"context_lines":[{"line_number":2823,"context_line":"        return self._delete_image("},{"line_number":2824,"context_line":"            image, wait\u003dwait, timeout\u003dtimeout, delete_objects\u003ddelete_objects)"},{"line_number":2825,"context_line":""},{"line_number":2826,"context_line":"    def _delete_image("},{"line_number":2827,"context_line":"            self, image, wait\u003dFalse, timeout\u003d3600,"},{"line_number":2828,"context_line":"            delete_objects\u003dTrue):"},{"line_number":2829,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_f0ba846d","line":2826,"in_reply_to":"ba5da102_49865114","updated":"2016-10-31 14:03:27.000000000","message":"+1 I don\"t understand why this new method is introduced. The code is not reused and the method name is not good. If we go that path, we will soon see someone introduce a method \u0027__delete_image\u0027 used only once in the \u0027_delete_image\u0027 method.","commit_id":"3883a53993e5cf4ca304a984f923866c7511ec4b"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"340d8d92557b7b742e231eb516b926e0e0ff43c5","unresolved":false,"context_lines":[{"line_number":2823,"context_line":"        return self._delete_image("},{"line_number":2824,"context_line":"            image, wait\u003dwait, timeout\u003dtimeout, delete_objects\u003ddelete_objects)"},{"line_number":2825,"context_line":""},{"line_number":2826,"context_line":"    def _delete_image("},{"line_number":2827,"context_line":"            self, image, wait\u003dFalse, timeout\u003d3600,"},{"line_number":2828,"context_line":"            delete_objects\u003dTrue):"},{"line_number":2829,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_d6457870","line":2826,"in_reply_to":"ba5da102_f0ba846d","updated":"2016-10-31 15:02:13.000000000","message":"I think that\u0027s leftover from a previous thought. Thanks.","commit_id":"3883a53993e5cf4ca304a984f923866c7511ec4b"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"05652004d499f8a1e32f31a0ebfda860cafe67c7","unresolved":false,"context_lines":[{"line_number":3037,"context_line":"            try:"},{"line_number":3038,"context_line":"                self.manager.submit_task(_tasks.ImageDelete(image_id\u003dimage.id))"},{"line_number":3039,"context_line":"            except Exception:"},{"line_number":3040,"context_line":"                # We\u0027re just trying to clean up - if it doens\u0027t work - shrug"},{"line_number":3041,"context_line":"                pass"},{"line_number":3042,"context_line":"            raise"},{"line_number":3043,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_54e184fd","line":3040,"updated":"2016-10-28 15:11:08.000000000","message":"/doens\u0027t/doesn\u0027t/","commit_id":"3883a53993e5cf4ca304a984f923866c7511ec4b"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"e55bdc93cddf4d93a1c6599cba7aa18ea73bf8d2","unresolved":false,"context_lines":[{"line_number":3037,"context_line":"            try:"},{"line_number":3038,"context_line":"                self.manager.submit_task(_tasks.ImageDelete(image_id\u003dimage.id))"},{"line_number":3039,"context_line":"            except Exception:"},{"line_number":3040,"context_line":"                # We\u0027re just trying to clean up - if it doens\u0027t work - shrug"},{"line_number":3041,"context_line":"                pass"},{"line_number":3042,"context_line":"            raise"},{"line_number":3043,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_63e31706","line":3040,"in_reply_to":"ba5da102_54e184fd","updated":"2016-10-31 10:48:34.000000000","message":"Is it worth logging something here?","commit_id":"3883a53993e5cf4ca304a984f923866c7511ec4b"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"05652004d499f8a1e32f31a0ebfda860cafe67c7","unresolved":false,"context_lines":[{"line_number":3058,"context_line":"                # Note argument is \"image\" here, \"image_id\" in V2"},{"line_number":3059,"context_line":"                self.manager.submit_task(_tasks.ImageDelete(image\u003dimage.id))"},{"line_number":3060,"context_line":"            except Exception:"},{"line_number":3061,"context_line":"                # We\u0027re just trying to clean up - if it doens\u0027t work - shrug"},{"line_number":3062,"context_line":"                pass"},{"line_number":3063,"context_line":"            raise"},{"line_number":3064,"context_line":"        return image"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_d41674f0","line":3061,"updated":"2016-10-28 15:11:08.000000000","message":"/doens\u0027t/doesn\u0027t/","commit_id":"3883a53993e5cf4ca304a984f923866c7511ec4b"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"e55bdc93cddf4d93a1c6599cba7aa18ea73bf8d2","unresolved":false,"context_lines":[{"line_number":3058,"context_line":"                # Note argument is \"image\" here, \"image_id\" in V2"},{"line_number":3059,"context_line":"                self.manager.submit_task(_tasks.ImageDelete(image\u003dimage.id))"},{"line_number":3060,"context_line":"            except Exception:"},{"line_number":3061,"context_line":"                # We\u0027re just trying to clean up - if it doens\u0027t work - shrug"},{"line_number":3062,"context_line":"                pass"},{"line_number":3063,"context_line":"            raise"},{"line_number":3064,"context_line":"        return image"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_83f2ebd0","line":3061,"in_reply_to":"ba5da102_d41674f0","updated":"2016-10-31 10:48:34.000000000","message":"ditto","commit_id":"3883a53993e5cf4ca304a984f923866c7511ec4b"}]}