)]}'
{"shade/tests/unit/test_caching.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"8666ead0328cfce4c90a4777d6f5685fbf268bc4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":"import concurrent"},{"line_number":15,"context_line":"import tempfile"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from glanceclient.v2 import shell"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_0415b73e","line":14,"updated":"2016-11-02 12:04:33.000000000","message":"This is not available in Py27. Tests pass because somehow python-futures is installed. But python-futures is not listed in our test-requirements.","commit_id":"29428a405995958b178f3b99c175ea0a2a28ed68"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"dbf764f4c5517943339ce0125f208b4e7ded6b12","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        with concurrent.futures.ThreadPoolExecutor(16) as pool:"},{"line_number":149,"context_line":"            for i in range(16):"},{"line_number":150,"context_line":"                pool.submit(lambda: self.cloud.list_servers())"},{"line_number":151,"context_line":"        self.assertNotEqual(1, len(nova_mock.servers.list.mock_calls))"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @mock.patch(\u0027shade.OpenStackCloud.nova_client\u0027)"},{"line_number":154,"context_line":"    def test_list_servers_no_herd(self, nova_mock):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_7f76a007","line":151,"updated":"2016-11-04 10:24:22.000000000","message":"If for any reason (nasty bug perhaps), nova_client.servers.list is never called, then this test will pass, where it shouldn\u0027t have. This should be\n\nself.assertGreater(1, nova_mock.servers.list.call_count)","commit_id":"92a43ec7c4933a71644c3925ef399a02f96b903f"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"e75bbdaacd2bfe3ac7de32b25f2e83bc05a38273","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        with concurrent.futures.ThreadPoolExecutor(16) as pool:"},{"line_number":149,"context_line":"            for i in range(16):"},{"line_number":150,"context_line":"                pool.submit(lambda: self.cloud.list_servers())"},{"line_number":151,"context_line":"        self.assertNotEqual(1, len(nova_mock.servers.list.mock_calls))"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @mock.patch(\u0027shade.OpenStackCloud.nova_client\u0027)"},{"line_number":154,"context_line":"    def test_list_servers_no_herd(self, nova_mock):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_b7be89fd","line":151,"in_reply_to":"ba5da102_7f76a007","updated":"2016-11-07 19:16:32.000000000","message":"Done","commit_id":"92a43ec7c4933a71644c3925ef399a02f96b903f"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"dbf764f4c5517943339ce0125f208b4e7ded6b12","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        with concurrent.futures.ThreadPoolExecutor(16) as pool:"},{"line_number":159,"context_line":"            for i in range(16):"},{"line_number":160,"context_line":"                pool.submit(lambda: self.cloud.list_servers())"},{"line_number":161,"context_line":"        self.assertEqual(1, len(nova_mock.servers.list.mock_calls))"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    @mock.patch(\u0027shade.OpenStackCloud.cinder_client\u0027)"},{"line_number":164,"context_line":"    def test_list_volumes(self, cinder_mock):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_3f3ee829","line":161,"updated":"2016-11-04 10:24:22.000000000","message":"Nit: This could be\n   self.assertEqual(1, nova_mock.servers.list.call_count)\n\nWhich convey better the meaning of this test.","commit_id":"92a43ec7c4933a71644c3925ef399a02f96b903f"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"e75bbdaacd2bfe3ac7de32b25f2e83bc05a38273","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        with concurrent.futures.ThreadPoolExecutor(16) as pool:"},{"line_number":159,"context_line":"            for i in range(16):"},{"line_number":160,"context_line":"                pool.submit(lambda: self.cloud.list_servers())"},{"line_number":161,"context_line":"        self.assertEqual(1, len(nova_mock.servers.list.mock_calls))"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    @mock.patch(\u0027shade.OpenStackCloud.cinder_client\u0027)"},{"line_number":164,"context_line":"    def test_list_volumes(self, cinder_mock):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_57460d24","line":161,"in_reply_to":"ba5da102_3f3ee829","updated":"2016-11-07 19:16:32.000000000","message":"Done","commit_id":"92a43ec7c4933a71644c3925ef399a02f96b903f"}],"test-requirements.txt":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"dbf764f4c5517943339ce0125f208b4e7ded6b12","unresolved":false,"context_lines":[{"line_number":13,"context_line":"testtools\u003e\u003d0.9.32"},{"line_number":14,"context_line":"warlock\u003e\u003d1.0.1,\u003c2"},{"line_number":15,"context_line":"reno"},{"line_number":16,"context_line":"futures"}],"source_content_type":"text/plain","patch_set":2,"id":"ba5da102_bfdbd820","line":16,"updated":"2016-11-04 10:24:22.000000000","message":"You don\u0027t want futures to be installed on python\u003e\u003d3.2 otherwise this is going to be hard to know which \u0027concurrent\u0027 you are using.\n\nI suggest this line should be\n  futures;python_version\u003c\u00273.2\u0027","commit_id":"92a43ec7c4933a71644c3925ef399a02f96b903f"}]}
