)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"af9f56151e3366db34d8e54950a12a641ba97850","unresolved":false,"context_lines":[{"line_number":1710,"context_line":"                # filtering, so it\u0027s safer to die hard than to fallback to Nova"},{"line_number":1711,"context_line":"                # which may return more results that expected."},{"line_number":1712,"context_line":"                if filters:"},{"line_number":1713,"context_line":"                    raise"},{"line_number":1714,"context_line":"                self.log.debug("},{"line_number":1715,"context_line":"                    \"Something went wrong talking to neutron API: \""},{"line_number":1716,"context_line":"                    \"\u0027%(msg)s\u0027. Trying with Nova.\", {\u0027msg\u0027: str(e)})"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_8a6c0238","line":1713,"updated":"2016-11-04 18:13:23.000000000","message":"I just wrote up a longish thing where I was disagreeing with your logic about failing - and by the end of it I\u0027d convinced myself that you\u0027re right.\n\nThat said - I think a debug log statement similar to the one below would be good. Perhaps adding a mention that just using search_floating_ips is likely a better choice since search can decide to pushdown or not as is appropriate.\n\n(we should then likely add logic in search to push down filters it has, if it has them and if we use neutron floating ips ...)","commit_id":"3ec050abb1795f420c4037c62b2dd2d3ca569759"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"808b950f0960013cd60f54fbd0c7bf25e56c779f","unresolved":false,"context_lines":[{"line_number":1728,"context_line":"            if filters:"},{"line_number":1729,"context_line":"                raise ValueError("},{"line_number":1730,"context_line":"                    \"Nova-network don\u0027t support server-side floating ips \""},{"line_number":1731,"context_line":"                    \"filtering. Use the search_floatting_ips method instead\""},{"line_number":1732,"context_line":"                )"},{"line_number":1733,"context_line":""},{"line_number":1734,"context_line":"        floating_ips \u003d self._nova_list_floating_ips()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a629dbe_1353c8e2","line":1731,"updated":"2016-11-07 19:48:30.000000000","message":"Minor typo here, method name is search_floating_ips (one \u0027t\u0027).\n\nAlso instead of raising here why not do the following:\n\n  list_floating_ips():\n      if filters and neutron:\n          query_neutron_api_with_filter\n      if (neutron and failed) or nova net:\n          query_nova_api\n          filter locally\n\nI think that would allow you to support filters for both nova net and neutron and at the same time make teh control flow here much more readable.\n\nAs is we have a lot of gotchas some of which the user may not even be able to control which isn\u0027t great for the user. And it has led to more complicated flow.\n\nAn alternative would be that search_floating_ips is the only place you can use filters then support both nova net and neutron there.","commit_id":"958f97255289763b910c37307933cbe57fd484ba"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"ab25e45534537127aebc446bc96b259aa7cd3aa2","unresolved":false,"context_lines":[{"line_number":1728,"context_line":"            if filters:"},{"line_number":1729,"context_line":"                raise ValueError("},{"line_number":1730,"context_line":"                    \"Nova-network don\u0027t support server-side floating ips \""},{"line_number":1731,"context_line":"                    \"filtering. Use the search_floatting_ips method instead\""},{"line_number":1732,"context_line":"                )"},{"line_number":1733,"context_line":""},{"line_number":1734,"context_line":"        floating_ips \u003d self._nova_list_floating_ips()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a629dbe_b9e75b11","line":1731,"in_reply_to":"9a629dbe_1353c8e2","updated":"2016-11-07 20:42:05.000000000","message":"I pushed up a follow up patch with this logic added.","commit_id":"958f97255289763b910c37307933cbe57fd484ba"}]}