)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"f64162c6f8cbccfa137aa5edcf12efe6b2683257","unresolved":false,"context_lines":[{"line_number":3088,"context_line":"        for k, v in iter(properties.items()):"},{"line_number":3089,"context_line":"            if k in (\u0027min_disk\u0027, \u0027min_ram\u0027, \u0027size\u0027, \u0027virtual_size\u0027):"},{"line_number":3090,"context_line":"                ret[k] \u003d int(v)"},{"line_number":3091,"context_line":"            elif k in (\u0027protected\u0027):"},{"line_number":3092,"context_line":"                ret[k] \u003d v"},{"line_number":3093,"context_line":"            else:"},{"line_number":3094,"context_line":"                if v is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_d93a77e7","line":3091,"updated":"2016-11-14 18:42:06.000000000","message":"This is not a tuple unless it has a \u0027,\u0027.  So really this is:\n  elif k in \u0027protected\u0027:\nWhich is a substring match.  \u0027protected\u0027 is a substring of \u0027protected\u0027, so this will work as far as that goes.   However, \u0027pro\u0027 would also work.  That seem suboptimal.\n\nYou could do:\n  elif k in (\u0027protected\u0027,):\nor:\n  elif k in [\u0027protected\u0027]:\nor:\n  elif k \u003d\u003d \u0027protected\u0027:","commit_id":"f907887464ccec94b25dd3f9bae4c93d238645c7"}]}
