)]}'
{"shade/tests/unit/base.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"10938157ee8371f533365efc8db48abe1166e02f","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                self.adapter.request_history[x].method)"},{"line_number":160,"context_line":"            self.assertEqual("},{"line_number":161,"context_line":"                self.calls[x][\u0027url\u0027],"},{"line_number":162,"context_line":"                self.adapter.request_history[x].url)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_8f787ffa","line":162,"updated":"2016-12-19 17:25:47.000000000","message":"In a similar method in Zuul, I added a 3rd argument to assertequal with the index here, so if something goes wrong, it will tell you that call #12 was the one that wasn\u0027t equal.  Especially since you\u0027re accumulating all calls in the method, that could be really useful (you may have several identical calls).  You might want to do that for both of these assertequals.","commit_id":"b3b833c69e23193aa28a9eef230e1775d2743ef4"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"218606c3dca218f564e339ad5b2ea4be20574654","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                self.adapter.request_history[x].method)"},{"line_number":160,"context_line":"            self.assertEqual("},{"line_number":161,"context_line":"                self.calls[x][\u0027url\u0027],"},{"line_number":162,"context_line":"                self.adapter.request_history[x].url)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_5d1a9d6f","line":162,"in_reply_to":"1a6eadb0_8f787ffa","updated":"2016-12-19 17:54:06.000000000","message":"Yes - this is a great idea. I\u0027ve done it in a follow up patch.","commit_id":"b3b833c69e23193aa28a9eef230e1775d2743ef4"}],"shade/tests/unit/test_image.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"10938157ee8371f533365efc8db48abe1166e02f","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                    id\u003dself.image_id)),"},{"line_number":178,"context_line":"            dict(method\u003d\u0027GET\u0027, url\u003d\u0027https://image.example.com/v2/images\u0027),"},{"line_number":179,"context_line":"        ]"},{"line_number":180,"context_line":"        self.assert_calls()"},{"line_number":181,"context_line":"        self.assertEqual("},{"line_number":182,"context_line":"            self.adapter.request_history[4].json(), {"},{"line_number":183,"context_line":"                u\u0027container_format\u0027: u\u0027bare\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_6f1de3bc","line":180,"updated":"2016-12-19 17:25:47.000000000","message":"What about just passing the list into assert_calls?  (assert_calls could do the implicit prepend of the keystone calls -- and you could add a flag to disable that later if needed)  That might be a slightly more straightforward implementation.","commit_id":"b3b833c69e23193aa28a9eef230e1775d2743ef4"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"218606c3dca218f564e339ad5b2ea4be20574654","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                    id\u003dself.image_id)),"},{"line_number":178,"context_line":"            dict(method\u003d\u0027GET\u0027, url\u003d\u0027https://image.example.com/v2/images\u0027),"},{"line_number":179,"context_line":"        ]"},{"line_number":180,"context_line":"        self.assert_calls()"},{"line_number":181,"context_line":"        self.assertEqual("},{"line_number":182,"context_line":"            self.adapter.request_history[4].json(), {"},{"line_number":183,"context_line":"                u\u0027container_format\u0027: u\u0027bare\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_fd952988","line":180,"in_reply_to":"1a6eadb0_6f1de3bc","updated":"2016-12-19 17:54:06.000000000","message":"Maybe - this one is a little trickier. But I\u0027ve been thinking about refactoring the self.calls interface to allow for listing the urls to register too (one list of calls and responses rather than two) I think we can do this as part of that.","commit_id":"b3b833c69e23193aa28a9eef230e1775d2743ef4"}]}