)]}'
{"shade/_utils.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"115cc649cd0083e271b7a14d426e126fba1f5736","unresolved":false,"context_lines":[{"line_number":638,"context_line":"        return chunk"},{"line_number":639,"context_line":""},{"line_number":640,"context_line":"    @property"},{"line_number":641,"context_line":"    def reset(self):"},{"line_number":642,"context_line":"        self._file.seek(self.offset, 0)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_8475f3cb","line":641,"updated":"2017-01-18 13:26:00.000000000","message":"Why is this a property?","commit_id":"3175523bb1ea806d95c566117db617978abb4dd9"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"0551b8f65923946f0efa7f3232ccf565c5487f0b","unresolved":false,"context_lines":[{"line_number":638,"context_line":"        return chunk"},{"line_number":639,"context_line":""},{"line_number":640,"context_line":"    @property"},{"line_number":641,"context_line":"    def reset(self):"},{"line_number":642,"context_line":"        self._file.seek(self.offset, 0)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_eb8106c5","line":641,"in_reply_to":"7a3c09a3_4e4ec13b","updated":"2017-01-18 20:49:03.000000000","message":"i ... what? this is just bizarre\n\nI\u0027m guessing it is because someone was lazy and didn\u0027t wnat to type \u003cthing\u003e.reset() and just wanted to do thing.reset","commit_id":"3175523bb1ea806d95c566117db617978abb4dd9"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"a4d8b8275b80b21c6eedfe5605bacdbbe039a7b8","unresolved":false,"context_lines":[{"line_number":638,"context_line":"        return chunk"},{"line_number":639,"context_line":""},{"line_number":640,"context_line":"    @property"},{"line_number":641,"context_line":"    def reset(self):"},{"line_number":642,"context_line":"        self._file.seek(self.offset, 0)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_4e4ec13b","line":641,"in_reply_to":"7a3c09a3_8475f3cb","updated":"2017-01-18 15:34:42.000000000","message":"Weird. No clue.","commit_id":"3175523bb1ea806d95c566117db617978abb4dd9"}],"shade/openstackcloud.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"115cc649cd0083e271b7a14d426e126fba1f5736","unresolved":false,"context_lines":[{"line_number":5703,"context_line":"            segments[name] \u003d segment"},{"line_number":5704,"context_line":"        return segments"},{"line_number":5705,"context_line":""},{"line_number":5706,"context_line":"    def _upload_large_object("},{"line_number":5707,"context_line":"        self, endpoint, filename, headers, file_size, segment_size, use_slo):"},{"line_number":5708,"context_line":""},{"line_number":5709,"context_line":"        segment_futures \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_975447ca","line":5706,"updated":"2017-01-18 13:26:00.000000000","message":"This entire method is complex and makes my head hurt. Can we at least add some comments for each of the for-loops describing what each is doing? Not only would it break up the method visually, but would help in understanding it.","commit_id":"3175523bb1ea806d95c566117db617978abb4dd9"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"0551b8f65923946f0efa7f3232ccf565c5487f0b","unresolved":false,"context_lines":[{"line_number":5703,"context_line":"            segments[name] \u003d segment"},{"line_number":5704,"context_line":"        return segments"},{"line_number":5705,"context_line":""},{"line_number":5706,"context_line":"    def _upload_large_object("},{"line_number":5707,"context_line":"        self, endpoint, filename, headers, file_size, segment_size, use_slo):"},{"line_number":5708,"context_line":""},{"line_number":5709,"context_line":"        segment_futures \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_eb9d860b","line":5706,"in_reply_to":"7a3c09a3_975447ca","updated":"2017-01-18 20:49:03.000000000","message":"++","commit_id":"3175523bb1ea806d95c566117db617978abb4dd9"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"a4d8b8275b80b21c6eedfe5605bacdbbe039a7b8","unresolved":false,"context_lines":[{"line_number":5703,"context_line":"            segments[name] \u003d segment"},{"line_number":5704,"context_line":"        return segments"},{"line_number":5705,"context_line":""},{"line_number":5706,"context_line":"    def _upload_large_object("},{"line_number":5707,"context_line":"        self, endpoint, filename, headers, file_size, segment_size, use_slo):"},{"line_number":5708,"context_line":""},{"line_number":5709,"context_line":"        segment_futures \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_3c3d2fc4","line":5706,"in_reply_to":"7a3c09a3_975447ca","updated":"2017-01-18 15:34:42.000000000","message":"Done","commit_id":"3175523bb1ea806d95c566117db617978abb4dd9"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"115cc649cd0083e271b7a14d426e126fba1f5736","unresolved":false,"context_lines":[{"line_number":5722,"context_line":"        for completed in concurrent.futures.as_completed(segment_futures):"},{"line_number":5723,"context_line":"            try:"},{"line_number":5724,"context_line":"                result \u003d completed.result()"},{"line_number":5725,"context_line":"                if 500 \u003c\u003d result.status_code \u003c 600:"},{"line_number":5726,"context_line":"                    retry_result.append(result)"},{"line_number":5727,"context_line":"                else:"},{"line_number":5728,"context_line":"                    raise_from_response(result)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_57c73f95","line":5725,"updated":"2017-01-18 13:26:00.000000000","message":"Are these magic numbers HTTP error codes? Can we get a quick one-line comment on this check?","commit_id":"3175523bb1ea806d95c566117db617978abb4dd9"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"0551b8f65923946f0efa7f3232ccf565c5487f0b","unresolved":false,"context_lines":[{"line_number":5722,"context_line":"        for completed in concurrent.futures.as_completed(segment_futures):"},{"line_number":5723,"context_line":"            try:"},{"line_number":5724,"context_line":"                result \u003d completed.result()"},{"line_number":5725,"context_line":"                if 500 \u003c\u003d result.status_code \u003c 600:"},{"line_number":5726,"context_line":"                    retry_result.append(result)"},{"line_number":5727,"context_line":"                else:"},{"line_number":5728,"context_line":"                    raise_from_response(result)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_4bd77abf","line":5725,"in_reply_to":"7a3c09a3_1c595335","updated":"2017-01-18 20:49:03.000000000","message":"so.. what is this meant to indicate? before you remove it... curious what it is meant to do.","commit_id":"3175523bb1ea806d95c566117db617978abb4dd9"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"a4d8b8275b80b21c6eedfe5605bacdbbe039a7b8","unresolved":false,"context_lines":[{"line_number":5722,"context_line":"        for completed in concurrent.futures.as_completed(segment_futures):"},{"line_number":5723,"context_line":"            try:"},{"line_number":5724,"context_line":"                result \u003d completed.result()"},{"line_number":5725,"context_line":"                if 500 \u003c\u003d result.status_code \u003c 600:"},{"line_number":5726,"context_line":"                    retry_result.append(result)"},{"line_number":5727,"context_line":"                else:"},{"line_number":5728,"context_line":"                    raise_from_response(result)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_1c595335","line":5725,"in_reply_to":"7a3c09a3_57c73f95","updated":"2017-01-18 15:34:42.000000000","message":"Actually - you know what? I don\u0027t think we need them at all.","commit_id":"3175523bb1ea806d95c566117db617978abb4dd9"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"24897fef57ab5cfc3d7ec757f506af89771e3d4d","unresolved":false,"context_lines":[{"line_number":5890,"context_line":"        return self._object_store_client.put("},{"line_number":5891,"context_line":"            endpoint,"},{"line_number":5892,"context_line":"            params\u003d{\u0027multipart-manifest\u0027: \u0027put\u0027},"},{"line_number":5893,"context_line":"            headers\u003dheaders, json\u003dmanifest)"},{"line_number":5894,"context_line":""},{"line_number":5895,"context_line":"    def _finish_large_object_dlo(self, endpoint, headers):"},{"line_number":5896,"context_line":"        headers \u003d headers.copy()"}],"source_content_type":"text/x-python","patch_set":19,"id":"5a3905b3_efcecc2b","line":5893,"updated":"2017-01-23 12:04:32.000000000","message":"According to the response in https://bugs.launchpad.net/swift/+bug/1658295 the \"json\u003d\" arg might be wrong.","commit_id":"b7ea6c7150cad5e17404edb5401d5eead827041d"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"fa7d46461c1dd07dabc9534fb6c9d5e521d0b68f","unresolved":false,"context_lines":[{"line_number":5890,"context_line":"        return self._object_store_client.put("},{"line_number":5891,"context_line":"            endpoint,"},{"line_number":5892,"context_line":"            params\u003d{\u0027multipart-manifest\u0027: \u0027put\u0027},"},{"line_number":5893,"context_line":"            headers\u003dheaders, json\u003dmanifest)"},{"line_number":5894,"context_line":""},{"line_number":5895,"context_line":"    def _finish_large_object_dlo(self, endpoint, headers):"},{"line_number":5896,"context_line":"        headers \u003d headers.copy()"}],"source_content_type":"text/x-python","patch_set":19,"id":"5a3905b3_7c8c29da","line":5893,"in_reply_to":"5a3905b3_efcecc2b","updated":"2017-01-24 08:42:30.000000000","message":"Good catch. Fixed in a follow up change.","commit_id":"b7ea6c7150cad5e17404edb5401d5eead827041d"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"612b39adb244f6b7e906dddae78c0dc4d47818d4","unresolved":false,"context_lines":[{"line_number":5890,"context_line":"        return self._object_store_client.put("},{"line_number":5891,"context_line":"            endpoint,"},{"line_number":5892,"context_line":"            params\u003d{\u0027multipart-manifest\u0027: \u0027put\u0027},"},{"line_number":5893,"context_line":"            headers\u003dheaders, json\u003dmanifest)"},{"line_number":5894,"context_line":""},{"line_number":5895,"context_line":"    def _finish_large_object_dlo(self, endpoint, headers):"},{"line_number":5896,"context_line":"        headers \u003d headers.copy()"}],"source_content_type":"text/x-python","patch_set":19,"id":"5a3905b3_4c7fc9df","line":5893,"in_reply_to":"5a3905b3_efcecc2b","updated":"2017-01-24 00:39:10.000000000","message":"Yes - thanks! I have fixed this a more betterer way in a followup patch.","commit_id":"b7ea6c7150cad5e17404edb5401d5eead827041d"}]}