)]}'
{"shade/meta.py":[{"author":{"_account_id":24647,"name":"Roberto Polli","email":"robipolli@gmail.com","username":"ioggstream"},"change_message_id":"e0c3fa541591db008ec765bccb60562d5e4ddbf4","unresolved":false,"context_lines":[{"line_number":324,"context_line":"                        # This SHOULD return one and only one FIP - but doing"},{"line_number":325,"context_line":"                        # it as a search/list lets the logic work regardless"},{"line_number":326,"context_line":"                    if fip[\u0027fixed_ip_address\u0027] not in fixed_ip_mapping:"},{"line_number":327,"context_line":"                        raise exc.OpenStackCloudException("},{"line_number":328,"context_line":"                            \"The cloud returned floating ip {fip} attached\""},{"line_number":329,"context_line":"                            \" to server {server} but the fixed ip associated\""},{"line_number":330,"context_line":"                            \" with the floating ip in the neutron listing\""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_078053bf","line":327,"updated":"2017-01-23 15:56:18.000000000","message":"iuuc, this exception is trapped and passed (unlogged) at line:346","commit_id":"7fb3b23d8d1ed5e045d5d3fe66912af34754af95"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"20a4b7bfe7bee00d633e16273d50256759335d70","unresolved":false,"context_lines":[{"line_number":342,"context_line":"                            has_address \u003d True"},{"line_number":343,"context_line":"                    if not has_address:"},{"line_number":344,"context_line":"                        server[\u0027addresses\u0027][fixed_net].append("},{"line_number":345,"context_line":"                            _make_address_dict(fip))"},{"line_number":346,"context_line":"    except exc.OpenStackCloudException:"},{"line_number":347,"context_line":"        # If something goes wrong with a cloud call, that\u0027s cool - this is"},{"line_number":348,"context_line":"        # an attempt to provide additional data and should not block forward"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_e7d2355b","line":345,"updated":"2017-01-24 13:05:35.000000000","message":"Hmm, we must not have a test hitting this bit of code because _make_address_dict() now requires two parameters and you\u0027re still only supplying one.","commit_id":"7fb3b23d8d1ed5e045d5d3fe66912af34754af95"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"c64e4328b60400330a3b017626bd369ffe6c672b","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                    fixed_net \u003d fixed_ip_mapping[fip[\u0027fixed_ip_address\u0027]]"},{"line_number":335,"context_line":"                    # This check should not be needed, because we should"},{"line_number":336,"context_line":"                    # never get here unless the server didn\u0027t have nova"},{"line_number":337,"context_line":"                    # supplied floating ips anyway. BUT - let\u0027s be sure."},{"line_number":338,"context_line":"                    server[\u0027addresses\u0027][fixed_net].append("},{"line_number":339,"context_line":"                        _make_address_dict(fip, port))"},{"line_number":340,"context_line":"    except exc.OpenStackCloudException:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_ec3f6bd4","line":337,"updated":"2017-01-25 13:08:27.000000000","message":"It\u0027s SO not needed that you actually removed it!","commit_id":"6e8dbb849d80d8e2840bca07ca73141f45e6cde6"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"0eb2c9be358c781efa672e6b1e52f438d82663ec","unresolved":false,"context_lines":[{"line_number":329,"context_line":"                            \" to server {server} but the fixed ip associated\""},{"line_number":330,"context_line":"                            \" with the floating ip in the neutron listing\""},{"line_number":331,"context_line":"                            \" does not exist in the nova listing. Something\""},{"line_number":332,"context_line":"                            \" is exceptionally broken.\".format("},{"line_number":333,"context_line":"                                fip\u003dfip[\u0027id\u0027], server\u003dserver[\u0027id\u0027]))"},{"line_number":334,"context_line":"                    fixed_net \u003d fixed_ip_mapping[fip[\u0027fixed_ip_address\u0027]]"},{"line_number":335,"context_line":"                    server[\u0027addresses\u0027][fixed_net].append("},{"line_number":336,"context_line":"                        _make_address_dict(fip, port))"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_a252bfdb","line":333,"range":{"start_line":332,"start_character":56,"end_line":333,"end_character":66},"updated":"2017-01-25 17:12:22.000000000","message":"FTR: This is not needed, you can just do: \n\n  log.debug(\"The cloud returned floating ip {fip}\"\n            \" to server {server} but the fixed ip associated\"\n            \" with the floating ip in the neutron listing\"\n            \" does not exist in the nova listing. Something\"\n            \" is exceptionally broken.\", \u003creplacement dict/values/etc, in *args form\u003e)\n\nalso .format is masssssively slower than % and other strsub methods in python.","commit_id":"716cbde139a79f27b3dc245dbd36611b3e5f96fa"}]}